From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 0B7101B818 for ; Tue, 15 May 2018 15:47:44 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id a12-v6so191072wrn.13 for ; Tue, 15 May 2018 06:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=76U4ALuOJj7Dyj108Yj4hBegFi2fG9jiNynWG+vxdbM=; b=IcowPVxIddCRmf+vpCtARJnM3d9ZAMVzXXZpZYRKF+gst7ZlXi0QYMDQSF04hdcEli FsWscrqnySCPdvHxbxzji7aGg+5D1pPCfhpuqQja4doeLvmG/MhnvvU5mQ4rWYfv+wVn KzH2DvWX0ThBfenF6J8e8JHqwlEOs94hvtw3V8TIhm/wMbEDrSHRApdMheKgYTstXldl fc9DRRe7m/VDzaRdHiLzgVI561p966mSAEqIJ27twv59bnaxUBVZXXLqBmIWcaxGXCXM oxo4GZ9l2mi957svriYCnfaCIUbAU2rqsGeyM8hucrR89g99NS9ToS80LiQCbpgwT7tO tz3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=76U4ALuOJj7Dyj108Yj4hBegFi2fG9jiNynWG+vxdbM=; b=qIzZIai5yT0PcRDUdq5l3Vjuwjq1Gd7UaUyrzTg6mHxPfc2m3u3H7anEOu002+nTC0 V2tBDIV5vPpg/07TybMSTsUbJIFC54OjUq3CoEjtAeCzLmEgumvMwKUShSpoKaP5m57e f+4Ssvr1d86vv6Z184+twnySOXy/psxNsAkEiTXznLRrlyxpJ6tPIQ3eMmsCvXFrvRJ4 Ao+99nNrs5ROD/Dw5PerBoqn8LHj8RH0StDbU6FlKQx3oRw4/JoTWBIbN8GYSY37wakS 1+nTUhqn6w/7qk2wNzBcaAPslUhUKmQklT8NrsdVBJWLWLpOFoN4bZccxJvC6DfBi1cU 6oeA== X-Gm-Message-State: ALKqPwco/fQmvALt7lVFnoOLgudEBK+9XBC3cDH/L/8qbNGPQeKBZG2L l1Zz7anWqVp/IIz1faDOnnN7L5di X-Google-Smtp-Source: AB8JxZrkG25ztvUGH+drUq9iajfP+WVfnlMN8lE54ktMP6LnN4eJ23uBo4SizZJaB+9Cm8LGVqgGXg== X-Received: by 2002:adf:e749:: with SMTP id c9-v6mr11366130wrn.203.1526392063753; Tue, 15 May 2018 06:47:43 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id d17-v6sm149269wrc.0.2018.05.15.06.47.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 06:47:42 -0700 (PDT) From: luca.boccassi@gmail.com To: Nipun Gupta Cc: Hemant Agrawal , dpdk stable Date: Tue, 15 May 2018 14:46:13 +0100 Message-Id: <20180515134731.9337-2-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180515134731.9337-1-luca.boccassi@gmail.com> References: <20180503110612.12146-2-luca.boccassi@gmail.com> <20180515134731.9337-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'event/dpaa2: remove check on epoll return' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 13:47:44 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/16/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From fd92d1ca6266da449af9ee716bb3ae52ae925f02 Mon Sep 17 00:00:00 2001 From: Nipun Gupta Date: Wed, 9 May 2018 14:50:52 +0530 Subject: [PATCH] event/dpaa2: remove check on epoll return [ upstream commit 3c21086bcb3786f76ad51d067f9498155aa278af ] Driver shouldn't take decision on signals received. The return from epoll was blocking on EINTR which is not the right use-case. Fixes: 36d87bb92230 ("event/dpaa2: handle timeout using interrupts in dequeue") Signed-off-by: Nipun Gupta Acked-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index c3e6fbff1..977e8df85 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/drivers/event/dpaa2/dpaa2_eventdev.c @@ -153,26 +153,12 @@ dpaa2_eventdev_enqueue(void *port, const struct rte_event *ev) static void dpaa2_eventdev_dequeue_wait(uint64_t timeout_ticks) { struct epoll_event epoll_ev; - int ret, i = 0; qbman_swp_interrupt_clear_status(DPAA2_PER_LCORE_PORTAL, QBMAN_SWP_INTERRUPT_DQRI); -RETRY: - ret = epoll_wait(DPAA2_PER_LCORE_DPIO->epoll_fd, + epoll_wait(DPAA2_PER_LCORE_DPIO->epoll_fd, &epoll_ev, 1, timeout_ticks); - if (ret < 1) { - /* sometimes due to some spurious interrupts epoll_wait fails - * with errno EINTR. so here we are retrying epoll_wait in such - * case to avoid the problem. - */ - if (errno == EINTR) { - DPAA2_EVENTDEV_DEBUG("epoll_wait fails\n"); - if (i++ > 10) - DPAA2_EVENTDEV_DEBUG("Dequeue burst Failed\n"); - goto RETRY; - } - } } static void dpaa2_eventdev_process_parallel(struct qbman_swp *swp, -- 2.14.2