From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 3B4961B868 for ; Tue, 15 May 2018 15:48:18 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id x12-v6so15956626wmc.0 for ; Tue, 15 May 2018 06:48:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KpyHTQj6l0gQflXtsEJgfg98bwpBBZHWkqjbxPMCT7Y=; b=YJ9+2hj3FIOzXmxA+ZsOZQAtYSiiefgEU6nfc+igZm31uHtkSnDGeWV+E4B4pkrd1U GQ3S9Y42uUQmQZjAv612Ll8BRFHw7qUqkDEqltSFWubJjmDOqDHUoYP1vpsqGby0/c/+ /aJL5+OIyMBdtjOY2a9Y83/DM4XGD2lYEQJThjAC+H8DP7p1aHgbKHRGzPu5t7AxKt4e v7+mpycHV82sGPy7xZJSR6qC6nn6Y/7557HxFx9IL/cmpTebYy6tyIO19QolekAegfzJ iVeRoYA7sNbyWvzc71pp6Ar6qxdswrE+2wQybePOFjEdVhtwkNQYiJhnisCM4kI3wfSS gLjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KpyHTQj6l0gQflXtsEJgfg98bwpBBZHWkqjbxPMCT7Y=; b=lm1yxlaH4C97oG086xpkOQ19OAiZpF5wPLJuJ34XbnwQ2e0uYYDi0P44JTk3fcPPG6 OHIDFVPk2HGAT6vYwZls6DcrDQ2ZXXwQQ6my8WZXpqkfvcnK4FkT8hxlia+JLml79i7c LFLDGgHOMlf1o5UrDP24Z5D+0lXMXrkRMRzsY1vRW5Db6M3C58vroPbeQjQKWz+yLOV6 xoRpfBTC5E9pRiquSmeQjCW2XRDr8SeSFtCHCWpWRRSv6hhr/16udNxVDQHszbH7GDZC anEEhgx1gCe4iceTo6MAVdgzfavqLI88YCQV3sXO+FthShnkGMDQWLROCLBH1DD0ZfDd tVOw== X-Gm-Message-State: ALKqPwd+WH9UiBzDtUoOoP3p4wz06l/Te7y+har4fctgl2DDwctOgJiZ uWM2hBNFxasfE8XtqzImYzg= X-Google-Smtp-Source: AB8JxZq/YMXhjUjqnH4EIw/tN+6mwRMOm1Im5MaKl1RX4WO5nUWh7fKPr1VA8XUJsAG3CbGXf3o1zA== X-Received: by 2002:a1c:b646:: with SMTP id g67-v6mr8554723wmf.88.1526392097917; Tue, 15 May 2018 06:48:17 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id w31-v6sm100509wrb.93.2018.05.15.06.48.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 06:48:17 -0700 (PDT) From: luca.boccassi@gmail.com To: Reshma Pattan Cc: Pablo de Lara , Thomas Monjalon , dpdk stable Date: Tue, 15 May 2018 14:46:32 +0100 Message-Id: <20180515134731.9337-21-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180515134731.9337-1-luca.boccassi@gmail.com> References: <20180503110612.12146-2-luca.boccassi@gmail.com> <20180515134731.9337-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'examples/quota_watermark: fix return type of threads' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 13:48:18 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/16/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 174ce88b5f55af0f16ba156c46f106188d8ee3a6 Mon Sep 17 00:00:00 2001 From: Reshma Pattan Date: Wed, 9 May 2018 12:35:28 +0100 Subject: [PATCH] examples/quota_watermark: fix return type of threads [ upstream commit 491cf0eaa177d6aa14f2a1e124e57d8aee134c2b ] Gcc 8.0.1 reports incompatible cast between types i.e. from `void (*)(void *)` to `(int (*)(void *)`. Change the pipeline_stage prototype to retun int type to fix the issue. Fixes: a0ffcb257a ("examples/quota_watermark: correct code indentation") Signed-off-by: Reshma Pattan Acked-by: Pablo de Lara Signed-off-by: Thomas Monjalon --- examples/quota_watermark/qw/main.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/examples/quota_watermark/qw/main.c b/examples/quota_watermark/qw/main.c index 313216f39..c55d38744 100644 --- a/examples/quota_watermark/qw/main.c +++ b/examples/quota_watermark/qw/main.c @@ -181,7 +181,7 @@ receive_stage(__attribute__((unused)) void *args) } } -static void +static int pipeline_stage(__attribute__((unused)) void *args) { int i, ret; @@ -243,9 +243,11 @@ pipeline_stage(__attribute__((unused)) void *args) } } } + + return 0; } -static void +static int send_stage(__attribute__((unused)) void *args) { uint16_t nb_dq_pkts; @@ -287,6 +289,8 @@ send_stage(__attribute__((unused)) void *args) /* TODO: Check if nb_dq_pkts == nb_tx_pkts? */ } } + + return 0; } int @@ -346,15 +350,13 @@ main(int argc, char **argv) if (is_bit_set(port_id, portmask)) init_ring(lcore_id, port_id); - /* typecast is a workaround for GCC 4.3 bug */ - rte_eal_remote_launch((int (*)(void *))pipeline_stage, + rte_eal_remote_launch(pipeline_stage, NULL, lcore_id); } } /* Start send_stage() on the last slave core */ - /* typecast is a workaround for GCC 4.3 bug */ - rte_eal_remote_launch((int (*)(void *))send_stage, NULL, last_lcore_id); + rte_eal_remote_launch(send_stage, NULL, last_lcore_id); /* Start receive_stage() on the master core */ receive_stage(NULL); -- 2.14.2