From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id BDE751B7A9 for ; Tue, 15 May 2018 15:47:45 +0200 (CEST) Received: by mail-wr0-f196.google.com with SMTP id h5-v6so222238wrm.4 for ; Tue, 15 May 2018 06:47:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6OwnVyAWwvGtM+5og1in5KB6OFP/wQ9vE1VDza0WuAE=; b=ZMbvrktOfpksO+n0vjD79Gj0DNXiqA/FI3t3DQfoPfhXSEhMCbnhrdwlxycS+fR1pu njpaVPH2T9LNzmS1nBBBS/wX5zbJbW2S5/etj/E0dfmXf9onyoysQ/BUeDLpxEW0YLoI VNpXYoCoEXjbO7D61zqTAFvi6lXybdykqMWNbx064inoOgbmGye9qit0DSfdbxgMn2NR EqmNyVT5EdGZdQAYFH6P+4pF6WcUbHGGcvtOv2YAS+6pxcWtYn0Qv1qSIyWC6YAOMqQk 1zY+mTAYvO2LeQiKxnJmiEo/RDacEnlYahkWJFS1+a4nar7qp8cooV/0Q6/1xKbFHort u8aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6OwnVyAWwvGtM+5og1in5KB6OFP/wQ9vE1VDza0WuAE=; b=hMKWtaSsuUn4D/kNrmCggobUc6oN9I7Lg9NzlZ73N9t8/G+ZBdkc+S3j1BIoWsJy/P mwRdjtrrhGekGlgpiZsN0e0FpfO+SjYK+zljEGjjk975dIM3SYrvnDsUTveVZSHWkLeG ncPrJC8R/FR/8V+ESnmPNx7Lk9cyY7/CEjS+o2yQ5+dRhos0ri+xZC1AoCA4HzIdhgAU 8xUTvMM80aRmxwPPsf94sHio0nlCpjaRdgXLvYHlM5cWB59XpiJXkfyQEtHh/2FUl2De ikljAMg41B5JXNyqvDVFZWysrakBBgPGe/LRP+Wq4WFQ/C7ERpvZ+JXjQiak5LRhqzls qnxQ== X-Gm-Message-State: ALKqPwdKwG+oMk7rmvh9Iojfmd4/+eJ2RIlf1WZfmqceeyu/VPEW0XV+ UyJ6u1adsB28ArqUn5/d9+jVG171 X-Google-Smtp-Source: AB8JxZqmtkCo9PJGRhYOxSTSrl6GDv3NTpk7gtahJVNdG6UCcm1tVIVsDDm/74+HEg3WoU9OERLE8A== X-Received: by 2002:adf:8121:: with SMTP id 30-v6mr11058822wrm.109.1526392065442; Tue, 15 May 2018 06:47:45 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id 187-v6sm662027wmu.41.2018.05.15.06.47.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 06:47:44 -0700 (PDT) From: luca.boccassi@gmail.com To: Ashish Jain Cc: Hemant Agrawal , dpdk stable Date: Tue, 15 May 2018 14:46:14 +0100 Message-Id: <20180515134731.9337-3-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180515134731.9337-1-luca.boccassi@gmail.com> References: <20180503110612.12146-2-luca.boccassi@gmail.com> <20180515134731.9337-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'event/dpaa2: remove link from info structure' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 13:47:45 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/16/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From be6aa9f7e6450f36e131a0c52a2b6633a14e20b8 Mon Sep 17 00:00:00 2001 From: Ashish Jain Date: Wed, 9 May 2018 14:50:53 +0530 Subject: [PATCH] event/dpaa2: remove link from info structure [ upstream commit 64f5de4194f89390c01ca137185f395ae2a95681 ] Removing use of link data under evq_info_t structure which was used to check whether the the associated evq has been linked or not. Since, an evq can be linked to multiple event ports, thus setting the link variable only allowed the first event port to be associated with the evq. This led to huge performance drop in case of multiple event ports as I/O only worked on first event port associated with the evq. Fixes: 0ce3ce7c275c ("event/dpaa2: add configuration functions") Signed-off-by: Ashish Jain Acked-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 5 ----- drivers/event/dpaa2/dpaa2_eventdev.h | 1 - 2 files changed, 6 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index 977e8df85..9d5acb374 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/drivers/event/dpaa2/dpaa2_eventdev.c @@ -459,7 +459,6 @@ dpaa2_eventdev_port_unlink(struct rte_eventdev *dev, void *port, dpio_remove_static_dequeue_channel(dpaa2_portal->dpio_dev->dpio, 0, dpaa2_portal->dpio_dev->token, evq_info->dpcon->dpcon_id); - evq_info->link = 0; } return (int)nb_unlinks; @@ -480,8 +479,6 @@ dpaa2_eventdev_port_link(struct rte_eventdev *dev, void *port, for (i = 0; i < nb_links; i++) { evq_info = &priv->evq_info[queues[i]]; - if (evq_info->link) - continue; ret = dpio_add_static_dequeue_channel( dpaa2_portal->dpio_dev->dpio, @@ -496,7 +493,6 @@ dpaa2_eventdev_port_link(struct rte_eventdev *dev, void *port, qbman_swp_push_set(dpaa2_portal->dpio_dev->sw_portal, channel_index, 1); evq_info->dpcon->channel_index = channel_index; - evq_info->link = 1; } RTE_SET_USED(priorities); @@ -510,7 +506,6 @@ err: dpio_remove_static_dequeue_channel(dpaa2_portal->dpio_dev->dpio, 0, dpaa2_portal->dpio_dev->token, evq_info->dpcon->dpcon_id); - evq_info->link = 0; } return ret; } diff --git a/drivers/event/dpaa2/dpaa2_eventdev.h b/drivers/event/dpaa2/dpaa2_eventdev.h index 91c8f2a35..229f66afb 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.h +++ b/drivers/event/dpaa2/dpaa2_eventdev.h @@ -63,7 +63,6 @@ struct evq_info_t { struct dpaa2_dpci_dev *dpci; /* Configuration provided by the user */ uint32_t event_queue_cfg; - uint8_t link; }; struct dpaa2_eventdev { -- 2.14.2