From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id C05901B7D6 for ; Tue, 15 May 2018 15:48:39 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id f8-v6so1243026wmc.4 for ; Tue, 15 May 2018 06:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PBOtQwZH0zmVdwIlKPvJZTVYzmx/etZx3+J9RmcpuOc=; b=uK6XRPlFJqnLG64uBuV8mQxQmdDl9SP8wWtgaevdAdYkHz5HS46CKYiRu9VlT27lud pffGLQ3xjnejfSopJl+LMd/noaMgS+CwAcOQvXSAXxd6r01DnXFeOPo7jGYNIYSSH6el 0bCHt9S6kOp6sh447QnWjVcSEIuiHe6xwAnsrZHONT6kc6bw3GsukGUJ0x+5EaEFeBOJ f2dpjuhQmLLOWcuYhpeiz77DKu2Bqxv/P08YzQv3y0OPEA8lOW+VM7iPCEZ/qPB+3kz2 eI64S0xpjpYp4e9OH+4OFKGfH1f4ByetOjS5fY9FJzvHs2u/8ln/Ma9FBOeDtWdUbmzE zFug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PBOtQwZH0zmVdwIlKPvJZTVYzmx/etZx3+J9RmcpuOc=; b=BjrGcEyMxVE95n34t2J26l52tluxzlV8mGExVrD7BDEVyO6rXi+2mEthElaeV9HYyV 3RH6DKDntu2FDAMW8TUKKACiL4LPfL79PGn1R0uyZ/NouylJDchIGvdbZAjs8xkom2pI 6cOjFBje6fCQHHnA+zzlqJxqvbFRK0b6R85jn7PhxKLsAujqk4bouQphKeXnuP9X47XZ lwtnnELMdhoCTPQETQpMnwJwzMB/HHcMgkHfdtNYIYQoIvTaUz0jy0hJpozcXMLSsX9S mtURhT3NH74uiR7eyf5U5d1HMDKhygxrs21mEsY3QXJTCFHH/ZhhFV6rH7XM+ggCtpDB Ufpw== X-Gm-Message-State: ALKqPwdZOawVqdIXleLga9JOw+VYhgT+Zwzp2b3Oeh96S+aNpVBQ2zYX rToArw+CDjaMXkE8A7hD69LGOitQe2s= X-Google-Smtp-Source: AB8JxZoevlEQp7ZK2d5ANWXtCM6AWTUxz+Se5+UVv4unz7L4jjdruOWG0gR4SSWTOeSxUbNXTm9Icw== X-Received: by 2002:a1c:55c9:: with SMTP id j192-v6mr9098944wmb.160.1526392119500; Tue, 15 May 2018 06:48:39 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id v18-v6sm111254wrf.76.2018.05.15.06.48.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 06:48:38 -0700 (PDT) From: luca.boccassi@gmail.com To: Matan Azrad Cc: dpdk stable Date: Tue, 15 May 2018 14:46:45 +0100 Message-Id: <20180515134731.9337-34-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180515134731.9337-1-luca.boccassi@gmail.com> References: <20180503110612.12146-2-luca.boccassi@gmail.com> <20180515134731.9337-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'app/testpmd: fix forward ports Rx flush' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 13:48:39 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/16/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From fc365154064da2603806c31cffc9f1320606e821 Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Thu, 3 May 2018 10:31:45 +0000 Subject: [PATCH] app/testpmd: fix forward ports Rx flush [ upstream commit 47a767b2ee253ccdd084af88d3e390ed9e74f20b ] A port Rx queue flush is done when the packet forwarding starts in order to clean the port statistics for a new traffic session. The flush operation is wrongly called before the update of the new forward ports, and may fail due to flush operation for an invalid port configured by the old session. Move the new forward port setup to be done before the Rx queue flush. Fixes: 7741e4cf16c0 ("app/testpmd: VMDq and DCB updates") Signed-off-by: Matan Azrad --- app/test-pmd/testpmd.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 2f54d22c4..8487c99fe 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1238,10 +1238,6 @@ start_packet_forwarding(int with_tx_first) return; } - if (init_fwd_streams() < 0) { - printf("Fail from init_fwd_streams()\n"); - return; - } if(dcb_test) { for (i = 0; i < nb_fwd_ports; i++) { @@ -1261,10 +1257,11 @@ start_packet_forwarding(int with_tx_first) } test_done = 0; + fwd_config_setup(); + if(!no_flush_rx) flush_fwd_rx_queues(); - fwd_config_setup(); pkt_fwd_config_display(&cur_fwd_config); rxtx_config_display(); -- 2.14.2