From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id D758D1B7A9 for ; Tue, 15 May 2018 15:48:42 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id p18-v6so240097wrm.1 for ; Tue, 15 May 2018 06:48:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=bjqXNu7Ljedl9YuH8rV00yQxS98XcGumguClhYKN/ic=; b=bNZzGPSvNIbvcPBSWRFt2MovUdPwVgIifpGrthAOnNu13Abc8VF7b0+pSYSjhzjB+i KFMunMYjWifnrFwloats5N7dpgc3grIuN6S0yHlWO2WIbI58nD62vkFoLgSb8v6fh5dO f/I4i0AI1uRFFh9yDNIOK0Oua1M6IRWlqk5MpMpFfVmT6+Nxd9qF/frjteOOAZU88scm 4gQgF/S6k7PG/63fvKedbfXr25KIGX2/wq7Q2rbBQ9XCianJ5HDQHkkMHr9W2L2db8E5 YHGo6p1uIoipmal2tZrAEdFtM4/mrrF8/FrU5CTu6jKz7+nHwT8uT42xu5++waUsOz/T 2muQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bjqXNu7Ljedl9YuH8rV00yQxS98XcGumguClhYKN/ic=; b=CZ7EC++hOYIPMdl7YaHF2Fb7/X4C0x2g7AV80pW1N5ivejoYtmkASZTY98MhZ23xb9 8Esg8a7xwwXnHTdFYXU5HRZ1oDmnhHZQ6y+oKxD0XhrldAHk09WEpz+Pn9dS0PSoqywo BKhwlmhxr054oOwRORqpHzP5x8drJX8beMR4tGlYa6I6O+STI2uber9+7VovBsx7+PQ0 60IRD9eA/JQy+mr87pXESya5LiM1pwTpDCevoCFUatH0peDCRYejPhkgYmkvI1N3ZUwp 82GsbLtaiBuiQb+78B2aBAEBxeB8JRhNnPU3GdLAs9eZoO/M3MGkFJufM6ZM1d7blML5 iGFA== X-Gm-Message-State: ALKqPwc3TpK38ZUJ96qBitsWt++v6JPAFWeWwmfA6aGQB3zANRnma7HI wiTVggCg+FPLuJYmBy5+9tRRjFqNPo0= X-Google-Smtp-Source: AB8JxZo0lHHez+CDgnFBGOa9sTOlouOj9aaS10XI2QQZoWtc2kvRy3ckPf/8UIxNYMg2AS1Kev9IBw== X-Received: by 2002:adf:c753:: with SMTP id b19-v6mr11171769wrh.65.1526392122622; Tue, 15 May 2018 06:48:42 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id w31-v6sm102084wrb.93.2018.05.15.06.48.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 06:48:41 -0700 (PDT) From: luca.boccassi@gmail.com To: Matan Azrad Cc: dpdk stable Date: Tue, 15 May 2018 14:46:47 +0100 Message-Id: <20180515134731.9337-36-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180515134731.9337-1-luca.boccassi@gmail.com> References: <20180503110612.12146-2-luca.boccassi@gmail.com> <20180515134731.9337-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'app/testpmd: fix removed device link status asking' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 13:48:43 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/16/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From bbf546801e3b6fe15124ae448e8c1bd002b144f2 Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Thu, 3 May 2018 10:31:47 +0000 Subject: [PATCH] app/testpmd: fix removed device link status asking [ upstream commit 0da2a62bf9d72625fb5b779d9fd91e471ed2fb4a ] In the RMV device event callback, there is a call for the removed device stop operation which triggers a link status operation for the removed device. It may casue an error from the removed device PMD. Skip the link status operation in the above described case. Fixes: 284c908cc588 ("app/testpmd: request device removal interrupt") Signed-off-by: Matan Azrad --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index fed7d509f..3c92e899b 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2027,13 +2027,16 @@ check_all_ports_link_status(uint32_t port_mask) static void rmv_event_callback(void *arg) { + int org_no_link_check = no_link_check; struct rte_eth_dev *dev; portid_t port_id = (intptr_t)arg; RTE_ETH_VALID_PORTID_OR_RET(port_id); dev = &rte_eth_devices[port_id]; + no_link_check = 1; stop_port(port_id); + no_link_check = org_no_link_check; close_port(port_id); printf("removing device %s\n", dev->device->name); if (rte_eal_dev_detach(dev->device)) -- 2.14.2