From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 850D31B888 for ; Tue, 15 May 2018 15:49:15 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id p18-v6so242046wrm.1 for ; Tue, 15 May 2018 06:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=M2D2EcEvhfq1EfnQgCLOzXX/IFeR3PZ998J5ErBG35s=; b=LyB3Wfs5FqSvniPGEPt8HJYYuiAl9uYvjOJBFGi8e+bmzt2sqPWsJg1LVSOg/XiZm3 ydPpU0+HoskbgHoQcP4/+yZO6nQr4hJyRAfcNQ6V9TkDL5kGjuoxi1/DECUgcL0ZU4Ek unouksSEb2zXAliFMfWLmcI27QKl5PJ6R0wmqaqOgYj4B0J3bfRW3puCxICZczCcBfjU 60NJzPJ0BX53vStHc/9HeepfxHmWA92avq5cXLMLxJEZWYDoFn9D/oFB6jYP6F0CM5Pr 3YI9Qqe86L5jSmJajxroRtAaVqOGE+HOlKiYeOrr033Gzyj6sSqSDiFtMMLE7JAoJzIu YoDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=M2D2EcEvhfq1EfnQgCLOzXX/IFeR3PZ998J5ErBG35s=; b=L6++txYANpgeeQW8/gJZKm27G6ZTWSg9uk4sj7NgrqiTehnM6lnt2cZZlTxnc+VKKx cL8DbDF+13riPT7GLaWFZCmezlsui3iUSJMG6fePclhmvDBjLMAuJV1HfihXw5lgJv87 2a936zuwSoTFHq0kI2o2qjJcsRtJOkR2KFWOpGshW65VtOYrk0BheU5uVEFLBLIKcc2O vtaw+h6N/Gbrk2OT/wB6+8nYhRUEjc58k3I0oeegNY6zwxCnvJjMYodHhbUXXOEK/XY3 /tsFD9rDQXVJr8LkDdlctWW+nA0ONuzXlFA9EOutHrf0D2Ym90kJpqMh8oAhVmy7SrXs s56g== X-Gm-Message-State: ALKqPweGRMFma3NX9GzlJCLRKwkF26TEAPaZ4teZtSweLgcMNe922XAB ncEnXC12u41dL9QEC8mbe2g= X-Google-Smtp-Source: AB8JxZqa/a/f8YH+LNsjTyFxCH2dBWibXB1nPVQ0KdgV9MJhwGlKtoVAwcmcFtMrvd5FwXQQnQ/uVA== X-Received: by 2002:adf:a0b8:: with SMTP id m53-v6mr10771931wrm.269.1526392155246; Tue, 15 May 2018 06:49:15 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id e50-v6sm188261wre.4.2018.05.15.06.49.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 06:49:14 -0700 (PDT) From: luca.boccassi@gmail.com To: Adrien Mazarguil Cc: Ferruh Yigit , dpdk stable Date: Tue, 15 May 2018 14:47:07 +0100 Message-Id: <20180515134731.9337-56-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180515134731.9337-1-luca.boccassi@gmail.com> References: <20180503110612.12146-2-luca.boccassi@gmail.com> <20180515134731.9337-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'app/testpmd: fix empty list of RSS queues for flow' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 13:49:15 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/16/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From ad4bf119674101b58f4c5060d08b9a666687ac5a Mon Sep 17 00:00:00 2001 From: Adrien Mazarguil Date: Thu, 3 May 2018 13:59:42 +0200 Subject: [PATCH] app/testpmd: fix empty list of RSS queues for flow [ upstream commit 9278a4333ad021754c0822a7db18d574c5103209 ] Since the commit referenced below, specifying a RSS action without any queues (e.g. "actions rss queues end / end") does not override the default set automatically generated by testpmd. In short, one cannot instantiate a RSS action with 0 target queues anymore in order to determine how PMDs react (hint: this is currently undocumented so they may reject it, however ideally they should interpret it as a default setting like for other fields where empty values stand for "defaults".) Fixes: d0ad8648b1c5 ("app/testpmd: fix RSS flow action configuration") Signed-off-by: Adrien Mazarguil Reviewed-by: Ferruh Yigit --- app/test-pmd/cmdline_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index ac4b51a8a..105e245bf 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -2204,7 +2204,7 @@ parse_vc_action_rss_queue(struct context *ctx, const struct token *token, i = ctx->objdata >> 16; if (!strcmp_partial("end", str, len)) { ctx->objdata &= 0xffff; - return len; + goto end; } if (i >= ACTION_RSS_QUEUE_NUM) return -1; @@ -2225,6 +2225,7 @@ parse_vc_action_rss_queue(struct context *ctx, const struct token *token, if (ctx->next_num == RTE_DIM(ctx->next)) return -1; ctx->next[ctx->next_num++] = next; +end: if (!ctx->object) return len; action_rss_data = ctx->object; -- 2.14.2