From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id A04791B7A9 for ; Tue, 15 May 2018 15:49:40 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id f6-v6so1161542wmc.4 for ; Tue, 15 May 2018 06:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9r6/Oq/RBYLOE6JpCr9Uc0OHs3UVOGF/2ncxghRdhO0=; b=eaBfHGFRaf9KYWhmwchjE2BC619+R5BWcGgFkPXyFNtTInxSqpaoL4CN8+kkyx+wQR 7Q+f2dxJwfLQmn+aXxHu1ILTRbeWvhNTDYl8r0lYgOJA3ioIZUnHmxE/LGoS8f192H0c F+pKmhGgOLmBoSgv/HleIIkxRSpH8oJWOVsWHloXzJcR/miFUuNwHgPGGzPioYdtPHh8 H3vPUH1XS+xeJck8z9i7Q/LmhSxiAJ+v9iVSn/jJZwc72anczZaIdlixF5vehiDIpf4U CoyVt5VSxZjchbOcebGOkKLnN2wZvp+OCUz34i7IMEIc5Owl34G3hQyqxmeZFzqKR7cr SVJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9r6/Oq/RBYLOE6JpCr9Uc0OHs3UVOGF/2ncxghRdhO0=; b=M6cL7oeb5HTCU3QEA+t6E3nzFEWjWIH1E7vLiD8IeVMVf7c5bKeJcEaFsT3M55UYen mDbPFmhbcAr+lP5mJnhAVe0Q0K8ykLsvh+UA8tipUw9D07miKVSjXuO8Cl37VMgBhY5B QNouWeuKienu6IamdcoUjr85hJpu0PgRrt/bw7m0lMse7T4WXh0SNY7yrG5Hn0pKDG2+ f+VV9P0r7ZTN76at16SpKnIuW8cSezh13TbkS84/mNwnLGhhIyFlLvnmkAdAr49XruoH CW1MlN/wsmsFUA8pb0v353RR2nHuy7E63Bv2gWaRqP4F9cdw//2WizWmBfVsh89aWKRw RTgQ== X-Gm-Message-State: ALKqPwfUOiHg/gon7GRUbBcLaAxUOTmpPt+ZlJZzEYJNwrGPYU7UosCc 5enu/WHYOZa+AOs7s5AHvz8= X-Google-Smtp-Source: AB8JxZpTVyDB47korgnOEIddS0gsJHQsCKtVUqnU2LUN8dvCn3UfhY85v6eZqim29HORti0qLC1GAg== X-Received: by 2002:a1c:b9d0:: with SMTP id j199-v6mr8349872wmf.131.1526392180324; Tue, 15 May 2018 06:49:40 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id d12-v6sm164678wrg.2.2018.05.15.06.49.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 06:49:39 -0700 (PDT) From: luca.boccassi@gmail.com To: Ferruh Yigit Cc: Shahaf Shuler , Bernard Iremonger , dpdk stable Date: Tue, 15 May 2018 14:47:22 +0100 Message-Id: <20180515134731.9337-71-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180515134731.9337-1-luca.boccassi@gmail.com> References: <20180503110612.12146-2-luca.boccassi@gmail.com> <20180515134731.9337-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'app/testpmd: check if CRC strip offload supported' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 13:49:40 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/16/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 7d78080e186feed1093ac8725738930065ca1eb3 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Wed, 9 May 2018 23:09:04 +0100 Subject: [PATCH] app/testpmd: check if CRC strip offload supported [ upstream commit 7c45f6c0794858999696f1f54b59d2a0e436e68b ] Testpmd set CRC_STRIP offload blindly, this is wrong according offload API definition, and will cause error for the PMDs that doesn't support CRC_STRIP like virtual PMDs. Check if underlying device report this capability and don't set it if not supported. Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API") Signed-off-by: Ferruh Yigit Acked-by: Shahaf Shuler Acked-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 9ab44813d..85d5cde09 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -690,6 +690,11 @@ init_config(void) port->dev_conf.txmode = tx_mode; port->dev_conf.rxmode = rx_mode; rte_eth_dev_info_get(pid, &port->dev_info); + + if (!(port->dev_info.rx_offload_capa & + DEV_RX_OFFLOAD_CRC_STRIP)) + port->dev_conf.rxmode.offloads &= + ~DEV_RX_OFFLOAD_CRC_STRIP; if (!(port->dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)) port->dev_conf.txmode.offloads &= -- 2.14.2