From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by dpdk.org (Postfix) with ESMTP id 2AE861B6D8 for ; Tue, 15 May 2018 19:19:43 +0200 (CEST) Received: by mail-lf0-f68.google.com with SMTP id p85-v6so1384300lfg.7 for ; Tue, 15 May 2018 10:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Z8SfI7WwtUoNMoFOz4iWf3VsXPzdHig5uSL0NtC+ia0=; b=G3eGOy9pWnhLk2DxGhQx2i6VB0C3gklSTukVvRo9kmlmuG88j/la/KqYAlU1KfDzjW InI7SlExheRPE3amOTif/2A4XURN+8P0wcOrScr173hJMJLZoQeOQrFzEQ9zjvjW2nNy wpVtidMavrjX+iJfkl0cuqXyeo9altEoi2YZ+YHNTBBK5rf1EMsUpNAOHFZCAp/+MU8T 2R3OSWoi/wJ+Ri3/cL+SBejdt9fbueiAZQhNv5CS4UOtGkqKCdxuiJPb5Oc1CmM/nNfX 9Uz51UCysS4DhwNKFw6AGlOe671P1zdd5EycdUS8wsBaCiyM+qrzh5+js45EWXGbIN4f 3+1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Z8SfI7WwtUoNMoFOz4iWf3VsXPzdHig5uSL0NtC+ia0=; b=NVCjikSOk6jx+IaDLOxCM8xNCYBz3CB+eTPTRiKkY6XcTg8J6RDEWVLathTGfbcPVf F6OwHqiG5akEvMciaKXQaSDo1/JA5WmpmmPwULJb/zVs8S95WwTmx7r0kk/b80ZsZNwQ 57xeq5B9pbuX7gwiGW0oAWxzBh+8N5d4BEURi2wKWmBqf0TcsGD1c1j5OEDVzF0SV92i lXjghQEoGsgxvecxAQ19/YFgpJML0LpCRziE/FpODLB5RYcJfnj6BNsk6IqAWsR+ttGl rX4UaQFq5HZdbtUtbCbETEhXhiEatx/kfvxzWtzL2qpw3e/bAXKEM7VPnP14ww/hGqUm X3Xg== X-Gm-Message-State: ALKqPwfD37S3wif+QbM4VQxDuuMdKuBwIVYNi2R2BaR2USkhdQdNCPn4 ZFViYrRCUi2fsbYb8rknQZR2xfvn6hU= X-Google-Smtp-Source: AB8JxZqcEo0PWGUMSLeR2mzlAGU5GnSecpLln5qlzIlx2ujteNxoMI9EOJN5UBRpjFWFg2VxvvDLww== X-Received: by 2002:a2e:81d0:: with SMTP id s16-v6mr8196853ljg.115.1526404782684; Tue, 15 May 2018 10:19:42 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id z1-v6sm81894ljz.1.2018.05.15.10.19.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 10:19:41 -0700 (PDT) From: luca.boccassi@gmail.com To: Andy Green Cc: Stephen Hemminger , dpdk stable Date: Tue, 15 May 2018 18:19:02 +0100 Message-Id: <20180515171933.12882-1-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180501104509.17238-46-luca.boccassi@gmail.com> References: <20180501104509.17238-46-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'eal: explicit cast of builtin for bsf32' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 17:19:43 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/16/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 9153951dac72bafbc84e2b8f966748aa761b9a32 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Sat, 12 May 2018 09:58:57 +0800 Subject: [PATCH] eal: explicit cast of builtin for bsf32 [ upstream commit 54a93341ccaaf3665352ddad0807cf3ed40c36f9 ] rte_common.h:416:9: warning: conversion to 'uint32_t' {aka 'unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion] return __builtin_ctz(v); ^~~~~~~~~~~~~~~~ The builtin is defined to return int, but we want to return it as uint32_t. Its only defined valid return values are positive integers or zero, which is OK for uint32_t. So just add an explicit cast. Fixes: 03f6bced5bba ("eal: use intrinsic function") Signed-off-by: Andy Green Reviewed-by: Stephen Hemminger --- lib/librte_eal/common/include/rte_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h index db5ac91c6..64bc7b8d4 100644 --- a/lib/librte_eal/common/include/rte_common.h +++ b/lib/librte_eal/common/include/rte_common.h @@ -323,7 +323,7 @@ rte_pause(void) {} static inline uint32_t rte_bsf32(uint32_t v) { - return __builtin_ctz(v); + return (uint32_t)__builtin_ctz(v); } #ifndef offsetof -- 2.14.2