From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f67.google.com (mail-lf0-f67.google.com [209.85.215.67]) by dpdk.org (Postfix) with ESMTP id 7F31D1B6C1 for ; Tue, 15 May 2018 19:20:12 +0200 (CEST) Received: by mail-lf0-f67.google.com with SMTP id b18-v6so1371110lfa.9 for ; Tue, 15 May 2018 10:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=S9O8Iwx+kRePWE7YVUU63ibs+RiOPEAQrCUAWkAAjqI=; b=gKi2WsRolyNlStzwHUh9m7G+YYvkre2aFstjTqQa9M3xmcas1P4STxrftX8POdKOl+ xJ0+S+8I/ifCezS4cNlFeqSfQwCq3yXrLaqNAbDznnvBsmrD38dYADe+299opO6d7NjU B9+VU7POAzvVyanXO4fiaOOUcDdMfm4zGnapwf1aO2+9h8XNPWf75/5M5jdWya0hI6pS l/XMgdLFM5PijbWXnoKng3CQ+qKc2AnuHqTR14VNCdUDQ/ur16P0S8bUNUepibYQiGqX BoGZkRLofbINJiqXW+K6+Ci0Q9QtHyg3AcssEwGVZUBcK1TJV6Eo1gD2GZRCpnL2gt/s SB0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=S9O8Iwx+kRePWE7YVUU63ibs+RiOPEAQrCUAWkAAjqI=; b=FeMW+SH9vocfQzGG6x04BkmRKQHUJaW/aDmY2fYxTaZAN0NmRi1Mg+InAkQGNtJYiM Y01b6HZxJzP5Qr05qTMJxHlmO4fj4mtOUODIfC4TX3Vo1Ar3vn3XokiDieodyuD6rfF9 KEinhL/AfPeEoX0IPtitPeHS+V3zlVNJhLWe9KEzQZUOKrxEhhGHs9H0gcEA+DKXcJBs iJ5OJImg2KQR4kqg7cavZ5VFf5PuqOynPbDMV5RgXcss3bYLc/H7B/Td16WablH0xEZu 4wy77b/EHkmFfXL6JcWukOvY911D7FcUzdkBlbn7ivh4YcmOKPw8oREkrEJfWgBwFsnQ sqWg== X-Gm-Message-State: ALKqPwe8NCo6HpKy/32D5eM75Hskj7F95+aOd3JLH7/mZpWfeMIwOQeh hh9LLK0W8b9jNJHBOJqN0B1NJ4FGnSg= X-Google-Smtp-Source: AB8JxZpVjIBhVcUkT6dbmF1TnviSLlQkGwZnHBXZAS4LXRtYJwvAv7g3Cq+Z93Nj7/Dc7PwhwsEf6w== X-Received: by 2002:a19:ead6:: with SMTP id y83-v6mr12037033lfi.117.1526404812119; Tue, 15 May 2018 10:20:12 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id q7-v6sm120156lfc.91.2018.05.15.10.20.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 10:20:11 -0700 (PDT) From: luca.boccassi@gmail.com To: Matan Azrad Cc: dpdk stable Date: Tue, 15 May 2018 18:19:18 +0100 Message-Id: <20180515171933.12882-17-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180515171933.12882-1-luca.boccassi@gmail.com> References: <20180501104509.17238-46-luca.boccassi@gmail.com> <20180515171933.12882-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'app/testpmd: fix forward ports Rx flush' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 17:20:12 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/16/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 4926f4e88fdd708106959486826e9a8d94fa573d Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Thu, 3 May 2018 10:31:45 +0000 Subject: [PATCH] app/testpmd: fix forward ports Rx flush [ upstream commit 47a767b2ee253ccdd084af88d3e390ed9e74f20b ] A port Rx queue flush is done when the packet forwarding starts in order to clean the port statistics for a new traffic session. The flush operation is wrongly called before the update of the new forward ports, and may fail due to flush operation for an invalid port configured by the old session. Move the new forward port setup to be done before the Rx queue flush. Fixes: 7741e4cf16c0 ("app/testpmd: VMDq and DCB updates") Signed-off-by: Matan Azrad --- app/test-pmd/testpmd.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 978606252..94d1c72b4 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1015,10 +1015,6 @@ start_packet_forwarding(int with_tx_first) return; } - if (init_fwd_streams() < 0) { - printf("Fail from init_fwd_streams()\n"); - return; - } if(dcb_test) { for (i = 0; i < nb_fwd_ports; i++) { @@ -1038,10 +1034,11 @@ start_packet_forwarding(int with_tx_first) } test_done = 0; + fwd_config_setup(); + if(!no_flush_rx) flush_fwd_rx_queues(); - fwd_config_setup(); pkt_fwd_config_display(&cur_fwd_config); rxtx_config_display(); -- 2.14.2