From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by dpdk.org (Postfix) with ESMTP id 6C28C1B752 for ; Tue, 15 May 2018 19:20:30 +0200 (CEST) Received: by mail-lf0-f68.google.com with SMTP id n18-v6so1367760lfh.10 for ; Tue, 15 May 2018 10:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+c6iyMZww6LupN4lrWiwvSC6XdPS+PaNWQGXugbnDMw=; b=K8Si8a5ixJJF+BBwngRqCE4F0rXo7ZhHWvHnBFrddarraoHg29RBQDyOn9V9rlpHLz ZEU/8qW1U3Axyd9I3Uezbn24TsuzVW9FznAmyQ4RVwI4OBArkHcd+yur5EPYS0KQVD9N 4qdnu4L2TmpLufHcfQXRgHRueyanJt93ZDGD559jzdB5jXMfujwvHgKT5SL5Pjhqnn/p 2HO+pI+7/E9i9G0ibJXzNhBt9OBjALeUkQ9yJ5o5lbH4Jg6yHIcnWOCyPFHFYuZ7cLAE DJp2LGJfwnYKDt/a7d9M7+SvsJGg4BXKnJrw9OcizPz4eHKdeIBSnNiEFjrLt7IS8EFs f99Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+c6iyMZww6LupN4lrWiwvSC6XdPS+PaNWQGXugbnDMw=; b=CBvwwQzQSp4fN+Oc6W9up31ZtUBc5r4jxRQabW/Pi12cAQnxoi+7Yygdy9LqEnCTGT eEbHnyY65XDzY1Zf2cSMoUywOsDDEl2U8ZQZz+ETjvQ+EoQSkvCCpe/beoxrWj3h7tGK pjdo/7cRvARMBZLKhw6BZplwUcuAebo3W/+Z3lcfprc4yw4shXDjp+Xk/ElkH0h/EapC X0u9PBYJldELuT/ZSfZ70K1DRpIFEpptdg8ipH3rCcQgdq1MPmDkNBocCe/Q+jp4vszt gLj4pGkiqkQ13SFKc/SRTK1Nv75nSvm0isoUR7KStTFQoHJseCsDp3qrpF0tmXC0BQyN Hh/Q== X-Gm-Message-State: ALKqPwenXbJ023OKOW0Dt5L+RReQnyffyY/6HclrQNvbcJ6trYIrwldA ZSQZI/R8sON6jbXcEEdb2N8Lubs/vX0= X-Google-Smtp-Source: AB8JxZpm8qzPvQoeuHW9ciObKHG4GZbJ7+53pF/bjvPiFr3P+clDCe3uxZ8JWsxHixm+B2EWDCmUug== X-Received: by 2002:a19:ded9:: with SMTP id i86-v6mr13140762lfl.42.1526404830028; Tue, 15 May 2018 10:20:30 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id h7-v6sm74099lja.93.2018.05.15.10.20.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 10:20:29 -0700 (PDT) From: luca.boccassi@gmail.com To: Raslan Darawsheh Cc: Yongseok Koh , dpdk stable Date: Tue, 15 May 2018 18:19:28 +0100 Message-Id: <20180515171933.12882-27-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180515171933.12882-1-luca.boccassi@gmail.com> References: <20180501104509.17238-46-luca.boccassi@gmail.com> <20180515171933.12882-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/mlx5: fix double free on error handling' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 17:20:30 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/16/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 66f7e36563ce484b6c52dd693e5543d01c48972b Mon Sep 17 00:00:00 2001 From: Raslan Darawsheh Date: Tue, 8 May 2018 12:11:26 +0300 Subject: [PATCH] net/mlx5: fix double free on error handling [ upstream commit e9f4166014cb7abf8c74b913ff046487d0e7bea2 ] When attr_ctx is NULL it will attempt to free the list of devices twice. Avoid double freeing the list by directly going to error handling. Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox ConnectX-4 adapters") Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 86d1e44c7..506786c4e 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -422,17 +422,16 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) break; } if (attr_ctx == NULL) { - ibv_free_device_list(list); switch (err) { case 0: ERROR("cannot access device, is mlx5_ib loaded?"); - return -ENODEV; + err = ENODEV; + break; case EINVAL: ERROR("cannot use device, are drivers up to date?"); - return -EINVAL; + break; } - assert(err > 0); - return -err; + goto error; } ibv_dev = list[i]; -- 2.14.2