From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com [209.85.215.46]) by dpdk.org (Postfix) with ESMTP id 1784D1B6C1 for ; Tue, 15 May 2018 19:19:47 +0200 (CEST) Received: by mail-lf0-f46.google.com with SMTP id n18-v6so1364412lfh.10 for ; Tue, 15 May 2018 10:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YxpCITbr2BNq/KnYBWwWKRaEco9mUDQC6dHZau+oO3A=; b=contzg/utyEY9XRaxtRnRl31wDRCA0gb+nez2qs+GFM5vIaN/gWTz1qQZnwK0i5IpL U1mMcsK5QAKz47fFstX93vBnF8F9OwKjTRjlskcyZTuoSSVq9x7DQSLy0USBbc1+WEh3 qQ2eEsF9CX4FacGrWzF6b+fwwodlwur+AHqZhcNKH0q9uT8dd7tgYRuqiEq/hknuoUmA tAKp/OWojTlXeCLnfu26zzh3Dk8Gu4j7UTCZKm3hkY8+pakJbcuIc0jp3uaczgyfLPre c9KH+BgpTQsvrWOcGUGO+knomT9a4ML4/kLzmP5bYy/ZZHsRP2JL3QgvacTQBJMOBaH/ ZBnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YxpCITbr2BNq/KnYBWwWKRaEco9mUDQC6dHZau+oO3A=; b=a3LOgHQff8b6Rqh2czK1yqPAE17y+4GK7cteUXO/4g25jpHfrSoDG1JNP8Wh7cfUsm CsOAcgF12DZijxUVxg2lKj8WSYhktK6tmtWNZT6zFhF1nInUlmE064SvtYM+fOAMB5dF BM0I65KWylfCYiPFOguoFE4f3msK5MasQuziELVh87SVpzVt4yrgeWIbuwU4Hmvo1Yl/ g20p74krud4JlzDzkW7aSx9Fm7Y1r+wd7i8anbXoUl1SseE1tiZtbCWCvwU4JhMqOs57 /cNAnulBVlLQ9WXoMFUmJS7taP2t5Dt3Smrs2shpaDSl5S37v0vKp69FkatoZpUbmqUr Ay7g== X-Gm-Message-State: ALKqPwc/GMKdhMqUjUx/0if4hCxwccjMvh3/hlCzY9ZWxU6OYSGMOaF9 VY8PE8D18OKFNT4mCEWT9HkeCnjqM4w= X-Google-Smtp-Source: AB8JxZpZx+jKzG1akwHs2LUZ2gI0qOKUKqNFF+EvEyJTsz/PEuLSl0NMYkM6iUFXDk8gtybtKA2tKw== X-Received: by 2002:a2e:9911:: with SMTP id v17-v6mr7434526lji.57.1526404786645; Tue, 15 May 2018 10:19:46 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id g132-v6sm130691lfg.23.2018.05.15.10.19.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 10:19:45 -0700 (PDT) From: luca.boccassi@gmail.com To: Andy Green Cc: Stephen Hemminger , dpdk stable Date: Tue, 15 May 2018 18:19:04 +0100 Message-Id: <20180515171933.12882-3-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180515171933.12882-1-luca.boccassi@gmail.com> References: <20180501104509.17238-46-luca.boccassi@gmail.com> <20180515171933.12882-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'eal: declare trace buffer at top of own block' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 17:19:47 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/16/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 0b6e33f4ddb3d1253a48231d02e7a4d5382fdbef Mon Sep 17 00:00:00 2001 From: Andy Green Date: Sat, 12 May 2018 09:59:32 +0800 Subject: [PATCH] eal: declare trace buffer at top of own block [ upstream commit e3908132b7903dbbf45c6d073792cccc890812e0 ] rte_dev.h:54:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] char buffer[vsnprintf(NULL, 0, fmt, ap) + 1]; Fixes: b974e4a40cb5 ("ethdev: make error checking macros public") Signed-off-by: Andy Green Reviewed-by: Stephen Hemminger --- lib/librte_eal/common/include/rte_dev.h | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h index dcf33d0e0..2ad6da86e 100644 --- a/lib/librte_eal/common/include/rte_dev.h +++ b/lib/librte_eal/common/include/rte_dev.h @@ -60,15 +60,18 @@ rte_pmd_debug_trace(const char *func_name, const char *fmt, ...) va_start(ap, fmt); - char buffer[vsnprintf(NULL, 0, fmt, ap) + 1]; + { + char buffer[vsnprintf(NULL, 0, fmt, ap) + 1]; - va_end(ap); + va_end(ap); - va_start(ap, fmt); - vsnprintf(buffer, sizeof(buffer), fmt, ap); - va_end(ap); + va_start(ap, fmt); + vsnprintf(buffer, sizeof(buffer), fmt, ap); + va_end(ap); - rte_log(RTE_LOG_ERR, RTE_LOGTYPE_PMD, "%s: %s", func_name, buffer); + rte_log(RTE_LOG_ERR, RTE_LOGTYPE_PMD, "%s: %s", + func_name, buffer); + } } /* -- 2.14.2