From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f182.google.com (mail-wr0-f182.google.com [209.85.128.182]) by dpdk.org (Postfix) with ESMTP id EA0811B172 for ; Wed, 16 May 2018 12:16:58 +0200 (CEST) Received: by mail-wr0-f182.google.com with SMTP id a12-v6so272490wrn.13 for ; Wed, 16 May 2018 03:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DAjacA2xDj3KiW/JynO69MK+28MjXOaOg333h2Vyauk=; b=d8+QKWWrN7eYK/UI7GgD1yIdJBJkeBm4+MgnpUEsF6XRxC6YzFKggl4pLv5tWrt4p9 cEd0NnSx8WWZatBcWRm0W5mavi2y3soC5F8/FeDtHPxPE57Rz/4eopEifJTFepsbvCZp E1nAHbF/Zb0VKBxw5gobxCpW5EBZZ4l/ulEzHnfOc6cGStFR6B4fw6bx3S0ZTJaG1aCW GVJ+cLfAkWuljxpqawUO5RV/AL1IFL63f/GTMQ9rB4de1lTIba6V2fTq3Em4DRofHoA6 g6rAr5FvpKv5cGjfIp26eo1OS69yt+waRozSuoKAKCgo/o0qefdMpgVMPp4qcZytIl7h tRbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DAjacA2xDj3KiW/JynO69MK+28MjXOaOg333h2Vyauk=; b=P0Ed+dmOG6kVWglVbHZMmkPu+LkvUIjnTaqejuWQg9Urna7gz+EIHa7o74KsH6L1BI RclJljDu7kmqUOgHG+bLxLT19cuFaHUky/wjvT88YR70KGLfz3J7WBW8taI+Ot2eNjzd grliGsCOc64aqkwCYR2NZzvkDMdcUc9Kf0JKiuJ0KDqBrr40oXvY/M/t+MR42NOcpQFx 8+ZqXjVDP2ju3PuhmVIYPfKwLnqN8m1fY4AHxO6jzsxTaAh164PuFqiPLHjav+s2KW0c uyDyF2DPrGB/M/vQW+vCVRaYZh5XMjg1CCVZf174XoRV6mFbxil2gBShs/oJR9ZsbVXS P/sg== X-Gm-Message-State: ALKqPwdgLXOZoO+ZzUSMOiY4d41j2UxepliPDslZ9zL+U2PjHJX7YCt9 IxgkE5GB4L9HEBVFqDVNBJg= X-Google-Smtp-Source: AB8JxZoupXU8qTlHvN6cEuV0pgR13HIVGOpEC5jzz1fv1yB5AQ/XZqMDW9QDpaCaqZgq83RSAXFSrw== X-Received: by 2002:adf:87e1:: with SMTP id c30-v6mr257620wrc.246.1526465818572; Wed, 16 May 2018 03:16:58 -0700 (PDT) Received: from localhost (slip139-92-244-193.lon.uk.prserv.net. [139.92.244.193]) by smtp.gmail.com with ESMTPSA id b185-v6sm2272405wmb.25.2018.05.16.03.16.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 May 2018 03:16:57 -0700 (PDT) From: luca.boccassi@gmail.com To: Andy Green Cc: Rasesh Mody , dpdk stable Date: Wed, 16 May 2018 11:13:22 +0100 Message-Id: <20180516101323.2234-3-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180516101323.2234-1-luca.boccassi@gmail.com> References: <20180515135335.10459-2-luca.boccassi@gmail.com> <20180516101323.2234-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnx2x: fix KR2 device check' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 May 2018 10:16:59 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/18/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From ddbfb55c25936144971f365a745f17b2bb6b4cf4 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Mon, 14 May 2018 13:04:33 +0800 Subject: [PATCH] net/bnx2x: fix KR2 device check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit d9b8838ab2e90713827ee8843d836b0fccbaf2f7 ] In function ‘elink_check_kr2_wa’: drivers/net/bnx2x/elink.c:12922:28: error: bitwise comparison always evaluates to false [-Werror=tautological-compare] ((next_page & 0xe0) == 0x2)))); This was fixed elsewhere in 2014 Fixes: b5bf7719221d ("bnx2x: driver support routines") Signed-off-by: Andy Green Acked-by: Rasesh Mody --- drivers/net/bnx2x/elink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c index cceae6f9b..74e1bead3 100644 --- a/drivers/net/bnx2x/elink.c +++ b/drivers/net/bnx2x/elink.c @@ -12921,7 +12921,7 @@ static void elink_check_kr2_wa(struct elink_params *params, */ not_kr2_device = (((base_page & 0x8000) == 0) || (((base_page & 0x8000) && - ((next_page & 0xe0) == 0x2)))); + ((next_page & 0xe0) == 0x20)))); /* In case KR2 is already disabled, check if we need to re-enable it */ if (!(vars->link_attr_sync & LINK_ATTR_SYNC_KR2_ENABLE)) { -- 2.14.2