patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Tiwei Bie <tiwei.bie@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
	dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v3] vhost: improve dirty pages logging performance
Date: Thu, 17 May 2018 12:50:14 +0800	[thread overview]
Message-ID: <20180517045014.GA22736@debian> (raw)
In-Reply-To: <20180517060353-mutt-send-email-mst@kernel.org>

On Thu, May 17, 2018 at 06:06:34AM +0300, Michael S. Tsirkin wrote:
> On Wed, May 16, 2018 at 06:54:23PM +0200, Maxime Coquelin wrote:
> > This patch caches all dirty pages logging until the used ring index
> > is updated.
> > 
> > The goal of this optimization is to fix a performance regression
> > introduced when the vhost library started to use atomic operations
> > to set bits in the shared dirty log map. While the fix was valid
> > as previous implementation wasn't safe against concurent accesses,
> > contention was induced.
> > 
> > With this patch, during migration, we have:
> > 1. Less atomic operations as only a single atomic OR operation
> > per 32 or 64 (depending on CPU) pages.
> > 2. Less atomic operations as during a burst, the same page will
> > be marked dirty only once.
> > 3. Less write memory barriers.
> > 
> > Fixes: 897f13a1f726 ("vhost: make page logging atomic")
> > 
> > Cc: stable@dpdk.org
> > 
> > Cc: Tiwei Bie <tiwei.bie@intel.com>
> > Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> 
> Deferring updates until GET_BASE would also be possible,
> but would increase the chance that a disconnect causes
> ring to become inconsistent.

Yeah. The sync of the updates from vhost backend will
be deferred a lot. Another issue is that, it probably
will increase the downtime, as there will be more pages
to sync after the old device is stopped and before the
new device is started.

> 
> I'm not sure whether there is a chance of that with this
> patch (in case of a crash after used idx updated but
> before dirty log update of the used idx), but
> at least it's not bigger than before this patch.

The used idx update and the corresponding logging
are two operations instead of one atomic operation.
So theoretically, it should be possible.

I got your point now. Maybe we should add a barrier
between cache sync and the used idx update to ensure
that all dirty pages are logged before they can be
seen by the guest.

Best regards,
Tiwei Bie

  reply	other threads:[~2018-05-17  4:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16 16:54 Maxime Coquelin
2018-05-17  2:04 ` Tiwei Bie
2018-05-17  3:06 ` Michael S. Tsirkin
2018-05-17  4:50   ` Tiwei Bie [this message]
2018-05-17 11:40     ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180517045014.GA22736@debian \
    --to=tiwei.bie@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=mst@redhat.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).