patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Tiwei Bie <tiwei.bie@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, mst@redhat.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v4] vhost: improve dirty pages logging performance
Date: Thu, 17 May 2018 20:13:01 +0800	[thread overview]
Message-ID: <20180517121301.GA22907@debian> (raw)
In-Reply-To: <81a73714-9a7f-0b64-d508-2eb03422fe06@redhat.com>

On Thu, May 17, 2018 at 02:01:52PM +0200, Maxime Coquelin wrote:
> Hi Tiwei,
> 
> On 05/17/2018 01:44 PM, Maxime Coquelin wrote:
> > This patch caches all dirty pages logging until the used ring index
> > is updated.
> > 
> > The goal of this optimization is to fix a performance regression
> > introduced when the vhost library started to use atomic operations
> > to set bits in the shared dirty log map. While the fix was valid
> > as previous implementation wasn't safe against concurrent accesses,
> > contention was induced.
> > 
> > With this patch, during migration, we have:
> > 1. Less atomic operations as only a single atomic OR operation
> > per 32 or 64 (depending on CPU) pages.
> > 2. Less atomic operations as during a burst, the same page will
> > be marked dirty only once.
> > 3. Less write memory barriers.
> > 
> > Fixes: 897f13a1f726 ("vhost: make page logging atomic")
> > 
> > Cc:stable@dpdk.org
> > 
> > Cc: Tiwei Bie<tiwei.bie@intel.com>
> > Suggested-by: Michael S. Tsirkin<mst@redhat.com>
> > Signed-off-by: Maxime Coquelin<maxime.coquelin@redhat.com>
> 
> I missed to add your:
> Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
> 
> that you replied to v3, and since the changes in v4 were suggested by
> you, I guess it still applies.

Yeah. Thanks! :)

Best regards,
Tiwei Bie

  reply	other threads:[~2018-05-17 12:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 11:44 Maxime Coquelin
2018-05-17 12:01 ` Maxime Coquelin
2018-05-17 12:13   ` Tiwei Bie [this message]
2018-05-17 12:33   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180517121301.GA22907@debian \
    --to=tiwei.bie@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=mst@redhat.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).