From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id ACB8E2AA0 for ; Sun, 20 May 2018 15:08:32 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A628321DCC; Sun, 20 May 2018 09:08:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 20 May 2018 09:08:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:message-id:subject:to:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=5rf5XeFWlzQLpNePvzox6v1Rw/UxNkE0+Wt0BuEii D4=; b=If7VWqMHxRd/9B5CO/MblZCXN2sJSmszAux/Wm+/HPisbbqNh7LXdnn1+ L3GFLqLDnnHr+7rN9G6Yia2B7fpQ30uAeBKRk2ZYMhr3LDURjoZosp1gQ3hJfFIS MQ94HeisN9byIf6QJW3L3Zx7BtiYQ5QFuq+b7Ow8CN0EABNQ3YcafmjR9uXdHKSP wA92uWnvb9wuWKcU98GG1Fxj9LXA5V4pZbUDNS2XGyHefshe0aT3kVKsKY+ESksZ tVd0LAERQKg7UiP5Ueu+HNnxkKozZDVYPWRgWjPCyfksNpK01I4JZLaSNzqlbYjm OinEb6lFMFbFYwCMAucQmLvb1/6/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=5rf5XeFWlzQLpNePv zox6v1Rw/UxNkE0+Wt0BuEiiD4=; b=PVGhP1qJeWeEDVf3BI/oHBHAGaytRKC/l fwhV9+StsmyHr5L1RYh42fR21TmHdp42GtvjU/euqsoA++mxkuFjqwawdorXN0S5 6isQAj0YeR1jlM1NUBF90xnq6NZHTs4GAVBupPwaNk1sppc9NTbkiSimwu6ZSwkS b0i4Fc8hjcnVR53p2fLkZfZhQsVLGoRDvyKvi04zLrmVnQIwzSSzN6bHW2+/6H5G 8pfOw6Mt3XAWLzc8yLAXgRZIXgtU+J1Oje8ZLKQBd1npsRXCm5XKK8bCt+m1lDO1 36WhJNjhGLdEIeUt7fdZxGwwgDZSJuY6+OEN4qYFRWhVblgGpJUNg== X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from yuanhanliu-NB0.tencent.com (unknown [223.74.148.80]) by mail.messagingengine.com (Postfix) with ESMTPA id D79921025C; Sun, 20 May 2018 09:08:29 -0400 (EDT) From: Yuanhan Liu To: Ashish Jain Cc: Hemant Agrawal , dpdk stable Date: Sun, 20 May 2018 21:02:17 +0800 Message-Id: <20180520130246.16287-1-yliu@fridaylinux.org> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-stable] patch 'event/dpaa2: remove link from info structure' has been queued to LTS release 17.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 May 2018 13:08:33 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/27/18. So please shout if anyone has objections. Thanks. --yliu --- >>From b738cfc80589ec3b6f6b7d39fdc31e26a817c40f Mon Sep 17 00:00:00 2001 From: Ashish Jain Date: Wed, 9 May 2018 14:50:53 +0530 Subject: [PATCH] event/dpaa2: remove link from info structure [ upstream commit 64f5de4194f89390c01ca137185f395ae2a95681 ] Removing use of link data under evq_info_t structure which was used to check whether the the associated evq has been linked or not. Since, an evq can be linked to multiple event ports, thus setting the link variable only allowed the first event port to be associated with the evq. This led to huge performance drop in case of multiple event ports as I/O only worked on first event port associated with the evq. Fixes: 0ce3ce7c275c ("event/dpaa2: add configuration functions") Signed-off-by: Ashish Jain Acked-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 5 ----- drivers/event/dpaa2/dpaa2_eventdev.h | 1 - 2 files changed, 6 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index eeeb23127..56ea124cf 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/drivers/event/dpaa2/dpaa2_eventdev.c @@ -489,7 +489,6 @@ dpaa2_eventdev_port_unlink(struct rte_eventdev *dev, void *port, dpio_remove_static_dequeue_channel(dpaa2_portal->dpio_dev->dpio, 0, dpaa2_portal->dpio_dev->token, evq_info->dpcon->dpcon_id); - evq_info->link = 0; } return (int)nb_unlinks; @@ -510,8 +509,6 @@ dpaa2_eventdev_port_link(struct rte_eventdev *dev, void *port, for (i = 0; i < nb_links; i++) { evq_info = &priv->evq_info[queues[i]]; - if (evq_info->link) - continue; ret = dpio_add_static_dequeue_channel( dpaa2_portal->dpio_dev->dpio, @@ -526,7 +523,6 @@ dpaa2_eventdev_port_link(struct rte_eventdev *dev, void *port, qbman_swp_push_set(dpaa2_portal->dpio_dev->sw_portal, channel_index, 1); evq_info->dpcon->channel_index = channel_index; - evq_info->link = 1; } RTE_SET_USED(priorities); @@ -540,7 +536,6 @@ err: dpio_remove_static_dequeue_channel(dpaa2_portal->dpio_dev->dpio, 0, dpaa2_portal->dpio_dev->token, evq_info->dpcon->dpcon_id); - evq_info->link = 0; } return ret; } diff --git a/drivers/event/dpaa2/dpaa2_eventdev.h b/drivers/event/dpaa2/dpaa2_eventdev.h index ae8e07e97..5b9c80e5a 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.h +++ b/drivers/event/dpaa2/dpaa2_eventdev.h @@ -100,7 +100,6 @@ struct evq_info_t { struct dpaa2_dpci_dev *dpci; /* Configuration provided by the user */ uint32_t event_queue_cfg; - uint8_t link; }; struct dpaa2_eventdev { -- 2.11.0