From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id DB08C8DAB for ; Sun, 20 May 2018 15:08:54 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8644F216BD; Sun, 20 May 2018 09:08:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 20 May 2018 09:08:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ZPZTo5r8TsOUGpdt+ Sq6sfPPOS+Jx+bCkGSQZWiazgI=; b=UHj1p/W3fqtVLKhDvIS7UXobxsLiV9dLM vhFBtCImpY2DM4mMrufMdfd7riICmoc+4xtdJdeIofY05lHIzmJsivdnS+4oLAtI Xf3p33X47LL2o6aIIqmgc8EhW+/uJqTh1fcn9vJDNX2VB7HMFlli4jzXz5ZulnWz xWdbvlZbRgCsTyPNbSse1FQ+rCgAtgkengmglOpM2FA7Y/Y3d07aKnZ5Jxx7M8pW mfx6DZ+y6yHRFtlVWJLSodpLVjLRbUa8Lcm4iCqWQAUZ8HKlR4HgeBG2XRfRPTUb itJQEy6R1SwWwR+puOhDIRlExwK/KnvwON7mK0rkSkXod9YpLSpRg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=ZPZTo5r8TsOUGpdt+Sq6sfPPOS+Jx+bCkGSQZWiazgI=; b=Aw3w8yw3 hUQG+uTidu8JKGc6ne3x1hwSoOKHimNUDurvimtQ3lEencDkdkkdhYF1C2qr3Wmn Ap70u0tu11Ne0YSxu+wjVggw54ZJzcKC8041tyMlrMw+xM7ei5tepLSBCVbM8OAt nJIhLTvQ6b+W8T/wObquH8vioxi5rTI02wxNHD9oakWA8i8DpcSX0xD8BsJd4D1t C8Prit7i0G8R2hQQMpO8O6nsoaM/52Hi2Cc6CMlRcmtg50lmbDQt2M4VA6Gjj6MH oQEeM3nDgE8gGC89uFWUir2JozvnFmrrRQyLgTacbUpDfuQtqbjcK3hN3Izm210z r3RTFUi2gKxKsQ== X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from yuanhanliu-NB0.tencent.com (unknown [223.74.148.80]) by mail.messagingengine.com (Postfix) with ESMTPA id 1AD7E10260; Sun, 20 May 2018 09:08:52 -0400 (EDT) From: Yuanhan Liu To: Matan Azrad Cc: dpdk stable Date: Sun, 20 May 2018 21:02:28 +0800 Message-Id: <20180520130246.16287-12-yliu@fridaylinux.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180520130246.16287-1-yliu@fridaylinux.org> References: <20180520130246.16287-1-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'app/testpmd: fix forward ports Rx flush' has been queued to LTS release 17.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 May 2018 13:08:55 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/27/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 4fd77ef6b89a691d060f59675aa0da166c450b50 Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Thu, 3 May 2018 10:31:45 +0000 Subject: [PATCH] app/testpmd: fix forward ports Rx flush [ upstream commit 47a767b2ee253ccdd084af88d3e390ed9e74f20b ] A port Rx queue flush is done when the packet forwarding starts in order to clean the port statistics for a new traffic session. The flush operation is wrongly called before the update of the new forward ports, and may fail due to flush operation for an invalid port configured by the old session. Move the new forward port setup to be done before the Rx queue flush. Fixes: 7741e4cf16c0 ("app/testpmd: VMDq and DCB updates") Signed-off-by: Matan Azrad --- app/test-pmd/testpmd.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 254bd9449..4b9cc4d28 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1250,10 +1250,6 @@ start_packet_forwarding(int with_tx_first) return; } - if (init_fwd_streams() < 0) { - printf("Fail from init_fwd_streams()\n"); - return; - } if(dcb_test) { for (i = 0; i < nb_fwd_ports; i++) { @@ -1273,10 +1269,11 @@ start_packet_forwarding(int with_tx_first) } test_done = 0; + fwd_config_setup(); + if(!no_flush_rx) flush_fwd_rx_queues(); - fwd_config_setup(); pkt_fwd_config_display(&cur_fwd_config); rxtx_config_display(); -- 2.11.0