From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 853DF2AA0 for ; Sun, 20 May 2018 15:08:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 34CC921D4F; Sun, 20 May 2018 09:08:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 20 May 2018 09:08:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=QNoYZwqf8YrLoqP4H 4vJY+7w/BRO/Xcvp3uoNasK24Q=; b=X24FzWkqHK4RUyhCkt1q7CRzGSx8YADd9 eS+oe0884FfAY304bGQC3skMpP2/oZjkZkxW5udMrL4kUXwaYOepb5NfDoG20j3K cI7Vg2aLyabnfHJ+xR7XNBYzoSCnu7QzwlMlbCwKQXiI/MNLvLAtf6040/qAYC44 44EquW8fRK70JCrUuRTMS2dL6PBk8fS3mVpx3TnStBTYnKJQTWORWmAGeCqNgxC/ neBmauj6KRFDuCpDW3dB7H/VHigLzLjQ/v6zcsyKQkXN4zSW6vA/lTheXV1lcMAS FhSuP1KmdCYQrhx8TlnFAj13PmgO9vxosUgp7asvs3HMnwj7W08gA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=QNoYZwqf8YrLoqP4H4vJY+7w/BRO/Xcvp3uoNasK24Q=; b=OGyBi/9R U3r84cGSVU0vfjoudlwrjhB8r8vIAtO80qIrpBOoBi2Ednvn172JmeSvJPpewktg 51rpD69Yz7vdeUCom1lEnYNfG5ATsIozzPW5vOJ+6NFgxWhrDLHpu9CZ2qzUiFgT avzoerUIrVtJOnfz3Rjzahf87khB8QN0yBpRYhVEFk2IMK3eTbbQkQFVbkbovyxq HHUj4gwII9/HEspZYMOucmrdawspsd5EUuP0VnZf8t+klsYDlOLZEUTMlbM4F9OB TTSsrHDiIIcxS2JRhuU55yQbuhiIPoAr6yL/0zVOQ4jk7THHmszHEhnBvZEdQrJw IYgqRRJ1U3p1jg== X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from yuanhanliu-NB0.tencent.com (unknown [223.74.148.80]) by mail.messagingengine.com (Postfix) with ESMTPA id B39F11025C; Sun, 20 May 2018 09:08:56 -0400 (EDT) From: Yuanhan Liu To: Matan Azrad Cc: dpdk stable Date: Sun, 20 May 2018 21:02:30 +0800 Message-Id: <20180520130246.16287-14-yliu@fridaylinux.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180520130246.16287-1-yliu@fridaylinux.org> References: <20180520130246.16287-1-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'app/testpmd: fix removed device link status asking' has been queued to LTS release 17.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 May 2018 13:08:58 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/27/18. So please shout if anyone has objections. Thanks. --yliu --- >>From ed06f809736bb42226370987e3f193b7bb7fb265 Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Thu, 3 May 2018 10:31:47 +0000 Subject: [PATCH] app/testpmd: fix removed device link status asking [ upstream commit 0da2a62bf9d72625fb5b779d9fd91e471ed2fb4a ] In the RMV device event callback, there is a call for the removed device stop operation which triggers a link status operation for the removed device. It may casue an error from the removed device PMD. Skip the link status operation in the above described case. Fixes: 284c908cc588 ("app/testpmd: request device removal interrupt") Signed-off-by: Matan Azrad --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index c794afd83..92542ec64 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2026,13 +2026,16 @@ check_all_ports_link_status(uint32_t port_mask) static void rmv_event_callback(void *arg) { + int org_no_link_check = no_link_check; struct rte_eth_dev *dev; portid_t port_id = (intptr_t)arg; RTE_ETH_VALID_PORTID_OR_RET(port_id); dev = &rte_eth_devices[port_id]; + no_link_check = 1; stop_port(port_id); + no_link_check = org_no_link_check; close_port(port_id); printf("removing device %s\n", dev->device->name); if (rte_eal_dev_detach(dev->device)) -- 2.11.0