From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1CE5C8DB3 for ; Sun, 20 May 2018 15:09:15 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C06A221D4F; Sun, 20 May 2018 09:09:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 20 May 2018 09:09:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=vLlND1f5RBbUv6gKf zqLH+3gw2kgOabcQuvTL1koof4=; b=YNn5h0TarmVjti1flY857PT36bUrlfmbg bGK1NfsROl7k2BbYkDfAgnWf/RC6Ae9l15Np4OU2wpzruQabjk9UL9xPScm9795v +zVHAK3kn8WWKo2ZhsbzupBirYC1tgoXyyHxRXcJ06gbbMMSkuEzik93RC8LQECG FaFgrvjyWSDg9PeQt6uSWJQXPRv52kob1VU5Kbl674s0sIhHUkQ8o1rjHTYtf1h0 QWVMDqFni2IKmdsilkwtptFNE38RPAX6w2bplyGLlKrd8WlzLC5TDnEeW7BdTxsc k6k+ySK0e9bEmM7I/mTVoy7udIb+YTtdypqh/nK/65xnuDbm6z2OA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=vLlND1f5RBbUv6gKfzqLH+3gw2kgOabcQuvTL1koof4=; b=mdjud4rf +rBWJkmTHsbqqdhh7h3v21NxgkjdLJJVD3NbsEi6kI+Qd9va9GCJONhpGss05Hsl w4xCGTkwp4EKaJrov/LhO3eoVR+P4K5FF4uAfIzVhjivtF0yZa55XZcKdv2ou0fq qmvqpEVQrbrWf1Jbi6MaSdA4rqg1KeMwx6ol8X85mB1of7LS6s+HT8/+47yamuJH TpDvFXn93luT5ctDUxgt9VMisRTSAdJ7Ws/h5gtQVpqZYBVULeLvb01IOSUoRzxp 9WWr3yfW2BmzSjiRsGneL6erM1emMxvtlL6fA5JdcTPih4YsaIyFUl/cQ54o8yUt UdbGBdEsOKr1+w== X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from yuanhanliu-NB0.tencent.com (unknown [223.74.148.80]) by mail.messagingengine.com (Postfix) with ESMTPA id 0532F1025C; Sun, 20 May 2018 09:09:12 -0400 (EDT) From: Yuanhan Liu To: Adrien Mazarguil Cc: Ferruh Yigit , dpdk stable Date: Sun, 20 May 2018 21:02:37 +0800 Message-Id: <20180520130246.16287-21-yliu@fridaylinux.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180520130246.16287-1-yliu@fridaylinux.org> References: <20180520130246.16287-1-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'app/testpmd: fix empty list of RSS queues for flow' has been queued to LTS release 17.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 May 2018 13:09:15 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/27/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 1b03a8e26d9ad48196e24675e34f9284776aeca6 Mon Sep 17 00:00:00 2001 From: Adrien Mazarguil Date: Thu, 3 May 2018 13:59:42 +0200 Subject: [PATCH] app/testpmd: fix empty list of RSS queues for flow [ upstream commit 9278a4333ad021754c0822a7db18d574c5103209 ] Since the commit referenced below, specifying a RSS action without any queues (e.g. "actions rss queues end / end") does not override the default set automatically generated by testpmd. In short, one cannot instantiate a RSS action with 0 target queues anymore in order to determine how PMDs react (hint: this is currently undocumented so they may reject it, however ideally they should interpret it as a default setting like for other fields where empty values stand for "defaults".) Fixes: d0ad8648b1c5 ("app/testpmd: fix RSS flow action configuration") Signed-off-by: Adrien Mazarguil Reviewed-by: Ferruh Yigit --- app/test-pmd/cmdline_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index df16d2ab9..35440eaf3 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -2028,7 +2028,7 @@ parse_vc_action_rss_queue(struct context *ctx, const struct token *token, i = ctx->objdata >> 16; if (!strcmp_partial("end", str, len)) { ctx->objdata &= 0xffff; - return len; + goto end; } if (i >= ACTION_RSS_NUM) return -1; @@ -2045,6 +2045,7 @@ parse_vc_action_rss_queue(struct context *ctx, const struct token *token, if (ctx->next_num == RTE_DIM(ctx->next)) return -1; ctx->next[ctx->next_num++] = next; +end: if (!ctx->object) return len; ((struct rte_flow_action_rss *)ctx->object)->num = i; -- 2.11.0