From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67]) by dpdk.org (Postfix) with ESMTP id 3A90D1B1E3 for ; Mon, 21 May 2018 18:13:47 +0200 (CEST) Received: by mail-pg0-f67.google.com with SMTP id 63-v6so4411789pgg.3 for ; Mon, 21 May 2018 09:13:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KofwLRTWYX6tTiYhl741TDUw1p61ZGMb3uSTzBgpHTQ=; b=EOur+QZCSkkzGKHnNhAP2Y3uvOB+4wY8bz0Cfwp/GdiZgYuAenWOqMFCXA+zTJmkru heerEsx2IldXjGy08kpD5ZCJVfK6bjFosSzil6XDGwRqkrbLlYsg8uE+LnUfMVT4lPJu 622DHlXvsBrxIqI38/WDGWoD8lRDuTviVE7THHl9ZOs0L56c0rC9UXE8rCezAs1WL6GA WXnCexSWC13Vgp2ilFg9GYkzfXHB5qvvA9izukgaoTeTSX9WXrzIwriTuPVSBMljHBgy dZb/Lx2wwO4duRVjAe3E/5ZOa/hVGNG852kQll42zpV/xJu/FduLHLAVug+ifTA4C4Vl sj8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KofwLRTWYX6tTiYhl741TDUw1p61ZGMb3uSTzBgpHTQ=; b=IFm0DbrGslHx1UY2uZaM8e03t6VU0A41CVn28Lf9GnZVUT8BqnlsB7keJ5Sz7jScgb c5VDepL0bD39ZTkx7I9PEpbFKtmLhskAefaXAc8EHg+oI99CxJ80UqlDuw/bXayGMYdp jIsITJdP1lD/C2qbNtoZPtrK5I+NNdtJ/InXebpFaiJF3qhiDbql7xrVvizL+a+ln1/y YREwyEI8suMVpVLFyb0mn+PeFokhAVFCG3vhOKEXVjpYj+ZKWgWv+HGObBFarroLheKd MyzaoVKqZ3Qwk3P8yiY/mUHgLIWRF3jnONCR8+iFg9o/hXYYTjuZvSofItGrMxiMeRbi rB8g== X-Gm-Message-State: ALKqPwe6pWB7BvpTu6ouLhZfszv0qySMYufhraaAU2UDSmxK55RTmZWV 19AuLFMTanTLIJo1t+lPfMxnzg== X-Google-Smtp-Source: AB8JxZq84JCOW41X/+XJji0ZWhb9W8W5zR0w879s84wvZdk6rd+LcEU/hRznN5VcZCMP9enZv2QlUw== X-Received: by 2002:a65:4c8d:: with SMTP id m13-v6mr16487350pgt.310.1526919226385; Mon, 21 May 2018 09:13:46 -0700 (PDT) Received: from xeon-e3 (204-195-35-107.wavecable.com. [204.195.35.107]) by smtp.gmail.com with ESMTPSA id 206-v6sm24432969pfy.51.2018.05.21.09.13.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 May 2018 09:13:46 -0700 (PDT) Date: Mon, 21 May 2018 09:13:43 -0700 From: Stephen Hemminger To: Radu Nicolau Cc: Thomas Monjalon , dev@dpdk.org, ferruh.yigit@intel.com, stable@dpdk.org Message-ID: <20180521091343.237f2e96@xeon-e3> In-Reply-To: <8ed23c52-4b88-b40a-ccc5-31c6993654a1@intel.com> References: <1526902547-12710-1-git-send-email-radu.nicolau@intel.com> <5146448.Vdf9GQnNb8@xps> <8ed23c52-4b88-b40a-ccc5-31c6993654a1@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] test: fix hang on FreeBSD X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 16:13:47 -0000 On Mon, 21 May 2018 13:58:39 +0100 Radu Nicolau wrote: > On 5/21/2018 1:30 PM, Thomas Monjalon wrote: > > 21/05/2018 13:35, Radu Nicolau: > >> Fixes: af75078fece3 ("first public release") > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Radu Nicolau > >> --- > >> @@ -34,7 +34,8 @@ test_panic(void) > >> printf("Fork Failed\n"); > >> return -1; > >> } > >> - wait(&status); > >> + sleep(1); > >> + waitpid(pid, &status, WNOHANG); > > Please give an explanation why you are adding this sleep. > > > To give a chance to the child process to complete before calling waitpid. Should not be necessary; waitpid does that.