From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id A12752BF3 for ; Wed, 23 May 2018 14:10:56 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id j5-v6so8506263wme.5 for ; Wed, 23 May 2018 05:10:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FWNcTDBLyoLeMVi6zMflsxLVqbIjCqFSoA2/YrNWnI8=; b=hIgBCMoj3y8d/RONoNyjGy4lnMqOkKNJ+lBQZSsFeOYHj9DPOyte3B/p9K4KjRHxDk q2ATTI4BuWZfsspp3JE6SYO2ygTguJRrf35Zz5iFVhhBXubSWtUGDLxmXlGDA+QHMgSD 1CS1GxKvyjLY0/ZBN9GFMHk6JcKVfU7xkNoOR2FGEIIghkaayeqmIo7u4kVhz3/svHvU pJOmmOuUY0WP2C0C1+rIuag+yOgxAX/wqJLPC0Rf0Khdyxvxa77NzJP8MB/R2LpwGnHV FPdhtNwJXPDo6jGtiMLKszHKX0p/Ky3kN04k/AAnUxGVG81lJdFUomOweySLeI/807KG VEkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FWNcTDBLyoLeMVi6zMflsxLVqbIjCqFSoA2/YrNWnI8=; b=oBVSj6pvMSvTovOvg0hetGNMO08ws17p8RQGpQ0kOsKbosXEgIalqQjt7H0ayr5YGA bmveUVKkpzJNwxdETTX+Wm+Eje7bktB3G/VbqS8kYjiFy2CRoUbhokFheBIYxY+QZHv4 r2tpKHS0sbs7z83nO1kSVODavJtII8d+/0ozjzUGiupfu5hKfz0VNRxWKkxIGUytC9Aq fk7z2/V10/i+qQrbQ32Sa9vGFkohahXtHHCa0e0OVovYsDW8FyvpxiVpd1y81fCQbfW+ GgL2L9bcQ0w/LSy8yrnRuwvj43BbHBgzuOcIy4evqUSSKHmqoG6wfm+JRIDoaccxKW+7 C0qg== X-Gm-Message-State: ALKqPwdt31qJTtKn1IJkOBd+aJzVo1BF/5XVkFgDx0q7R6N3+QMYVC36 rN9+sbEAmGc7itlNRAhXYac= X-Google-Smtp-Source: AB8JxZpIb/KMqjREVyafUwzWqVTs8qS7WjwbqjiFASvSHLz/xbAQiJxgCwcOBTurXoMzrxBLNtjnEA== X-Received: by 2002:a1c:424f:: with SMTP id p76-v6mr3692018wma.15.1527077456289; Wed, 23 May 2018 05:10:56 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id u8-v6sm1695701wmc.40.2018.05.23.05.10.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 May 2018 05:10:55 -0700 (PDT) From: luca.boccassi@gmail.com To: Daniel Shelepov Cc: Bernard Iremonger , dpdk stable Date: Wed, 23 May 2018 13:09:35 +0100 Message-Id: <20180523121010.8385-24-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180523121010.8385-1-luca.boccassi@gmail.com> References: <20180516101323.2234-2-luca.boccassi@gmail.com> <20180523121010.8385-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'app/testpmd: fix burst stats reporting' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 12:10:56 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/25/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 2c89029253b5914eb232600723ae8120d19cf38f Mon Sep 17 00:00:00 2001 From: Daniel Shelepov Date: Mon, 14 May 2018 21:12:15 +0000 Subject: [PATCH] app/testpmd: fix burst stats reporting [ upstream commit fe613657ce486083a3ed96890c95de4f35c8593b ] When RTE_TEST_PMD_RECORD_BURST_STATS is enabled, testpmd collects burst statistics and includes them in the port stats report. The summary should include top 2 most frequent burst sizes, but there is a bug in finding the top-2. During the scan of burst size counts, the top-2 can change only if top-1 also changes. Added logic to update the top-2 if current burst size is larger than existing top-2, but smaller than existing top-1. Fixes: af75078fece3 ("first public release") Signed-off-by: Daniel Shelepov Acked-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 85d5cde09..05a68a068 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -926,6 +926,9 @@ pkt_burst_stats_display(const char *rx_tx, struct pkt_burst_stats *pbs) pktnb_stats[1] = pktnb_stats[0]; burst_stats[0] = nb_burst; pktnb_stats[0] = nb_pkt; + } else if (nb_burst > burst_stats[1]) { + burst_stats[1] = nb_burst; + pktnb_stats[1] = nb_pkt; } } if (total_burst == 0) -- 2.14.2