From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id ABF822C8 for ; Wed, 23 May 2018 14:11:02 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id w10-v6so3249504wrk.9 for ; Wed, 23 May 2018 05:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cR8QF+tP2T0nyNN9LDAPiUupJCePgMe3chSqrYcAOdE=; b=XlSCojt/jREZAPQFrQaTQb/6ZpBh2U2+wiohW7tmcjxLnmOlAIlM6lm4Uu+OUTHrdg 23NH/SExcLhP7FCeok86TrpK5bw1oeIJzESoLFqYkOnP3gkjjwOB5IZN8U3MbxpPYEBw ixHKajhSHG+icBpUtWMpIDD7vyX5y++BHPhBl3yFJBJHQi9lOBPgtdEJUNEYvUlQ9DPe E/9dSAd6LAaZ09ZX8EvaEvwf9jXbagvyGDzdKbfLkX/lVfNTuc8fmJLQDKuQ5So3WGV8 4eukS8Ckta/jmcUevizg288EDvMP5KqFUC7OqsEez8M0ympq8yVmvteulWq4PsL1BVAo P78A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cR8QF+tP2T0nyNN9LDAPiUupJCePgMe3chSqrYcAOdE=; b=S5wZLIInbAfHdvjonrapscGNRg/JQpvyFEnH+Ea+rKZSlAzCreS2RwGvFL3+9iL1lv TK5RNGug3kK8Vl9OEJ78kPZNwRU+zas959R8iFvzA+nvpEHlKdbfa+FXQI98OcbXI704 uqfHNM/Y+4lzA86y4yXblt9zhMYw0q0Tk04HaUfHrWp/Skxd3ezgDtAE9KC5HoKHthGv BfirA68tG+C0A2jQvMFt0vGR53xGaJ4bGF1jXwfRiKKpwzBC9m+yaCMDbKnADRerM31Y Y+G/w4K/6F25N9G1Jbtk4641GJMFq5DVovp1YglSl0rxy7YNMIIy8Jld9jOylJApoZXA 3H8Q== X-Gm-Message-State: ALKqPwfwP9emgqSw4w+sa3s9axDDCh/b8KuGeRlUO3k75tcfhCEvNR/u 4FbDN68f7BURg7tlnNIkjvg= X-Google-Smtp-Source: AB8JxZqTDzaYBsj/VO9bp0PQl1Fxf/j1CVZc7/PvymEyBWIZx5sui1vIpqhKqB9fDjTsUTKWgM3ZcA== X-Received: by 2002:a5d:410b:: with SMTP id l11-v6mr2435285wrp.88.1527077462410; Wed, 23 May 2018 05:11:02 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id v12-v6sm15713020wrm.68.2018.05.23.05.11.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 May 2018 05:11:01 -0700 (PDT) From: luca.boccassi@gmail.com To: Andy Green Cc: Bruce Richardson , dpdk stable Date: Wed, 23 May 2018 13:09:39 +0100 Message-Id: <20180523121010.8385-28-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180523121010.8385-1-luca.boccassi@gmail.com> References: <20180516101323.2234-2-luca.boccassi@gmail.com> <20180523121010.8385-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'mbuf: fix type of private size in detach' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 12:11:02 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/25/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 665c8e2a5c7f0900ebe938cecab8c22e3b4bfeea Mon Sep 17 00:00:00 2001 From: Andy Green Date: Tue, 22 May 2018 09:24:27 +0800 Subject: [PATCH] mbuf: fix type of private size in detach [ upstream commit ad3781066261848c163e700c3c5baa16fecc2247 ] GCC 8.1 warned: In function 'rte_pktmbuf_detach': rte_mbuf.h:1583:17: warning: conversion from 'uint32_t' {aka 'unsigned int'} to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion] m->priv_size = priv_size; ^~~~~~~~~ The temp priv_size is declared as a uint32_t. But it only deals in uint16_t. m->priv_size is a uint16_t. Change it to a uint16_t. Fixes: 355e6735b3 ("mbuf: fix cloning with private mbuf data") Signed-off-by: Andy Green Acked-by: Bruce Richardson --- lib/librte_mbuf/rte_mbuf.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index f50607c8c..198ba8e22 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -1347,7 +1347,8 @@ static inline void rte_pktmbuf_detach(struct rte_mbuf *m) { struct rte_mbuf *md = rte_mbuf_from_indirect(m); struct rte_mempool *mp = m->pool; - uint32_t mbuf_size, buf_len, priv_size; + uint32_t mbuf_size, buf_len; + uint16_t priv_size; priv_size = rte_pktmbuf_priv_size(mp); mbuf_size = (uint32_t)(sizeof(struct rte_mbuf) + priv_size); -- 2.14.2