From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id CC1822BF2 for ; Wed, 23 May 2018 14:11:31 +0200 (CEST) Received: by mail-wr0-f196.google.com with SMTP id w3-v6so18343045wrl.12 for ; Wed, 23 May 2018 05:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vD4oZQPZ1lpww0AjJv1I8lIln2INmKtXtdTelOAt848=; b=H/pAKoJeYG63+vo99TE3wgUspuTgrD+cmgHjrQlg3S6T8u44WDgWK69RdmZX5vmDwq UDMG5klxg+2k3bM2k3UaxJ/ADETF7dBXOgBsvpLqwdNVcNc/SM8C1rlK7r+FJZ2ikDx9 jmQ/gbutr7WvLe/KQoDDIQOJsv4eeyYd8VvQi1WtILC85BWyRo9ONOkTzCPuFSKrCMIp 5yT5vFhREDJnD4j74gqwNeT5XBUyns0xYqNeeFvPASCJW0Bv3ijAeQ/tr4L3ITkR//dm VkkqVibgKEWA7fSon1rXWsnBgaYNPPefOouIku1ssCHaCDxFwuWB+frik4dATdNmI5p3 gKmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vD4oZQPZ1lpww0AjJv1I8lIln2INmKtXtdTelOAt848=; b=Yvi2Ck/it9CwTadsYlHKoqiL7MAYGrPy9uOzQ/XiZW951BxjFbi1Z6mkFfVES0qOK9 w8ys+M283nOCGeeWyWm4TYxR5Z7wvnZ7ttcJ1CkK3dawTQk1LhPfw5JL5l2gdd5pFmIS 9iOcBmOE0GPQeJaZw8h4sHMTszgNlWeUd5O49DRNniKQeOdXhdyderlKdtr84BTR22Nu oFS+AB3+xjobxZN0gRk6xpHxgaDSwhUfL/v3T0bGfE0jE1Gv9aTSgGh4mM3gW6E2M0su 7PUNc3ap4Q7tdQk4fEokc0MnWihgAtuqMvNv4YcrzRrJpnY1Nffh0qAAXFmz2c3iiD8B L+ew== X-Gm-Message-State: ALKqPwe4ftnL0h+3VHKQjhhtcUQSItrrVw9+zi6Xe2f0R2mfDwQqoPGS win8PAv3Ux8pCQsOXxWrsO6iaBRwTds= X-Google-Smtp-Source: AB8JxZrMFTYOmlLR3r0yBt7HNuC49oEEhDzc8rq+aR09zEA713Y0iab+7+v7e9s9+8t7lUJmOl/u6A== X-Received: by 2002:adf:e407:: with SMTP id g7-v6mr2202176wrm.143.1527077491528; Wed, 23 May 2018 05:11:31 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id z18-v6sm22939870wrc.36.2018.05.23.05.11.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 May 2018 05:11:30 -0700 (PDT) From: luca.boccassi@gmail.com To: Shahed Shaikh Cc: dpdk stable Date: Wed, 23 May 2018 13:09:58 +0100 Message-Id: <20180523121010.8385-47-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180523121010.8385-1-luca.boccassi@gmail.com> References: <20180516101323.2234-2-luca.boccassi@gmail.com> <20180523121010.8385-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/qede: fix unicast filter routine return code' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 12:11:31 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/25/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 62089f45e0423f6207debbdcb988a1814f5d88b1 Mon Sep 17 00:00:00 2001 From: Shahed Shaikh Date: Sat, 19 May 2018 17:15:46 -0700 Subject: [PATCH] net/qede: fix unicast filter routine return code [ upstream commit f8d2581ecbba056db08888d562eafe5181a009ba ] There is no need to return failure (-EEXIST) when the requested filter is already configured. Fixes: d6cb17535f88 ("net/qede: fix VLAN filters") Fixes: 77fac1b54fc9 ("net/qede: fix filtering code") Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 14 +++++++------- drivers/net/qede/qede_fdir.c | 4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index a59efbec6..65eb33e73 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -817,10 +817,10 @@ qede_ucast_filter(struct rte_eth_dev *eth_dev, struct ecore_filter_ucast *ucast, ETHER_ADDR_LEN) == 0) && ucast->vni == tmp->vni && ucast->vlan == tmp->vlan) { - DP_ERR(edev, "Unicast MAC is already added" - " with vlan = %u, vni = %u\n", - ucast->vlan, ucast->vni); - return -EEXIST; + DP_INFO(edev, "Unicast MAC is already added" + " with vlan = %u, vni = %u\n", + ucast->vlan, ucast->vni); + return 0; } } u = rte_malloc(NULL, sizeof(struct qede_ucast_entry), @@ -1078,9 +1078,9 @@ static int qede_vlan_filter_set(struct rte_eth_dev *eth_dev, SLIST_FOREACH(tmp, &qdev->vlan_list_head, list) { if (tmp->vid == vlan_id) { - DP_ERR(edev, "VLAN %u already configured\n", - vlan_id); - return -EEXIST; + DP_INFO(edev, "VLAN %u already configured\n", + vlan_id); + return 0; } } diff --git a/drivers/net/qede/qede_fdir.c b/drivers/net/qede/qede_fdir.c index da6364ee5..153ef9640 100644 --- a/drivers/net/qede/qede_fdir.c +++ b/drivers/net/qede/qede_fdir.c @@ -141,8 +141,8 @@ qede_config_cmn_fdir_filter(struct rte_eth_dev *eth_dev, if (add) { SLIST_FOREACH(tmp, &qdev->fdir_info.fdir_list_head, list) { if (memcmp(tmp->mz->addr, pkt, pkt_len) == 0) { - DP_ERR(edev, "flowdir filter exist\n"); - rc = -EEXIST; + DP_INFO(edev, "flowdir filter exist\n"); + rc = 0; goto err2; } } -- 2.14.2