From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 10B3A2BE1 for ; Wed, 23 May 2018 14:10:25 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id l41-v6so830332wre.7 for ; Wed, 23 May 2018 05:10:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=v/Zsmp0DetVP9OBwvU2cXi7Hy/zEq4bmRkyetJ7mGWs=; b=lFK3yAZ3gGt/81bdUUCoVnbPdQDphywb/5r6Zcp9ePqr2fw71SpETXYStF+RpYfxSg +LM5L4ebeX0KOzo4wXGzuoWMXfZJZbQKUkagjbfw9/ewiCvX1vrdPOYe2z01izDlzPnM cCCqv9FAQFkP4D3t329m4dvN7Eg3BWqRe2Ade+5K3mceV0e7nfjiuL6YA9avBQ+gURDQ Ws5gg/yOQ8ku/j5urNkErAQ5S52cWqpAUijg8kFWZUJuC9cw8g065d3iXYBPlHfmJpRD 5vuSK2KoEhIb05YoQ2j/lq/iTSPDtQrKjKCOGsxqWsCnE/d9HNeJFTwPU/U+EHMAQEkl Wn7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=v/Zsmp0DetVP9OBwvU2cXi7Hy/zEq4bmRkyetJ7mGWs=; b=nuQpv6nnd5LPE6RnvKSSkKB1h/sVusGbdAPeg4BQ/KdzwrbQSZZDcSLIf2ryuEwKGT C/91QlTDRpl+mWEvPU6Ch+5HVZw6hIqfqJ2ylcoTAzMLAV/mua76I2kzEfqhgBk5VJza TeenpvjV40vA1o9IFtwzJDkI8lVmWDVca87rlM9mpYyCSHzCWtjHr9/tPip6G+mVB2fj J5yvu9jn0hKDDE7shRg4cy+zHLPZPYO80OPP7ZaX3/w0aQoqnwBNENzPs92C2f+fgS9n PKfEYZ81mmNy2zMfy2MjmB2j1A7W1AOD7meE3msD46lR6t21T2AkvdYNkuU9fICmX6tz pGlA== X-Gm-Message-State: ALKqPwe2CLRLb28S8ptGb/lP9tOQxbhAyb/wD/lMdC2lz1c0yeUKI2CM tjhZIvBiGLm65LLeEKAQTozL3Zw0 X-Google-Smtp-Source: AB8JxZoXgs7ZxawqmXkOljeedrUq5G9fr5tog20QCrFbeLmK7PCTRqUutdqwdp8SaKM/XIWMX/62Zg== X-Received: by 2002:adf:bc0f:: with SMTP id s15-v6mr2352995wrg.58.1527077424746; Wed, 23 May 2018 05:10:24 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id u8-v6sm1716232wmf.3.2018.05.23.05.10.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 May 2018 05:10:23 -0700 (PDT) From: luca.boccassi@gmail.com To: Wenzhuo Lu Cc: Michael Luo , Qi Zhang , dpdk stable Date: Wed, 23 May 2018 13:09:16 +0100 Message-Id: <20180523121010.8385-5-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180523121010.8385-1-luca.boccassi@gmail.com> References: <20180516101323.2234-2-luca.boccassi@gmail.com> <20180523121010.8385-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/ixgbe: fix too many interrupts' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 12:10:25 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/25/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From ef57a7afbc3a68768a4aaa815f8a434e96b88bc2 Mon Sep 17 00:00:00 2001 From: Wenzhuo Lu Date: Thu, 17 May 2018 13:34:09 +0800 Subject: [PATCH] net/ixgbe: fix too many interrupts [ upstream commit 874f79102d2a15dd50293082842006fbc06572c7 ] To support kernel VF, PBA bit is always set. But it may cause the too many interrupts issue on specific Linux kernel versions, e.g. 4.4.0-116. PF host should set the auto clean, mask and throttling as we always set the register for kernel VF. Fixes: 6b75183ac4d0 ("net/ixgbe: fix wrong PBA setting") Signed-off-by: Michael Luo Signed-off-by: Wenzhuo Lu Reviewed-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 49 +++++++++++++++++++++++----------------- 1 file changed, 28 insertions(+), 21 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index c28551322..ad8b4fcc8 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -5813,8 +5813,12 @@ ixgbe_configure_msix(struct rte_eth_dev *dev) /* won't configure msix register if no mapping is done * between intr vector and event fd + * but if misx has been enabled already, need to configure + * auto clean, auto mask and throttling. */ - if (!rte_intr_dp_is_en(intr_handle)) + gpie = IXGBE_READ_REG(hw, IXGBE_GPIE); + if (!rte_intr_dp_is_en(intr_handle) && + !(gpie & (IXGBE_GPIE_MSIX_MODE | IXGBE_GPIE_PBA_SUPPORT))) return; if (rte_intr_allow_others(intr_handle)) @@ -5838,27 +5842,30 @@ ixgbe_configure_msix(struct rte_eth_dev *dev) /* Populate the IVAR table and set the ITR values to the * corresponding register. */ - for (queue_id = 0; queue_id < dev->data->nb_rx_queues; - queue_id++) { - /* by default, 1:1 mapping */ - ixgbe_set_ivar_map(hw, 0, queue_id, vec); - intr_handle->intr_vec[queue_id] = vec; - if (vec < base + intr_handle->nb_efd - 1) - vec++; - } + if (rte_intr_dp_is_en(intr_handle)) { + for (queue_id = 0; queue_id < dev->data->nb_rx_queues; + queue_id++) { + /* by default, 1:1 mapping */ + ixgbe_set_ivar_map(hw, 0, queue_id, vec); + intr_handle->intr_vec[queue_id] = vec; + if (vec < base + intr_handle->nb_efd - 1) + vec++; + } - switch (hw->mac.type) { - case ixgbe_mac_82598EB: - ixgbe_set_ivar_map(hw, -1, IXGBE_IVAR_OTHER_CAUSES_INDEX, - IXGBE_MISC_VEC_ID); - break; - case ixgbe_mac_82599EB: - case ixgbe_mac_X540: - case ixgbe_mac_X550: - ixgbe_set_ivar_map(hw, -1, 1, IXGBE_MISC_VEC_ID); - break; - default: - break; + switch (hw->mac.type) { + case ixgbe_mac_82598EB: + ixgbe_set_ivar_map(hw, -1, + IXGBE_IVAR_OTHER_CAUSES_INDEX, + IXGBE_MISC_VEC_ID); + break; + case ixgbe_mac_82599EB: + case ixgbe_mac_X540: + case ixgbe_mac_X550: + ixgbe_set_ivar_map(hw, -1, 1, IXGBE_MISC_VEC_ID); + break; + default: + break; + } } IXGBE_WRITE_REG(hw, IXGBE_EITR(IXGBE_MISC_VEC_ID), IXGBE_MIN_INTER_INTERRUPT_INTERVAL_DEFAULT & 0xFFF); -- 2.14.2