From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id D68EF28F3 for ; Wed, 23 May 2018 14:11:42 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id l1-v6so8602303wmb.2 for ; Wed, 23 May 2018 05:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=w5KanQlr6pvcWPMbptPCvW4tR2pzPkXLcKrEiYFhJHc=; b=TI8rEz4Xvrc6uPFjK3jEVuzqjzxPPE+Z7zyq8uUKmxcaoKs0o7verDeFEy/GD+vJra 5cpmEVIRk/jMHkEcOxRCHFjKYmOxvakOzoLBWEXWLJvp6kc6ww0gf9ajP2zMpuPo38T1 Uf4r1FbZW00Er2ut+crdjxL7DMTvrvHl9kOaeBSgyzc/2Nf6cKevS2+WwASOeR0IjTZB DEat4XI4UhtbZZ0J8YRUY72DVZc36BZRINEXemXCauTFqjEDu6M6Uz+LKJ4I9DPGYwvP f8Yyqg2sSigXbMwuNtOJ0ZVho0Bjjl5E4mdBT5MEb5fmKFBj0q3YNv5X9xKRxcBd2gSM WWHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=w5KanQlr6pvcWPMbptPCvW4tR2pzPkXLcKrEiYFhJHc=; b=PtQSVlHqiAF+DyFtWLRShC7AiuCY5wZEZ4/+Rhj2+dtCTogN4DoFPsYSsPoC3srry4 0uJanVLuHMaqLVvxVhAXO/YD8MSldg1QNMbmwiXvcQ8iDSCeMEX+TUBFkEJGrHd50V5f 5cd5jA+l/VT4e+5FkS7djAWGZtbrz/nkt5E/s/8R/W2qPaSiAigzLkjYbZC+1bwkyrOt nrwG/taMOKiPVOwzMVmJjHa8kHy5JZjNANgJs4jJMMdg1rITy7vBDtT9ctboW8Y+xV6A geYdADpIdUa0kdCykNUAyE3yWJ9qrqOV3uzo5CSRd6oOM5RLpHsiFH/aXMjqVv8lNR6Z nSjA== X-Gm-Message-State: ALKqPwe+rsdpIVjG4gIieiaK1holC6o6bcGJkCgqKzP4YrUu7SbvVDEY O7oXLUxL09/8D+zxWYFQtBk= X-Google-Smtp-Source: AB8JxZqy+go/cXMHU58mCouPLkYqoTfWjB2hyrFB7RVd7+oZz1M5mD3Lsq8bFEkVNM/zuC5uPyOH/w== X-Received: by 2002:a1c:1047:: with SMTP id 68-v6mr4035483wmq.132.1527077502563; Wed, 23 May 2018 05:11:42 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id u35-v6sm27174070wrc.29.2018.05.23.05.11.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 May 2018 05:11:41 -0700 (PDT) From: luca.boccassi@gmail.com To: Matan Azrad Cc: Gaetan Rivet , dpdk stable Date: Wed, 23 May 2018 13:10:05 +0100 Message-Id: <20180523121010.8385-54-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180523121010.8385-1-luca.boccassi@gmail.com> References: <20180516101323.2234-2-luca.boccassi@gmail.com> <20180523121010.8385-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/failsafe: fix duplicate event registration' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 12:11:43 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/25/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From e43d7b2b401b39ad50035fe76997ccb9630d34d3 Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Tue, 22 May 2018 12:38:47 +0000 Subject: [PATCH] net/failsafe: fix duplicate event registration [ upstream commit 602c5623c8a884036aa81712f89542159a243a58 ] When the fail-safe device is reconfigured, it attempts to register again for the sub-devices LSC and RMV events. Prevent an event registration if it is already done. Fixes: 598fb8aec6f6 ("net/failsafe: support device removal") Signed-off-by: Matan Azrad Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c index 2f9f60b16..d9fc480f9 100644 --- a/drivers/net/failsafe/failsafe_ops.c +++ b/drivers/net/failsafe/failsafe_ops.c @@ -145,7 +145,7 @@ fs_dev_configure(struct rte_eth_dev *dev) fs_unlock(dev, 0); return ret; } - if (rmv_interrupt) { + if (rmv_interrupt && sdev->rmv_callback == 0) { ret = rte_eth_dev_callback_register(PORT_ID(sdev), RTE_ETH_EVENT_INTR_RMV, failsafe_eth_rmv_event_callback, @@ -157,7 +157,7 @@ fs_dev_configure(struct rte_eth_dev *dev) sdev->rmv_callback = 1; } dev->data->dev_conf.intr_conf.rmv = 0; - if (lsc_interrupt) { + if (lsc_interrupt && sdev->lsc_callback == 0) { ret = rte_eth_dev_callback_register(PORT_ID(sdev), RTE_ETH_EVENT_INTR_LSC, failsafe_eth_lsc_event_callback, -- 2.14.2