From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id C528A2C6A for ; Wed, 23 May 2018 16:34:10 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id a67-v6so9580894wmf.3 for ; Wed, 23 May 2018 07:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sGqTkpa5CgqPsynCpbqx6doYehgj2BbzFVF3G1pW5/c=; b=eUeVYTejF3TUnZzMw1FI654ldWO7LvGQIy5we7WslrhMZk7b4/bmlfeV49nY8QR61r r9i7/+liDixebmXxhbmwXiE46tZK/zAGE8/pC2TwDsrZaDtlt0BXT2RZFelCf83ZTSnL +MnzN8ZTqS6U/ABFd6JmJn2b69+hpkBvrOwI+SabTIEqfv9FJPf0ijWLb304N2NWI+wD mMbdZi9/hl8UCxf8GW5IoYy6xy38o49nWO6HMtnR/bWL4jA17r1fsfjfW2Y1sZhvXkXe P8fshSsNfNsGefa50s12u1oA5ZaXVu3mFaYnfW6iesRa6zjWkbFptbj5HOECsyaV3GyW 0XNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sGqTkpa5CgqPsynCpbqx6doYehgj2BbzFVF3G1pW5/c=; b=feWU63sPxionJeKbPmGGFBPbTUFbXrpxUm4FK3UgKmAkoXGbE4SFmI6rkJIqO4/Bkv LuVpuOTp3d36EutnvKk4RYwSo5C1kTY9aNrdc8bG44OaKDvLNpw0Ulh6xcpHGccWwdfI Hzcq/TNW/4xOZ1rycOnwHoa4Ppdi3z9gRfdExVQIMIfNmTZ0bT9usrlyV3ayfghoSuzX ePJfkGCohgkJXA7vyhjoPxthj4nlynxJl7wcus5ErYny9EB22v/idcPdZ8/OZUN9VNnM Gk1mxJ8BKaLbPLw3A116WdyO4RszLSMc6Q8zCIMC4rbzdSMTL1lFxOaOjYYTWALkSBHL p2gA== X-Gm-Message-State: ALKqPwe5xJ7xCxdwZdaAzByyWf5JX/S1RK9mpqrn7inDIzl34MRmwNRC lIHwvXhigqkzBlHcIVrfvFo= X-Google-Smtp-Source: AB8JxZqQz6EGJxm/KDpfE+yVgy9bUaCuzIrk2vbkKPnxqZgZdvAbvxvZ2K7pnoAnICxtCWSonevXQQ== X-Received: by 2002:a1c:91c4:: with SMTP id t187-v6mr4083740wmd.19.1527086050459; Wed, 23 May 2018 07:34:10 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id p189-v6sm2271649wmg.18.2018.05.23.07.34.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 May 2018 07:34:09 -0700 (PDT) From: luca.boccassi@gmail.com To: Daniel Shelepov Cc: Bernard Iremonger , dpdk stable Date: Wed, 23 May 2018 15:33:33 +0100 Message-Id: <20180523143344.16885-12-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180523143344.16885-1-luca.boccassi@gmail.com> References: <20180516100945.4449-2-luca.boccassi@gmail.com> <20180523143344.16885-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'app/testpmd: fix burst stats reporting' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 14:34:10 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/25/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 5dc113c7fba96eb070311a871b4b6388a4ae2d5c Mon Sep 17 00:00:00 2001 From: Daniel Shelepov Date: Mon, 14 May 2018 21:12:15 +0000 Subject: [PATCH] app/testpmd: fix burst stats reporting [ upstream commit fe613657ce486083a3ed96890c95de4f35c8593b ] When RTE_TEST_PMD_RECORD_BURST_STATS is enabled, testpmd collects burst statistics and includes them in the port stats report. The summary should include top 2 most frequent burst sizes, but there is a bug in finding the top-2. During the scan of burst size counts, the top-2 can change only if top-1 also changes. Added logic to update the top-2 if current burst size is larger than existing top-2, but smaller than existing top-1. Fixes: af75078fece3 ("first public release") Signed-off-by: Daniel Shelepov Acked-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 765afef9a..4512ba92d 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -725,6 +725,9 @@ pkt_burst_stats_display(const char *rx_tx, struct pkt_burst_stats *pbs) pktnb_stats[1] = pktnb_stats[0]; burst_stats[0] = nb_burst; pktnb_stats[0] = nb_pkt; + } else if (nb_burst > burst_stats[1]) { + burst_stats[1] = nb_burst; + pktnb_stats[1] = nb_pkt; } } if (total_burst == 0) -- 2.14.2