From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 819682C8 for ; Wed, 23 May 2018 16:34:27 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id f6-v6so9638071wmc.4 for ; Wed, 23 May 2018 07:34:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PDYMonw57tzJu3y4ok7puGNWwKEuvqlwbnrF8mdciKU=; b=TlyNC6tVn0bqxdL6kv2e6KQdMyV7hFbtpUo+avsNcLo1XeucAsAmHO8rvV81d/IvCa F0UcrOXHPHUbC/lSbe4DCgvNhf/lLXCeplBIaUNbyOIiZ/qeu4bJ2+Q8myaGcob8ulOR xO5UhBlU10OwL7yHYJlwkGCwzRpikXmCQvc0vmxoRG9dJTuoRx8sBDuYnqUxLwQhw55m 5kNJkVCDNoeoZ+UQfUVGDNtENv/1MVtl0TiT0Ok2dI3WylGREDFAU/7oQNG2YPEugzt7 2dK7mMeArlUWBi1YjGETAcPGC++J0UlOazqbP2CsRMjINXspM9yRm+Hzq2dNLRLyUltZ ILWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PDYMonw57tzJu3y4ok7puGNWwKEuvqlwbnrF8mdciKU=; b=jFiMxWiwqTkb5pjXgfFBnAM270b8QIM+tMf0BKf05Nzod9nBbpJrZ41wlGImnHttPv Y07hRapXKbgSOkL33CZcEw2UgfX+Z7pQgIIvMzB8y1Q9VJL3Z6ox5Cuc3hlw1ejaJGwY 9w4Sd4+IlWRC7SdRdkV+c+8uSPy3zCab0lb6KZNkPPyzyE72vstj3Cz16lPVyCV9Z6Ns 85ccMeKcn5FOAur8UfhKxVNJpQdtMiucmVnPFuFjkgAIfyjnweN9I+yCpzAjn+695T6a K7uXTGUDdzTs1WvvMF+FGAZdqbcdiPWeMARaITxhwLdjZeKjBK/uxhRBk/BlqD95dsEa FOzQ== X-Gm-Message-State: ALKqPwcE0pxaQO+XGaVi+e9z2ryggwWtMWkcy8nR1RoOnKOqKIiTVRfa N3sf3DJXKjc+8zAA1SSkV60= X-Google-Smtp-Source: AB8JxZoESoPRC+br/4Oi0RX1Jx5I5pdKDiyVhRlMX5HL+P0Qwi3HToIDHK2RAGvet8XM9PfQdxVOzw== X-Received: by 2002:a1c:9186:: with SMTP id t128-v6mr4983115wmd.41.1527086067245; Wed, 23 May 2018 07:34:27 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id b123-v6sm2170876wme.22.2018.05.23.07.34.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 May 2018 07:34:26 -0700 (PDT) From: luca.boccassi@gmail.com To: Ajit Khaparde Cc: dpdk stable Date: Wed, 23 May 2018 15:33:44 +0100 Message-Id: <20180523143344.16885-23-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180523143344.16885-1-luca.boccassi@gmail.com> References: <20180516100945.4449-2-luca.boccassi@gmail.com> <20180523143344.16885-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/bnxt: fix Rx checksum flags' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 14:34:27 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/25/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 0b1de008cbcbafbbdf27593743ca0518f90b18ae Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Tue, 22 May 2018 11:13:47 -0700 Subject: [PATCH] net/bnxt: fix Rx checksum flags [ upstream commit 65ee636872ebd13b85bb0bebeb3cade56f94e6f1 ] For frames where the hardware is not able to calculate checksum we are indicating such frames to be bad. And that is incorrect. Indicate PKT_RX_IP_CKSUM_UNKNOWN or PKT_RX_L4_CKSUM_UNKNOWN for such frames. Fixes: 7ec39d8c524b ("net/bnxt: update status of Rx IP/L4 CKSUM") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 4 ++++ drivers/net/bnxt/bnxt_rxr.h | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index 71f314245..ccf8196a1 100644 --- a/drivers/net/bnxt/bnxt_rxr.c +++ b/drivers/net/bnxt/bnxt_rxr.c @@ -153,11 +153,15 @@ static uint16_t bnxt_rx_pkt(struct rte_mbuf **rx_pkt, if (likely(RX_CMP_IP_CS_OK(rxcmp1))) mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD; + else if (likely(RX_CMP_IP_CS_UNKNOWN(rxcmp1))) + mbuf->ol_flags |= PKT_RX_IP_CKSUM_UNKNOWN; else mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD; if (likely(RX_CMP_L4_CS_OK(rxcmp1))) mbuf->ol_flags |= PKT_RX_L4_CKSUM_GOOD; + else if (likely(RX_CMP_L4_CS_UNKNOWN(rxcmp1))) + mbuf->ol_flags |= PKT_RX_L4_CKSUM_UNKNOWN; else mbuf->ol_flags |= PKT_RX_L4_CKSUM_BAD; diff --git a/drivers/net/bnxt/bnxt_rxr.h b/drivers/net/bnxt/bnxt_rxr.h index 40c9df440..ec2832b57 100644 --- a/drivers/net/bnxt/bnxt_rxr.h +++ b/drivers/net/bnxt/bnxt_rxr.h @@ -49,6 +49,9 @@ (((rxcmp1)->flags2 & RX_CMP_L4_CS_BITS) && \ !((rxcmp1)->errors_v2 & RX_CMP_L4_CS_ERR_BITS)) +#define RX_CMP_L4_CS_UNKNOWN(rxcmp1) \ + !((rxcmp1)->flags2 & RX_CMP_L4_CS_BITS) + #define RX_CMP_IP_CS_ERR_BITS \ rte_cpu_to_le_32(RX_PKT_CMPL_ERRORS_IP_CS_ERROR | \ RX_PKT_CMPL_ERRORS_T_IP_CS_ERROR) @@ -61,6 +64,9 @@ (((rxcmp1)->flags2 & RX_CMP_IP_CS_BITS) && \ !((rxcmp1)->errors_v2 & RX_CMP_IP_CS_ERR_BITS)) +#define RX_CMP_IP_CS_UNKNOWN(rxcmp1) \ + !((rxcmp1)->flags2 & RX_CMP_IP_CS_BITS) + struct bnxt_sw_rx_bd { struct rte_mbuf *mbuf; /* data associated with RX descriptor */ }; -- 2.14.2