From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 491CC2BF4 for ; Wed, 23 May 2018 16:33:56 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id a67-v6so9578519wmf.3 for ; Wed, 23 May 2018 07:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lAm3rhJF/BGSNzmbq6oNoxuS8zUR2xlP1eAjfxLZcf0=; b=KdJlPwRtBQWNSmkV984j/PwOQwgCKjrjzSly/l/ozHY4A8fSK8ipfugQRUlji3+Ahk QuqHcOBqoyV3/Hj235T696nCWCeLgDwnP7RDaRcqVIk1+brKBkDAswr1nPScpUYQ2ppW X5H86QeaRLZmIFWcaZDpQlDygR39nGnpbM7GH3Qq3gD351pxftPvKXdMozVR49dsGsSY 7cXSolkFgr58jcLcAMlnP55cs1bhXP22dXpaWujVjU1ldaCHVKOW4y59NJ7g2eMhJOKC XvrFJTzU61fg5/DE1foel6yEGH6jMxAok3wAiR6R6N1HLAR0cu3q6O+aL2uq0pnvM9ge Dy0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lAm3rhJF/BGSNzmbq6oNoxuS8zUR2xlP1eAjfxLZcf0=; b=SePlaYbxUCKCoWMdo38I3xW5wPOLysWDDSQnfZRBgRt4Zt2ChrzExvjdeyeLmFqu0W TK+22tmEHcCHW3hWmCL5pQgTkjQhegZ2OVvPC6nzf09aSSu2yRgwaVzf1AOmAlo8D055 DMUgCN6QzNE6N/TE5cfoI4Z0iwSbLuESCoknsXY25Ji5d44qb9IOKPOhHUYrxfmLy2Nb HvLL3lkSpFpeicUuddb4FHO8hl2B0q+RqcFgC4tRM+qPoST/XfdW26ck02cPav8KujTe negu8cBevSFciaMOMcO54TO6hZ46L4jPivTfeRmMeblh3VXb6gtGL9+MNIMI5vKSgqQq mfww== X-Gm-Message-State: ALKqPwdwjHywMXE8kDawKjBsZvrbZB0RPQCms47oVHqplvBvELvaF/Ek uZRESRdx24Sz6iZHJcHmuklLbYfznms= X-Google-Smtp-Source: AB8JxZqTEi1XqYWPy0V/TimA7GCTbXA7apqlaemqJH/7ItYWnMrmiGSsBYdlFDiQIG7izLJo+HBRRg== X-Received: by 2002:a1c:d53:: with SMTP id 80-v6mr4939960wmn.138.1527086035922; Wed, 23 May 2018 07:33:55 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id k28-v6sm23135755wrk.46.2018.05.23.07.33.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 May 2018 07:33:54 -0700 (PDT) From: luca.boccassi@gmail.com To: Andy Green Cc: Bruce Richardson , dpdk stable Date: Wed, 23 May 2018 15:33:24 +0100 Message-Id: <20180523143344.16885-3-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180523143344.16885-1-luca.boccassi@gmail.com> References: <20180516100945.4449-2-luca.boccassi@gmail.com> <20180523143344.16885-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'eal: fix casts in random functions' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 14:33:56 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/25/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From c29efdd157a17d0ef2725cb07abec7189659694d Mon Sep 17 00:00:00 2001 From: Andy Green Date: Thu, 17 May 2018 21:49:12 +0800 Subject: [PATCH] eal: fix casts in random functions [ upstream commit d3db77d7d88e1f9227c2847f3355fc3e4bd256e8 ] GCC 8.1 warns: In function 'rte_srand': rte_random.h:34:10: warning: conversion to 'long int' from 'long unsigned int' may change the sign of the result [-Wsign-conversion] srand48((long unsigned int)seedval); rte_random.h:51:8: warning: conversion to 'uint64_t' {aka 'long unsigned int'} from 'long int' may change the sign of the result [-Wsign-conversion] val = lrand48(); ^~~~~~~ rte_random.h:53:6: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion] val += lrand48(); Fixes: af75078fece3 ("first public release") Signed-off-by: Andy Green Acked-by: Bruce Richardson --- lib/librte_eal/common/include/rte_random.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/include/rte_random.h b/lib/librte_eal/common/include/rte_random.h index 24ae83632..9f0e5e16e 100644 --- a/lib/librte_eal/common/include/rte_random.h +++ b/lib/librte_eal/common/include/rte_random.h @@ -60,7 +60,7 @@ extern "C" { static inline void rte_srand(uint64_t seedval) { - srand48((long unsigned int)seedval); + srand48((long)seedval); } /** @@ -77,9 +77,9 @@ static inline uint64_t rte_rand(void) { uint64_t val; - val = lrand48(); + val = (uint64_t)lrand48(); val <<= 32; - val += lrand48(); + val += (uint64_t)lrand48(); return val; } -- 2.14.2