From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 9A45E2BF4 for ; Wed, 23 May 2018 16:33:57 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id w10-v6so4122240wrk.9 for ; Wed, 23 May 2018 07:33:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=C37vGCQQ9LJiv39eF+OfUQfNQgGHKSTHdC2s/gqRrGo=; b=jrA8wiUvCcX5LD96eww1L2A5SuQRou0UMwDtCJ2UIYgpGO0mLYQahxosTrVl40DA+6 59XESInutJ2KzXEHN/3mRD7quYH0mYMHdUTflwGC9h/IvX8kwZ8omr9TvfWBEzIJaVbI tn/9g/CV0+wKCqsQln4QeR1aCejqxtrMCqZkdXDFB9dsD5S4Tx1+jO2QomvUSIdEiC/O RxU7oJZD8DdhzAaGGqIcMIlvZu3xLMmMoNeLyk7gX2EE2OcGxZuHVsVkpWTr/lah1/Bp j5WAx/oFY5iIlZEDV9x/UNPvXB+bSm8qn4yAurNAnPZlLbF5whpiikbB7Ip1wc41Un5R DUYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=C37vGCQQ9LJiv39eF+OfUQfNQgGHKSTHdC2s/gqRrGo=; b=h2olGwO4VWwgUB041uLVdKpQh1gqtHG6w1CfUqkMrUmrxhVsHFY/W8lPv32bsJ1kAG UAKRt5dof3bgPkIQta6ZURa5w591KL92CX7vfCY0a1cZr2P8u6lPaabKVRewUZ1GT3qS MyN9RWwADpInupNIHuKkJ7pPvU8+USJzDrgnSFsYGxhLIsx+hZm/jA1KJMSAH8cbpPxn BM3z2r0EH+2+mit4bF9IEhSGDInLBbXabtKyTPHARUufZIfcXmH15MnRSqgsGjm2tvKk rL8K1CqL2FVBwfs5Hetasvqy6jJw39kYVQbslo8xMGx6tsO1eN5r+CgMmix+pqi2urJw K6qQ== X-Gm-Message-State: ALKqPwfRX9n6E+ISa8JXGxOWlB7N+GXWQZWoDm4NVpMwNplW1Gf/jwtp jqd6qxJuAFkzlQ9pVRsL8Dc= X-Google-Smtp-Source: AB8JxZrrv+uElZMbVrAv24GcLivaKZhYYywDyitVBYzqHg6Y33dR5PI2nMMWWPZWmb+vjxXgQTAcUA== X-Received: by 2002:adf:b807:: with SMTP id h7-v6mr2609740wrf.113.1527086037328; Wed, 23 May 2018 07:33:57 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id z7-v6sm23431703wrg.56.2018.05.23.07.33.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 May 2018 07:33:56 -0700 (PDT) From: luca.boccassi@gmail.com To: Andy Green Cc: Olivier Matz , dpdk stable Date: Wed, 23 May 2018 15:33:25 +0100 Message-Id: <20180523143344.16885-4-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180523143344.16885-1-luca.boccassi@gmail.com> References: <20180516100945.4449-2-luca.boccassi@gmail.com> <20180523143344.16885-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'mbuf: fix reference counter integer promotion' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 14:33:57 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/25/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From c0e0b36abbcacee75799e7c02f50e7b71edce827 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Thu, 17 May 2018 21:49:27 +0800 Subject: [PATCH] mbuf: fix reference counter integer promotion [ upstream commit ee07d519ceb05e59dd970c48a42cf2f09b3ac4dc ] GCC 8.1 warned: "1 + value", where value is an uint16_t causes promotion to a signed int. The compiler complained that we are shoving an int into a uint16_t return type with different size and sign. Bumping and returning value directly instead removes the promotion and the problem. Fixes: f20b50b946da ("mbuf: optimize refcnt update") Fixes: a53aa2b9f3be ("mbuf: support attaching external buffer") Signed-off-by: Andy Green Acked-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index b6a01c992..07caef69b 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -668,8 +668,9 @@ rte_mbuf_refcnt_update(struct rte_mbuf *m, int16_t value) * reference counter can occur. */ if (likely(rte_mbuf_refcnt_read(m) == 1)) { - rte_mbuf_refcnt_set(m, 1 + value); - return 1 + value; + ++value; + rte_mbuf_refcnt_set(m, value); + return value; } return (uint16_t)(rte_atomic16_add_return(&m->refcnt_atomic, value)); -- 2.14.2