From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 1D0FE2BBD for ; Wed, 23 May 2018 16:33:59 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id x12-v6so22181737wmc.0 for ; Wed, 23 May 2018 07:33:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tev1c4JslWCI8lAbLPAww0n1mY3gMWY869AUdfYonNY=; b=bYGpTlu7VzaLVlPKPV4UvU8t4F8gnWklD+WZ+iJu+6Z2nL1Y7TNmidI9n4lA3lee5P Xg+MhbSovTObP2V8Mg+YbqO07uFeYgAGIHRiI4/nMDVQ5GKwuUHL0r8c4X+MbJE/gqQp 7gtapV++DPhumBOnCAFfyb/ZMdk8jvBbu68JLHPsHh404t4IkFYjZHbswRgeSmHnUvKQ Edtib7VcPTrhO5mjebkQPsJcrcDdGy67ys1879xa3nPLBkCDlzJLPUTBw4UCwmEJuLCj 66fqiuuRvEpHVHLlilBwYU6bUPxM732n50ukzfSUIPmBUVBQKVw9U8VlKvcfdJzzGnoe oeDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tev1c4JslWCI8lAbLPAww0n1mY3gMWY869AUdfYonNY=; b=jeH4187tFtbiyLBd9LyADqLqCm9lNOZX8dij6aonCQ0nEgsAkMm5o6pYJad0pf7h8K fv1DikV5HnwoSmRbqQmM6otPOs/TRRrMvuT7b4KuB1yoXELDet+CdWUE0c/tvcCVTYZT GARCXiGkjjlAUEzIqaUUCMt8KXe4E4zIVHCpiqMJZQh/doeigRjrtx+VhRKaUPRCcZ8n hVC8r4low4dLEu63f29Gi+GLKDZDlY51T5oJaMngd3waAVLZC++gfJlTXNvlmzN73MkU +ekisaPwqPywT7lE0FLBLC0MOKm6FGZ8k/nBPU+oCfUB7qbbXZqWnmEZ157wZUaRLR2o CizQ== X-Gm-Message-State: ALKqPwdKSXfXMZTEICtOne9ERhXC88hE8APO3UJZQW1W8fxceVEnknyk YETtpZVztKekG/sBvpU8NV4= X-Google-Smtp-Source: AB8JxZphKw2z8mY1QWdN0yvvqlARUOfrOueMG6hIeGHc68DZs+aEWcaWDC2tq4J9G5mgrkE2+V3dUg== X-Received: by 2002:a1c:ac8a:: with SMTP id v132-v6mr4066701wme.105.1527086038776; Wed, 23 May 2018 07:33:58 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id j76-v6sm7719161wmf.33.2018.05.23.07.33.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 May 2018 07:33:57 -0700 (PDT) From: luca.boccassi@gmail.com To: Andy Green Cc: Olivier Matz , dpdk stable Date: Wed, 23 May 2018 15:33:26 +0100 Message-Id: <20180523143344.16885-5-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180523143344.16885-1-luca.boccassi@gmail.com> References: <20180516100945.4449-2-luca.boccassi@gmail.com> <20180523143344.16885-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'mbuf: explicit casts of reference counter' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 14:33:59 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/25/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From cdf7b544d3755cb9908fa76c6ef11a8739413e29 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Thu, 17 May 2018 21:49:32 +0800 Subject: [PATCH] mbuf: explicit casts of reference counter [ upstream commit f6ffdf1c2c1cfbb2a3cbce246b545560609abeb5 ] differences to the atomic16 are signed, but the atomic16 itself is unsigned. It needs to be made explicit with casts. Fixes: af75078fece3 ("first public release") Fixes: a53aa2b9f3be ("mbuf: support attaching external buffer") Signed-off-by: Andy Green Acked-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 07caef69b..1d88ad8d1 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -645,7 +645,7 @@ rte_mbuf_refcnt_read(const struct rte_mbuf *m) static inline void rte_mbuf_refcnt_set(struct rte_mbuf *m, uint16_t new_value) { - rte_atomic16_set(&m->refcnt_atomic, new_value); + rte_atomic16_set(&m->refcnt_atomic, (int16_t)new_value); } /** @@ -669,8 +669,8 @@ rte_mbuf_refcnt_update(struct rte_mbuf *m, int16_t value) */ if (likely(rte_mbuf_refcnt_read(m) == 1)) { ++value; - rte_mbuf_refcnt_set(m, value); - return value; + rte_mbuf_refcnt_set(m, (uint16_t)value); + return (uint16_t)value; } return (uint16_t)(rte_atomic16_add_return(&m->refcnt_atomic, value)); -- 2.14.2