From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id AABDE2C5E for ; Wed, 23 May 2018 16:34:05 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id y15-v6so26921312wrg.11 for ; Wed, 23 May 2018 07:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Q9nTUrCrFBN9yTPQvuhCOuI35tT5fEdN3C6HAD3Aozw=; b=luPezGV23Gno4mX0zLb5fMxYPOKaF8zkin+qGXvT34SwbLnY0rUunMyOInDI5+9V2x QaQGt77OUcGPb6vj1zc/qsuLqlgB/LE6h1l880b+qvToj/qLX7Ghy9YqWKHguicKjnWR ja+PlLzLz3NHT1CQ2vmaY2sYFCC4bLem87t82Bz63QQL2udxVOOEnTpXwOtOjQYCva9W GaaUSSIJ65aYLX1Fd8Bc/QbGg66YTZl1aFJ5DEVAwh1rraq5hu0gPCgVnWqGb4a2CfVq 8mcDA2hxzqUTvhQ7vB66zAPbRD25W0wVNm4ihKpoHFZ6lJF+jjYhl8V9PCAhoZQCn1Aq otYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Q9nTUrCrFBN9yTPQvuhCOuI35tT5fEdN3C6HAD3Aozw=; b=jXUKi9cRF5YN9iD0J9G5PtJbzp5Rg5mHPgh7+85OtbNNnTKTnVp/kZRG/40yelsvxt jiLTKInsuIHTVRoNi9sESonIFUzd8Os7LtLIgs+pWUbzVeU0QYfg1x3/0rtA3KP+VET1 bQ0SIyHg/q/2BMq0dIPLc0E/mdHNzgKYagz26CglbqxujeoODmSXmK5dydypvIQ5Ry7C fyQTWHP2BoPMxyowqoVvcKSRIDfFoWY8AsGccBb/VUJXNq/Rp3eZYve02zjC+6m2zNx+ mxcinjwBDs2lAcYcJGqsOGVy0BFOHVZOgLTw2p8WZzDkLE3j6M4X4ULBzzX847/9fm1A APBg== X-Gm-Message-State: ALKqPweBsDPjmOtKG9xeC5P2y1Sm+XW9vWLo4TCIl1VAqFcoX1HdaWJR S9icePUsVQ1V0p7UmFpEiJ8= X-Google-Smtp-Source: AB8JxZqUv6aqIKYfQLyDnRueORAuPIlAnQkENZ1mPZy+5MvAekjo0qifgCDCKbVP8dteVPLA5VYB0Q== X-Received: by 2002:adf:9502:: with SMTP id 2-v6mr2501706wrs.241.1527086045393; Wed, 23 May 2018 07:34:05 -0700 (PDT) Received: from localhost ([2a00:23c5:be9a:5200:ce4c:82c0:d567:ecbb]) by smtp.gmail.com with ESMTPSA id c21-v6sm22549570wre.81.2018.05.23.07.34.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 May 2018 07:34:04 -0700 (PDT) From: luca.boccassi@gmail.com To: Andy Green Cc: dpdk stable Date: Wed, 23 May 2018 15:33:30 +0100 Message-Id: <20180523143344.16885-9-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180523143344.16885-1-luca.boccassi@gmail.com> References: <20180516100945.4449-2-luca.boccassi@gmail.com> <20180523143344.16885-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net: explicit cast of IP checksum to 16-bit' has been queued to LTS release 16.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 14:34:05 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/25/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 399c501705df7ed2f6d9b81784be01300c2abcb2 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Thu, 17 May 2018 21:49:57 +0800 Subject: [PATCH] net: explicit cast of IP checksum to 16-bit [ upstream commit 466de6d5d8648f6a2c6cfc90c2d1bf217dd06e90 ] GCC 8.1 warned: In function 'rte_raw_cksum_mbuf': rte_ip.h:225:22: warning: conversion from 'uint32_t' {aka 'unsigned int'} to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion] tmp = rte_bswap16(tmp); ^~~ In function 'rte_ipv4_cksum': rte_ip.h:256:35: warning: conversion from 'int' to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion] return (cksum == 0xffff) ? cksum : ~cksum; ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ rte_ip.h:332:9: warning: conversion from 'uint32_t' {aka 'unsigned int'} to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion] return cksum; ^~~~~ In function 'rte_ipv6_udptcp_cksum': rte_ip.h:421:9: warning: conversion from 'uint32_t' {aka 'unsigned int'} to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion] return cksum; ^~~~~ Fixes: 6006818cfb26 ("net: new checksum functions") Fixes: 4199fdea60c3 ("mbuf: generic support for TCP segmentation offload") Signed-off-by: Andy Green --- lib/librte_net/rte_ip.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h index 4491b86e2..2e060ba46 100644 --- a/lib/librte_net/rte_ip.h +++ b/lib/librte_net/rte_ip.h @@ -284,7 +284,7 @@ rte_raw_cksum_mbuf(const struct rte_mbuf *m, uint32_t off, uint32_t len, for (;;) { tmp = __rte_raw_cksum(buf, seglen, 0); if (done & 1) - tmp = rte_bswap16(tmp); + tmp = rte_bswap16((uint16_t)tmp); sum += tmp; done += seglen; if (done == len) @@ -315,7 +315,7 @@ rte_ipv4_cksum(const struct ipv4_hdr *ipv4_hdr) { uint16_t cksum; cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct ipv4_hdr)); - return (cksum == 0xffff) ? cksum : ~cksum; + return (cksum == 0xffff) ? cksum : (uint16_t)~cksum; } /** @@ -391,7 +391,7 @@ rte_ipv4_udptcp_cksum(const struct ipv4_hdr *ipv4_hdr, const void *l4_hdr) if (cksum == 0) cksum = 0xffff; - return cksum; + return (uint16_t)cksum; } /** @@ -474,7 +474,7 @@ rte_ipv6_udptcp_cksum(const struct ipv6_hdr *ipv6_hdr, const void *l4_hdr) if (cksum == 0) cksum = 0xffff; - return cksum; + return (uint16_t)cksum; } #ifdef __cplusplus -- 2.14.2