From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 81205DE0 for ; Tue, 29 May 2018 12:25:59 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id o78-v6so39180716wmg.0 for ; Tue, 29 May 2018 03:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2Qouv07x5adE0xLJHF/n/i8CSjJG7MMjXJkgRhh1AH4=; b=q8113QNAsQ+oPQAYjHv//66BOfMWtEc4bxy9QQX4jxmiWiEmYH7P/GUodzPeYhSW2s HiEIdYbvZStwQZHkzqTHS2CPXtmYZbn0N9J2ABzgnvUsRtze1yDYInfAhN/ZPGeNYKUG 42uScwVfQIdnib2/N5QKzLcC+1yZLwcd1ym6qVyqFKLugep3745R2Z5Zy4gde2kYOW2d tijnj2yaQUPK/KlTcnJuU8XhQxNxgyW56yx4Bxu01YDKSz8qgCd2MB2BWoeOkS2IjAni w5GhrRk4RqB2niHSVDG9Mmj5u5Gv6c2oQZrFakTjQo7S8TnIVQlyQi3JheZlsXu+wFBn jigA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2Qouv07x5adE0xLJHF/n/i8CSjJG7MMjXJkgRhh1AH4=; b=Rg0YrQXOJRO0V5gbPIcoGH78Qa0pdp5nSN2ymAEZqtSh328TcvEErz9jyzamR/ElOH IwYug5ZvNuI8vmfjIjHBJ+6F4cgDyVUsxnPyFir6+sx7URUSSvyyXr8p5/tEjsQbVNBQ YfBDUgX0i5rhEuwK3eWnjXoEQaG2c20mbsE00Sh+3p1nxsuFjz66pWyPMRdQXnNt806O hsQ54jT7Irdk1/hfgcpvFDoTDU6dyQTWbZmTIAyyi8ajaoffgimpunBQgXvia/xtYlZn b/RFzwtIpZ0NCw5aBG5QnPxAObveccDnGYLSLMYmDTRAkbgl836YjWzf8yurclYs+L11 USTg== X-Gm-Message-State: ALKqPweESGwdVftVpHqYqI5LF7ud/XYs8tJNhFCYryhfM6PCZxnYF8oc mXFlZdrYuKq9EwWI+1CJ54Q= X-Google-Smtp-Source: ADUXVKIYsTyInUI7l9YbfzColON8RGcUyazTCs96+o2ybzF66aMdcYRVCdXmj6D8WEWgwdKpIpcYWw== X-Received: by 2002:a1c:e006:: with SMTP id x6-v6mr10060945wmg.80.1527589559221; Tue, 29 May 2018 03:25:59 -0700 (PDT) Received: from localhost ([32.112.155.38]) by smtp.gmail.com with ESMTPSA id m35-v6sm34083934wrm.51.2018.05.29.03.25.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 May 2018 03:25:58 -0700 (PDT) From: luca.boccassi@gmail.com To: Shahed Shaikh Cc: dpdk stable Date: Tue, 29 May 2018 11:25:49 +0100 Message-Id: <20180529102553.23431-1-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180523121010.8385-59-luca.boccassi@gmail.com> References: <20180523121010.8385-59-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/qede: fix slow path completion timeout' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 May 2018 10:25:59 -0000 Hi, FYI, your patch has been queued to stable release 18.02.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/31/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From e6d531b7aef43ffc4e5331d822d94ddf073172e6 Mon Sep 17 00:00:00 2001 From: Shahed Shaikh Date: Wed, 23 May 2018 11:48:53 -0700 Subject: [PATCH] net/qede: fix slow path completion timeout [ upstream commit 0833120f20f0aeae8496d39bddaad0c1a70b0bfc ] In 100G mode, we poll firmware slow path completion for every 1 second, which is not enough and may result in completion timeout if driver misses that window. Patch "eal: set affinity for control threads" exposed this issue since alarm callback runs in control thread context. Fix this issue by update polling period to 100ms. Fixes: d651ee4919cd ("eal: set affinity for control threads") Fixes: 2af14ca79c0a ("net/qede: support 100G") Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 65eb33e73..6dfff07e2 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -16,7 +16,7 @@ int qede_logtype_init; int qede_logtype_driver; static const struct qed_eth_ops *qed_ops; -static int64_t timer_period = 1; +#define QEDE_SP_TIMER_PERIOD 10000 /* 100ms */ /* VXLAN tunnel classification mapping */ const struct _qede_udp_tunn_types { @@ -1649,7 +1649,7 @@ static void qede_poll_sp_sb_cb(void *param) qede_interrupt_action(ECORE_LEADING_HWFN(edev)); qede_interrupt_action(&edev->hwfns[1]); - rc = rte_eal_alarm_set(timer_period * US_PER_S, + rc = rte_eal_alarm_set(QEDE_SP_TIMER_PERIOD, qede_poll_sp_sb_cb, (void *)eth_dev); if (rc != 0) { @@ -3046,7 +3046,7 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) * interrupt vector but we need one for each engine. */ if (ECORE_IS_CMT(edev) && IS_PF(edev)) { - rc = rte_eal_alarm_set(timer_period * US_PER_S, + rc = rte_eal_alarm_set(QEDE_SP_TIMER_PERIOD, qede_poll_sp_sb_cb, (void *)eth_dev); if (rc != 0) { -- 2.17.0