From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 21E887CC9 for ; Sat, 2 Jun 2018 06:43:36 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 95C6721CE2; Sat, 2 Jun 2018 00:43:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 02 Jun 2018 00:43:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=SlE3dCx+IeYR9vaZIdZQA8z/UrzvS+NOH0gaOcIUyII=; b=MAy563Xl m7vU/6WCQsYfiWYoO5U/cQZR3CjFiXqejqvfBHF6zTZfyds1JYNFLG1r9ksaaelb g6q40rG5yk8hNcHA3I4BRvLonzDv5lER8AASUlQN0c92YE8QG9JL+xil45KxWnpu g0SGv2EdQMOotBX1oTrPtZ01TauenH713XHZ3qg08nESRCyBu/7f9wCkVpz695i1 eDOh8URUR7gdx9RVtH68om2N4z07HmaQd6Z5ulkDrV4DCkmYWfmdN5G5b+ppU/Cq iyvAvKzbVImaPpoodp6U71nhKNeuYyAgw1DBZZtpbl4OX/c8VxC7XXupHuZiWspt ERwnR9l+9SfgLQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=SlE3dCx+IeYR9vaZIdZQA8z/UrzvS +NOH0gaOcIUyII=; b=axg/v3fswzy1os/Y1YtLYdlxBLEF627kF6O2RjGIxkkcf dNUcSMCy7uNiytVq9bwABdo2gKFz/QKxz3J07ZT4r1TxgauhhRUMCMBKCBNpp5yy zZKLsfY3GuVAboLr+8I+z5j6j/K/Fn5X3fCDuCFGMhaOK3+7n6RsZuM+CTRA55dN hdLVu6Nkbx1521kI7ITF57DcEFwIPY1hR+ptE9k83O7njk1rio6Ir48jjL+OSU4G ztT3R0xUYycRMQ3JPNDJub349cp1GCx8MM0Onp2PNdLUpddCegxwGbe3i1vJFMt7 N9nxGmD3Ef/PA+ubEue1JUs0ffTkqYfHWkC0+3JBQ== X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from yuanhanliu-NB0 (unknown [223.74.148.12]) by mail.messagingengine.com (Postfix) with ESMTPA id 9274FE425A; Sat, 2 Jun 2018 00:43:32 -0400 (EDT) Date: Sat, 2 Jun 2018 12:42:24 +0800 From: Yuanhan Liu To: Zijie Pan Cc: stable , "david.marchand" , nelio.laranjeiro@6wind.com, Shahaf Shuler Message-ID: <20180602044223.uacxl7emqgqb6ebn@yuanhanliu-NB0.tencent.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-stable] Port of mlx5 can not start after setting link-down on dpdk-stable v17.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jun 2018 04:43:36 -0000 Cc more people. On Thu, May 31, 2018 at 05:47:37PM +0800, Zijie Pan wrote: > Hi commit authors (and maintainers), > > Please help to backport patches to fix following issue. > Here are the steps of testpmd on dpdk-17.11.2: > testpmd> show port info 0 > > ********************* Infos for port 0 ********************* > MAC address: E4:1D:2D:E7:0C:FA > Driver name: net_mlx5 > Connect to socket: 0 > ... > > testpmd> set link-down port 0 > testpmd> > Port 0: LSC event > > testpmd> port stop 0 > Stopping ports... > Checking link statuses... > Done > testpmd> port start 0 > PMD: net_mlx5: Forcing port 0 link to be up > Fail to start port 0 > Please stop the ports first > Done > <== Fail to start the port. > > Test is OK if using master of dpdk: > testpmd> set link-down port 0 > testpmd> > Port 0: LSC event > > testpmd> port stop 0 > Stopping ports... > Checking link statuses... > Done > testpmd> port start 0 > Port 0: E4:1D:2D:E7:0C:FA > Checking link statuses... > Done > <== Port can start successfully. > > This issue was introduced by following commits: > 322e1ce net/mlx5: fix link state on device start > f1e3e97 net/mlx5: fix handling link status event > > This issue was fixed with following commit from dpdk (master): > 7ba5320 net/mlx5: fix link status behavior Hi, Thank you for the reporting! However, this commit won't be applied on latest 17.11 branch. Nelio or Shahaf, mind to backport it before the end of next week? Please also do the test. Thanks. --yliu > > The related patches should be ported into dpdk-stable v17.11.2. > > Thanks, > Zijie