From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0067.outbound.protection.outlook.com [104.47.2.67]) by dpdk.org (Postfix) with ESMTP id E33865B2C for ; Tue, 5 Jun 2018 02:12:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r1+5/wlIKfzEGMdxzRPhx1IHDLcZoBTQvRjECg2/Vws=; b=DYLAEfgTBr0rO549w+cPfWiOT8NtevFM18nsvhs9jXoka3Cu3iA8CjYYX/ZHdgyGO9TdMdbKbZVgoNeBxfQM3KLS9Phhgdcp7L+3ctjnl/dIg5lux6pOWKa3z0kAML0ZZ3enmdLq1asq5qGun4p5gTLwiKtjjog5B1CQjaWgC48= Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.820.11; Tue, 5 Jun 2018 00:12:33 +0000 From: Yongseok Koh To: yliu@fridaylinux.org Cc: stable@dpdk.org, shahafs@mellanox.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Date: Mon, 4 Jun 2018 17:10:42 -0700 Message-Id: <20180605001129.13184-21-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180605001129.13184-1-yskoh@mellanox.com> References: <20180605001129.13184-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CO1PR15CA0060.namprd15.prod.outlook.com (2603:10b6:101:1f::28) To AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2036; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 3:yWleT1pUPdZZgIl24ypDKDTcr+AO28SBzsf7W4CuaNpUgHwY2LQfKn5Sl5lfMNHhTHLRlPy7ueH/4iVD4DC21apf5vPdXttIGcpnpezYCexp5dWARvU0H7nzd3PYCBjd4b2Jr/xIUbS1Ool48ypLUKR55K0D6JlBc3e/WsGty8a9fbMeKivHONln/8cCotsFetoRXtSoQNShtyBPiToZePMZYuI+glcy4BYCjnyHOFCXj+3oQFBMIAe9lgXGwzdg; 25:ARH1XOMcZR4MwMCk8Lbvr9+O4V9vJpV2N0IjBagNJnsEykvYC7UrD4BqPJy3/d1QGOb0dIaSbrF++Yfwh+UfXenH/jC9UkAnEZH9d+iK7xZn+lMbxPrO7QjZ5cJyqaJdx274FGqAJNDyGiyAsakO+soACLXQmWEY9dpC4aXCGKPyjMXswK/kxCGNZh5+TDxTvc3e84s8kkc/GLpY9j/Q1sHHZIAMC+uT7aKweG2iC7sZ2MEytCdhQ5uKfrw8EnbumU+n9ydWuIVwqZHlTxyiEUefd1mkS50MZOCPuXi+U5KhWrcBewZvYcLGNuawz16TW+jZZSBsk2pYBmdyODZ2HA==; 31:0JUhKq1MB2Hk27RWEsoKO2FHTeuX3saKGsnaZJvSSNKw0sKKP19WIBLXPuCgqrraW4ew94Yf3ZR+9G6meMg1mAWWiQnvjs4uMjPu0wUPIOLnpd1TRdi7qD3zX/wbH7u0mLSGXXZjs97nrFmqVIIw5pqGKgVy67ybViSTTh0Ehx0hD6nuiYwujc5RS7JB8MBMVA9EXtZ/tqDRiP/7hfHJIxSbRmnthM9ySSXdvGHB3sU= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2036: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 20:UEAwVl3EPesvsTgIsjyxpEvvR30W9EW90xygcCLG2hUPqnby1K4ZJuQiF4jlsyZX9py7tsNAElaSgqt6xoMVgZIyu/ylvquMmwlhuljYTPjVsc1MlTAMazy5klHDpWULgwhK6Y/1enMVFVMo3z9Yn8ni8XPQitYONUdi8dwQ+P5ENnotbLUe9BVvFujTV9rXoA+SWXfXWrMkow2KWu7MvpB8pB4mSyDu13Vfu8DgZgOCLhIfIxsbUnLQmfoZ/MJgu5liVwgUSHwFETY5pYBVAGxqkC///iQuhFZi/wEOzrYP+/LHNDuL1PgP5l28n0OfpTP4p7xf9KmO31xNAWtoj8pWXXhVKpHM1UND4l22mQwCowF4LJ/5aDYomzePROxaTPkyLUoVznBFVciIWqkcl/iUPXfA7xt6nGvmyFuVredFlHrZBpPX6er5XWTroRUx2DVXMgiJYoG6E5rqXeFRVL2rA9LH15WZFiwXrUyTjCNOoieHTE2TtuNejxqwPGGn; 4:NpXQOv0mF1PZJ3c7qy2t8jckrbaNHakfYH19fUSoDHGYCEGs9ZRahQns1ZPjvUMW4NFLb19eM/quAmsjohqXO7On8BdRwC8UC3vBoYrxLuMZqWuk7CVXtGhYHb9D6YgkI8wpg91fvicgISfqwwZ+e2nIoqVgIt0h3VJh4OLOPtn8WHevIHOBOrAZSrZhAg9RSO0RvMynhJTGAgbDvD0J5WG/YlEYTOzwCVUJWzVvLzrpdYnnm2QI+5Aw/3ISdKA+qdIDzvIy3yEjTDEvJ29Yxg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2036; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2036; X-Forefront-PRVS: 0694C54398 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(396003)(39860400002)(346002)(376002)(189003)(199004)(478600001)(81156014)(76176011)(7696005)(956004)(2361001)(50226002)(305945005)(2616005)(50466002)(47776003)(486006)(97736004)(5660300001)(6666003)(2351001)(106356001)(8936002)(186003)(81166006)(52116002)(6116002)(476003)(6916009)(23676004)(386003)(446003)(11346002)(59450400001)(66066001)(26005)(3846002)(8676002)(16526019)(1076002)(25786009)(21086003)(86362001)(2870700001)(575784001)(53936002)(4326008)(2906002)(316002)(55016002)(36756003)(105586002)(69596002)(68736007)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2036; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTVQUjA1MDFNQjIwMzY7MjM6d2wvYUN4YkU0a245cEFpNjQ5WXIrVWMv?= =?utf-8?B?YmFJM3dIYnptM08vZHQycVk1VG9aVjVRNzYzSDhaL01sbXQ1T1JpeFlGRWJy?= =?utf-8?B?Y1grSlh3Y28vY3pqQlBNemkwQzcxV0NGV05qNzJQNVh1L1d5NTBOdnhwd0lS?= =?utf-8?B?WUVZb1VVWDdScFRHbktKRysxODhEMnlTSEVIZlVUOExrUG1YbXFBaTJHNkZv?= =?utf-8?B?VmRKTFZBVGhCQndLUVFGaW1LSFNBaFVSc3JzOG1YM0tGZ0o2RVVhZ3FTa3Zy?= =?utf-8?B?djd3NnAxRDYzeUsrQjM5RVExL29BVEVtaDZVdkhCaTNDSFJ2SjFFTFNMVzlr?= =?utf-8?B?bjA5aVpVMmxrd3Zwb3Fjd1lTOUtvcCtDdlB5bHRjeDMydDBncWswK1JsdjlG?= =?utf-8?B?WHNjdzZzcDBydy9wOFM2RE9SWUNGSGRhcVlXbmdYdG5selpPMzVaQWFKczBv?= =?utf-8?B?Q0JyNEJ5QkpLMUxtM2svL1hkODJ5Q0tNWTBaWllOS3dya3ozSkcrYjRteDRF?= =?utf-8?B?eFpIdTQyOWxiWFh3Qk1kV2N6STdMVmdPZ0VCenNJRmN3a0MyR0E1YXdzZGZW?= =?utf-8?B?TnVoQ2REeFQwUU9vS1dMOEFSYVA2VWNiTHdqK3ZVaGpCby9CMjhYU3ZzU0Ns?= =?utf-8?B?OUhjNExSdGpPdHovTnVJeGEvUmg1Q2NhQUxsNFpMcjdPd3B4WnYveFNqc0hY?= =?utf-8?B?aGorZDR2NU9UdU1ISFhDTmNLZ3F0ekNpeGoxZHFkaDY1SG0xdlVPbUFnTXJN?= =?utf-8?B?aFBIZk1LSDFPa2czdDhRYkJObzlMMEFiM3pYcFIydmRaTmovOVg1MktvRUFY?= =?utf-8?B?WHY5VW5kaFRqVDJhVFhmeUxjTkc5UFJzZDBGMklXTEpKU2R1c2tJM2V0bW1D?= =?utf-8?B?ckhEdEl5MTZTdHJqNHhmQXhDNm5qemlNR1poVjdwdXcwVjZiRXlQWDdwb2o1?= =?utf-8?B?V3dST05FZFRRQTBpTk1qUnZ6M3NVVDg3bkluSTZvVTF3eGFsTmRDYjNvUW1C?= =?utf-8?B?cnkwRGx6QnZNWUR0aU9hNXg3NmlaajJvS1RXTWt5SitmMWpFR1Q2a0pFZkZC?= =?utf-8?B?N1M3RXkwckM0T0FFRVBJU1V1em9UeUpxNEN1UmJWR3VvckNRQnovUDBieW9n?= =?utf-8?B?NXV1OWZ1Wm0zM3lHRzVadmhmOENVdXF0UmpNenhmQ01ZT1ZPM1EyMm8zN2E1?= =?utf-8?B?Q3hWZ3Rhbk9XUk5scExPMTNpTWNsS2tDOFNmQnhHUHVTTGhucXZrQXhsdHZF?= =?utf-8?B?UnExT1NCaGZQRGdUeTR5bDVTeVpCT3BxRCt0NnFlWlZmc0RTOGlaRHNxWGJD?= =?utf-8?B?ejNpWGFNc1Fwai95RzgzTzFudmRPdkRGcTJIazhya1hsejRRZDJyUTllRDNN?= =?utf-8?B?cWZXVEdRbGp6eUp3TUVZWUpVUkxPVmxNN3dnVXpqWE5ZSSszWmx3M1FSOW9h?= =?utf-8?B?Nk5TMTZncmNFVmwyWGFNU3pXZTRQZHBkSzBscCsvTkNHTFQ1bkdDM041NGlC?= =?utf-8?B?RHJnSHc4TXFDUWRDQjJQMVlMTVlrRHZuYjQzdkVpRDI0dDZHdiswVUJkSjhy?= =?utf-8?B?U2hTTVd2YnJPMEFBUHhoUmtHNHhOZGVJcUY4bDhMMFJ0Z0lmdXNYRlN0endY?= =?utf-8?B?d3R1aWc1SFpIVnVrTGVoSlB3T254SWdBTXZUS2FtSmRlSlJhajNHekdxTldo?= =?utf-8?B?aTBGUWFPZmg3STRsTHlGdHpvS0t3K01BQlNYUUpJbE9rei9jbzVMNFZwUklP?= =?utf-8?B?MGVZUy9PK3hHVFpEZ2hTMVdnPT0=?= X-Microsoft-Antispam-Message-Info: G/gUpDfiJgnGab3pb3i3YI3jh4QWnBLdRKQzRk7egOkEzX0tw9EOVEcladdvtlanT2TNsZyA/V4vJ6Gyrut1eO6cCRUM/MMNXG4+e8sGEO8WgAL3GINEmqo/3rNCPrGXW3Oxan/n9g1653ULwTF6MiCy5Re6R/7qnGS8WRAjWG6hWxU1Z1HB7jwaiXiB69sD X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 6:GL29fhPj+VedZpXItbBn82pjuXAXUY06K945ZAU8p5Pxlwdn0sfry9qcRoa4U8VQ8b2jmIhLX7TfybFbFZFo0rgWkwj0D1dIFQW5Va5cHKOPLFEcW4c2vGegmbO4VMv9fEWd5wLWI17WDv8cBCgjjfGyOYzeQJiyn7ckOCgxOANepLkNlHQ4dDma70KVatDikgCk9WaOdh+VSlEiJ6L/67ru8jsPC06ib40SQVaZBx9k2uiVRDtx7a5AUFnp7ppF9miI7zZpAGcQecnTSjyEGiJ38OnLU4X8vnyVWcmH6l1D6m4IOjanTbJK0pjGDWkuzD3009cHapJ/iQa9WeofEmMKK3ZVQ4UiuI8cPzCYfMMGmMN8i/kDP1R5DSxR6qk29+QGjNrYfbNqxGlXIYcqNpXfTsaWVI/YYX5+fpRTpAcUeuWoL44klN1EMXgC0mDwsK6saBX8spfkC7654w8tKA==; 5:6/JEx35piEIwBCH+YB1Y0F3Pg5gj9ilWejabX+IJxMaUAXjJNKAGVB4lEi5uUjOurzRVDRNdpHI52OxS1n7bAzGuY6Rb0Z0uWsWeQ4WcO5Wj3UdEy+9kqgzR9yvftbLBVnFjvk/Khg1oe97ChvnYSNXOPx39zqNvlp52uIfPzs4=; 24:LmjUZ0G0dbfEpNAFgs06JqIlD7KFmGYPIHA8meHDfmZQPcRJnxdEGFbU8d8LmVGJz2apz7t7cGD+A++xqWCS69xC47ipOvanVgPwnLQKTq8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 7:JFKHSznnOrixApHKmGSYikiWNP27GnQMe+CHtGPzba2u2hU9H4XJBPq75AejH4zVjRUzMEEgjb30OPMOR3FbmjAYNyYKJpRKLbkOvBsKO/YfluVMlp5stTDwabMX0wbbnLl7K/s4GxvE4yFEfWFECZq+NkoJIRjDbSBL8XFdiUp3EGxTyc00KamOknBGztq0G7oMZ+q+ecka4wFe+VvVAwUd3VmVaXCDzrFmA8z2BX09g31m8w7i8EUGhcXuQ1h9 X-MS-Office365-Filtering-Correlation-Id: ec6a9a84-464c-4d8b-9972-08d5ca7909d2 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2018 00:12:33.3692 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ec6a9a84-464c-4d8b-9972-08d5ca7909d2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2036 Subject: [dpdk-stable] [PATCH 20/67] net/mlx5: mark parameters with unused attribute X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 00:12:36 -0000 From: Nélio Laranjeiro [ backported from upstream commit 56f08e1671f99a15cf6b00027c2f7d81d69c4f5f ] Replaces all (void)foo; by __rte_unused macro except when variables are under #if statements. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 4 ++-- drivers/net/mlx5/mlx5_ethdev.c | 18 ++++++---------- drivers/net/mlx5/mlx5_flow.c | 25 ++++++++-------------- drivers/net/mlx5/mlx5_mac.c | 3 +-- drivers/net/mlx5/mlx5_mr.c | 10 +++------ drivers/net/mlx5/mlx5_rxq.c | 8 +++---- drivers/net/mlx5/mlx5_rxtx.c | 47 +++++++++++++++++------------------------ drivers/net/mlx5/mlx5_stats.c | 2 +- drivers/net/mlx5/mlx5_trigger.c | 4 ++-- drivers/net/mlx5/mlx5_txq.c | 19 +++++++---------- 10 files changed, 55 insertions(+), 85 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index c3d57c58c..efcf86ba4 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -646,7 +646,8 @@ mlx5_args_assign(struct priv *priv, struct mlx5_args *args) * 0 on success, negative errno value on failure. */ static int -mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) +mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, + struct rte_pci_device *pci_dev) { struct ibv_device **list; struct ibv_device *ibv_dev; @@ -663,7 +664,6 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) struct ibv_counter_set_description cs_desc; #endif - (void)pci_drv; assert(pci_drv == &mlx5_driver); /* Get mlx5_dev[] index. */ idx = mlx5_dev_idx(&pci_dev->addr); diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index f9f04ec6d..0266a4fe5 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -492,11 +492,9 @@ mlx5_dev_supported_ptypes_get(struct rte_eth_dev *dev) * * @param dev * Pointer to Ethernet device structure. - * @param wait_to_complete - * Wait for request completion (ignored). */ static int -mlx5_link_update_unlocked_gset(struct rte_eth_dev *dev, int wait_to_complete) +mlx5_link_update_unlocked_gset(struct rte_eth_dev *dev) { struct priv *priv = dev->data->dev_private; struct ethtool_cmd edata = { @@ -508,7 +506,6 @@ mlx5_link_update_unlocked_gset(struct rte_eth_dev *dev, int wait_to_complete) /* priv_lock() is not taken to allow concurrent calls. */ - (void)wait_to_complete; if (priv_ifreq(priv, SIOCGIFFLAGS, &ifr)) { WARN("ioctl(SIOCGIFFLAGS) failed: %s", strerror(errno)); return -1; @@ -558,11 +555,9 @@ mlx5_link_update_unlocked_gset(struct rte_eth_dev *dev, int wait_to_complete) * * @param dev * Pointer to Ethernet device structure. - * @param wait_to_complete - * Wait for request completion (ignored). */ static int -mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev, int wait_to_complete) +mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev) { struct priv *priv = dev->data->dev_private; struct ethtool_link_settings gcmd = { .cmd = ETHTOOL_GLINKSETTINGS }; @@ -570,7 +565,6 @@ mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev, int wait_to_complete) struct rte_eth_link dev_link; uint64_t sc; - (void)wait_to_complete; if (priv_ifreq(priv, SIOCGIFFLAGS, &ifr)) { WARN("ioctl(SIOCGIFFLAGS) failed: %s", strerror(errno)); return -1; @@ -700,7 +694,7 @@ priv_link_stop(struct priv *priv) * Wait for request completion (ignored). */ int -priv_link_update(struct priv *priv, int wait_to_complete) +priv_link_update(struct priv *priv, int wait_to_complete __rte_unused) { struct rte_eth_dev *dev = priv->dev; struct utsname utsname; @@ -712,9 +706,9 @@ priv_link_update(struct priv *priv, int wait_to_complete) sscanf(utsname.release, "%d.%d.%d", &ver[0], &ver[1], &ver[2]) != 3 || KERNEL_VERSION(ver[0], ver[1], ver[2]) < KERNEL_VERSION(4, 9, 0)) - ret = mlx5_link_update_unlocked_gset(dev, wait_to_complete); + ret = mlx5_link_update_unlocked_gset(dev); else - ret = mlx5_link_update_unlocked_gs(dev, wait_to_complete); + ret = mlx5_link_update_unlocked_gs(dev); /* If lsc interrupt is disabled, should always be ready for traffic. */ if (!dev->data->dev_conf.intr_conf.lsc) { priv_link_start(priv); @@ -766,7 +760,7 @@ priv_force_link_status_change(struct priv *priv, int status) * Wait for request completion (ignored). */ int -mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete) +mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete __rte_unused) { struct priv *priv = dev->data->dev_private; int ret; diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 76c4354bb..0103d9342 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -565,7 +565,7 @@ mlx5_flow_item_validate(const struct rte_flow_item *item, * 0 on success, errno value on failure. */ static int -priv_flow_convert_rss_conf(struct priv *priv, +priv_flow_convert_rss_conf(struct priv *priv __rte_unused, struct mlx5_flow_parse *parser, const struct rte_eth_rss_conf *rss_conf) { @@ -574,7 +574,6 @@ priv_flow_convert_rss_conf(struct priv *priv, * priv_flow_convert_actions() to initialize the parser with the * device default RSS configuration. */ - (void)priv; if (rss_conf) { if (rss_conf->rss_hf & MLX5_RSS_HF_MASK) return EINVAL; @@ -607,13 +606,11 @@ priv_flow_convert_rss_conf(struct priv *priv, * 0 on success, a negative errno value otherwise and rte_errno is set. */ static int -priv_flow_convert_attributes(struct priv *priv, +priv_flow_convert_attributes(struct priv *priv __rte_unused, const struct rte_flow_attr *attr, struct rte_flow_error *error, - struct mlx5_flow_parse *parser) + struct mlx5_flow_parse *parser __rte_unused) { - (void)priv; - (void)parser; if (attr->group) { rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ATTR_GROUP, @@ -818,7 +815,7 @@ priv_flow_convert_actions(struct priv *priv, * 0 on success, a negative errno value otherwise and rte_errno is set. */ static int -priv_flow_convert_items_validate(struct priv *priv, +priv_flow_convert_items_validate(struct priv *priv __rte_unused, const struct rte_flow_item items[], struct rte_flow_error *error, struct mlx5_flow_parse *parser) @@ -826,7 +823,6 @@ priv_flow_convert_items_validate(struct priv *priv, const struct mlx5_flow_items *cur_item = mlx5_flow_items; unsigned int i; - (void)priv; /* Initialise the offsets to start after verbs attribute. */ for (i = 0; i != hash_rxq_init_n; ++i) parser->queue[i].offset = sizeof(struct ibv_flow_attr); @@ -910,14 +906,13 @@ priv_flow_convert_items_validate(struct priv *priv, * A verbs flow attribute on success, NULL otherwise. */ static struct ibv_flow_attr* -priv_flow_convert_allocate(struct priv *priv, +priv_flow_convert_allocate(struct priv *priv __rte_unused, unsigned int priority, unsigned int size, struct rte_flow_error *error) { struct ibv_flow_attr *ibv_attr; - (void)priv; ibv_attr = rte_calloc(__func__, 1, size, 0); if (!ibv_attr) { rte_flow_error_set(error, ENOMEM, @@ -939,7 +934,8 @@ priv_flow_convert_allocate(struct priv *priv, * Internal parser structure. */ static void -priv_flow_convert_finalise(struct priv *priv, struct mlx5_flow_parse *parser) +priv_flow_convert_finalise(struct priv *priv __rte_unused, + struct mlx5_flow_parse *parser) { const unsigned int ipv4 = hash_rxq_init[parser->layer].ip_version == MLX5_IPV4; @@ -950,7 +946,6 @@ priv_flow_convert_finalise(struct priv *priv, struct mlx5_flow_parse *parser) const enum hash_rxq_type ip = ipv4 ? HASH_RXQ_IPV4 : HASH_RXQ_IPV6; unsigned int i; - (void)priv; /* Remove any other flow not matching the pattern. */ if (parser->queues_n == 1) { for (i = 0; i != hash_rxq_init_n; ++i) { @@ -2445,11 +2440,10 @@ mlx5_ctrl_flow(struct rte_eth_dev *dev, int mlx5_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow, - struct rte_flow_error *error) + struct rte_flow_error *error __rte_unused) { struct priv *priv = dev->data->dev_private; - (void)error; priv_lock(priv); priv_flow_destroy(priv, &priv->flows, flow); priv_unlock(priv); @@ -2464,11 +2458,10 @@ mlx5_flow_destroy(struct rte_eth_dev *dev, */ int mlx5_flow_flush(struct rte_eth_dev *dev, - struct rte_flow_error *error) + struct rte_flow_error *error __rte_unused) { struct priv *priv = dev->data->dev_private; - (void)error; priv_lock(priv); priv_flow_flush(priv, &priv->flows); priv_unlock(priv); diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c index 3ad21c000..8e7b098ae 100644 --- a/drivers/net/mlx5/mlx5_mac.c +++ b/drivers/net/mlx5/mlx5_mac.c @@ -116,12 +116,11 @@ mlx5_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index) */ int mlx5_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr *mac, - uint32_t index, uint32_t vmdq) + uint32_t index, uint32_t vmdq __rte_unused) { unsigned int i; int ret = 0; - (void)vmdq; assert(index < MLX5_MAX_MAC_ADDRESSES); /* First, make sure this address isn't already configured. */ for (i = 0; (i != MLX5_MAX_MAC_ADDRESSES); ++i) { diff --git a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c index 33d037d28..0bf65ec0e 100644 --- a/drivers/net/mlx5/mlx5_mr.c +++ b/drivers/net/mlx5/mlx5_mr.c @@ -55,15 +55,12 @@ struct mlx5_check_mempool_data { /* Called by mlx5_check_mempool() when iterating the memory chunks. */ static void -mlx5_check_mempool_cb(struct rte_mempool *mp, +mlx5_check_mempool_cb(struct rte_mempool *mp __rte_unused, void *opaque, struct rte_mempool_memhdr *memhdr, - unsigned int mem_idx) + unsigned int mem_idx __rte_unused) { struct mlx5_check_mempool_data *data = opaque; - (void)mp; - (void)mem_idx; - /* It already failed, skip the next chunks. */ if (data->ret != 0) return; @@ -365,9 +362,8 @@ priv_mr_get(struct priv *priv, struct rte_mempool *mp) * 0 on success, errno on failure. */ int -priv_mr_release(struct priv *priv, struct mlx5_mr *mr) +priv_mr_release(struct priv *priv __rte_unused, struct mlx5_mr *mr) { - (void)priv; assert(mr); DEBUG("Memory Region %p refcnt: %d", (void *)mr, rte_atomic32_read(&mr->refcnt)); diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 457f919b4..342dad18b 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -232,7 +232,8 @@ mlx5_rxq_cleanup(struct mlx5_rxq_ctrl *rxq_ctrl) */ int mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc, - unsigned int socket, const struct rte_eth_rxconf *conf, + unsigned int socket, + const struct rte_eth_rxconf *conf __rte_unused, struct rte_mempool *mp) { struct priv *priv = dev->data->dev_private; @@ -241,7 +242,6 @@ mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc, container_of(rxq, struct mlx5_rxq_ctrl, rxq); int ret = 0; - (void)conf; priv_lock(priv); if (!rte_is_power_of_2(desc)) { desc = 1 << log2above(desc); @@ -854,9 +854,9 @@ mlx5_priv_rxq_ibv_verify(struct priv *priv) * Verbs Rx queue object. */ int -mlx5_priv_rxq_ibv_releasable(struct priv *priv, struct mlx5_rxq_ibv *rxq_ibv) +mlx5_priv_rxq_ibv_releasable(struct priv *priv __rte_unused, + struct mlx5_rxq_ibv *rxq_ibv) { - (void)priv; assert(rxq_ibv); return (rte_atomic32_read(&rxq_ibv->refcnt) == 1); } diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 9955faedf..40a271a68 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -1975,11 +1975,10 @@ mlx5_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n) * Number of packets successfully transmitted (<= pkts_n). */ uint16_t -removed_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) +removed_tx_burst(void *dpdk_txq __rte_unused, + struct rte_mbuf **pkts __rte_unused, + uint16_t pkts_n __rte_unused) { - (void)dpdk_txq; - (void)pkts; - (void)pkts_n; return 0; } @@ -2000,11 +1999,10 @@ removed_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) * Number of packets successfully received (<= pkts_n). */ uint16_t -removed_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n) +removed_rx_burst(void *dpdk_txq __rte_unused, + struct rte_mbuf **pkts __rte_unused, + uint16_t pkts_n __rte_unused) { - (void)dpdk_rxq; - (void)pkts; - (void)pkts_n; return 0; } @@ -2016,56 +2014,49 @@ removed_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n) */ uint16_t __attribute__((weak)) -mlx5_tx_burst_raw_vec(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) +mlx5_tx_burst_raw_vec(void *dpdk_txq __rte_unused, + struct rte_mbuf **pkts __rte_unused, + uint16_t pkts_n __rte_unused) { - (void)dpdk_txq; - (void)pkts; - (void)pkts_n; return 0; } uint16_t __attribute__((weak)) -mlx5_tx_burst_vec(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) +mlx5_tx_burst_vec(void *dpdk_txq __rte_unused, + struct rte_mbuf **pkts __rte_unused, + uint16_t pkts_n __rte_unused) { - (void)dpdk_txq; - (void)pkts; - (void)pkts_n; return 0; } uint16_t __attribute__((weak)) -mlx5_rx_burst_vec(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n) +mlx5_rx_burst_vec(void *dpdk_txq __rte_unused, + struct rte_mbuf **pkts __rte_unused, + uint16_t pkts_n __rte_unused) { - (void)dpdk_rxq; - (void)pkts; - (void)pkts_n; return 0; } int __attribute__((weak)) -priv_check_raw_vec_tx_support(struct priv *priv) +priv_check_raw_vec_tx_support(struct priv *priv __rte_unused) { - (void)priv; return -ENOTSUP; } int __attribute__((weak)) -priv_check_vec_tx_support(struct priv *priv) +priv_check_vec_tx_support(struct priv *priv __rte_unused) { - (void)priv; return -ENOTSUP; } int __attribute__((weak)) -rxq_check_vec_support(struct mlx5_rxq_data *rxq) +rxq_check_vec_support(struct mlx5_rxq_data *rxq __rte_unused) { - (void)rxq; return -ENOTSUP; } int __attribute__((weak)) -priv_check_vec_rx_support(struct priv *priv) +priv_check_vec_rx_support(struct priv *priv __rte_unused) { - (void)priv; return -ENOTSUP; } diff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.c index 7943c4c3f..50e3ea5f2 100644 --- a/drivers/net/mlx5/mlx5_stats.c +++ b/drivers/net/mlx5/mlx5_stats.c @@ -500,7 +500,7 @@ mlx5_xstats_reset(struct rte_eth_dev *dev) * Number of xstats names. */ int -mlx5_xstats_get_names(struct rte_eth_dev *dev, +mlx5_xstats_get_names(struct rte_eth_dev *dev __rte_unused, struct rte_eth_xstat_name *xstats_names, unsigned int n) { struct priv *priv = dev->data->dev_private; diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index da9494eb8..2d9bb86ea 100644 --- a/drivers/net/mlx5/mlx5_trigger.c +++ b/drivers/net/mlx5/mlx5_trigger.c @@ -367,9 +367,9 @@ priv_dev_traffic_enable(struct priv *priv, struct rte_eth_dev *dev) * 0 on success. */ int -priv_dev_traffic_disable(struct priv *priv, struct rte_eth_dev *dev) +priv_dev_traffic_disable(struct priv *priv, + struct rte_eth_dev *dev __rte_unused) { - (void)dev; priv_flow_flush(priv, &priv->ctrl_flows); return 0; } diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c index f39b98a9a..a1c3e9d83 100644 --- a/drivers/net/mlx5/mlx5_txq.c +++ b/drivers/net/mlx5/mlx5_txq.c @@ -511,9 +511,9 @@ mlx5_priv_txq_ibv_get(struct priv *priv, uint16_t idx) * 0 on success, errno on failure. */ int -mlx5_priv_txq_ibv_release(struct priv *priv, struct mlx5_txq_ibv *txq_ibv) +mlx5_priv_txq_ibv_release(struct priv *priv __rte_unused, + struct mlx5_txq_ibv *txq_ibv) { - (void)priv; assert(txq_ibv); DEBUG("%p: Verbs Tx queue %p: refcnt %d", (void *)priv, (void *)txq_ibv, rte_atomic32_read(&txq_ibv->refcnt)); @@ -536,9 +536,9 @@ mlx5_priv_txq_ibv_release(struct priv *priv, struct mlx5_txq_ibv *txq_ibv) * Verbs Tx queue object. */ int -mlx5_priv_txq_ibv_releasable(struct priv *priv, struct mlx5_txq_ibv *txq_ibv) +mlx5_priv_txq_ibv_releasable(struct priv *priv __rte_unused, + struct mlx5_txq_ibv *txq_ibv) { - (void)priv; assert(txq_ibv); return (rte_atomic32_read(&txq_ibv->refcnt) == 1); } @@ -707,13 +707,10 @@ mlx5_priv_txq_get(struct priv *priv, uint16_t idx) mlx5_priv_txq_ibv_get(priv, idx); for (i = 0; i != MLX5_PMD_TX_MP_CACHE; ++i) { - struct mlx5_mr *mr = NULL; - - (void)mr; - if (ctrl->txq.mp2mr[i]) { - mr = priv_mr_get(priv, ctrl->txq.mp2mr[i]->mp); - assert(mr); - } + if (ctrl->txq.mp2mr[i]) + claim_nonzero + (priv_mr_get(priv, + ctrl->txq.mp2mr[i]->mp)); } rte_atomic32_inc(&ctrl->refcnt); DEBUG("%p: Tx queue %p: refcnt %d", (void *)priv, -- 2.11.0