From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0077.outbound.protection.outlook.com [104.47.2.77]) by dpdk.org (Postfix) with ESMTP id A9AA4A49A for ; Tue, 5 Jun 2018 02:13:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cHw2JXWVavh0AX4lfPrkVUOdsjydVNcjjWZdz6zLSb0=; b=r4kFmKNsFcbl1h1ivLshL5oLUpPnJSfxkdkjlNS8dFqPxFXX9hHHmcWyP7SwXiVq0gB1bXS8zmtVw3z5rRZDEfL7CXriIONbD3yJ1E0p+fFBvbiFnw1NaUTtnSH3WuhJ/IB0YWivNB7668Vp8AE+MGQVWcR78CMrj/Z1vVstHFE= Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.820.11; Tue, 5 Jun 2018 00:13:08 +0000 From: Yongseok Koh To: yliu@fridaylinux.org Cc: stable@dpdk.org, shahafs@mellanox.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Date: Mon, 4 Jun 2018 17:11:01 -0700 Message-Id: <20180605001129.13184-40-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180605001129.13184-1-yskoh@mellanox.com> References: <20180605001129.13184-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CO1PR15CA0060.namprd15.prod.outlook.com (2603:10b6:101:1f::28) To AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2036; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 3:w3+YrcPhVSvIEA4gR9zEeYUiovQYj1j9GhVr//kV6oO3+1ul/cLEJqtbXwU6dMrb04IsWrxFsSWmi177hfSj6DJnMcfIcfnSsVC/EPelhq7Fkm3qwrHON5I/LiqWr0PUjS07MHvYQ1vuI4ClQhNMbtK7ix/YXsPtvkhbRy0D6IL/WsWmreMjB4gpT/Cbw/trtSEcFHQYFtwxi0W0Hq3/WMCH8ej2Q/V9W0DvWaHncjN5ry2YFLNbS0Y8R9tbUSgM; 25:x/Y/tX7yuA5HvKoEeC226MpVtf8+9da/qfHvMmtftpkSBvBuGXCXI3suE2hK2wU6yq1RcXxDs0KrjZJMzLb4HOZjkUA6MeU5WLyNIbRUhml+kymgLuGWX9gJdvy1/1MD1t1flzQtIB1zQKHNhC0Q3PiGl+qqUrULWiWhADHLiHA0HmworcrTZqYZLJgYZUP/XF/rl4ikRVShN6JJQXpRUYkfG5Fgw5gFbDYfsmGIFixkx0MsriQZo1osHy2onmJduL4mPYBf2E4oc0CVZx+0QKUCmwH/9dxwcmqbTG81/YP2TAdqUSY43cwMy3O2IUgcB5p+TOXtfDKIQQ+07XvZ3Q==; 31:YKmzG4sHCQF+IQSm638ZZWjs2WolxAt05vsq4idAUNn9EYiPsbQDpyrocxfkkDquhBvNtWeboYPrLDc833z//hpHnob9cEMdLU8KbqMRurmkfJxvEz+Pn779RZcdYvTm7lvFVIdnFb3Mro85ci7za8EZBepoVs3I1Ul+RYNrUruQvk44iblFXgTrNBwTVqf221BqSby19HDaaG0o9VJDuolPK1O+4kQ81i8ANEHcCCo= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2036: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 20:K6RE8I4h+gSKyMlY+JGYetTobJVrsiP/ZGkfQyv2+HFusIHPjtURTe/PMiwOJHFDbfZZ1EcqX7gLvcsbvPL7fwMy9WY/iAbTDX4itm9A7ZkHH8pAHqfIU5a/Dj4QmC9aZ86WnfvE2ymST59F3Z3gkIL87nctLDrL2nWaJizPrHxeEvOtYIDoymhZNQujQf5WYbBXOeQV5J0sRho16J8EcKr6Lr2AS4qf12pcj9+P9+fxWSqEchxnrw2siqr77siwVQ7RM6+28d/Ir4+g+hZa38nyWYMUnnYFepvOoaBPSmz6osGud/7nsf46f2bkaHs3zd7XQ4e7s88kGn9eI7eSiWiRy4nnbmleBf0QXlxcAVYSvBVFP+giuAFlQlNWwfDuQqdVo/wvk16YMZWswdlm2/3A/f7aOac5Y6qDzxiUioxFmJsWsx4NT1OBlTCjjlH4MelByZjM0lcIHt/FKPcUVLrfMbNxpOLApM2zhDXAC1kZaZ+QQ8MLzidDYdjLX7d3; 4:HOPAXtObMjhsfGIKHS0nvPUyltiLWqW1XO+hYaB5H7iPABiqecaVLplcrbS4/G1ATPFLmcW8mDYkgHEPmF/79G7LqXnvEs07R+pfOrMLuODMar/qPMniLSxbnFbXtgAyM5k7Xg+CfwmAylT2Gy6UquIQ59wG8dbnkNO5VH76F65TGMkZcQPbQxtCQ1BHGh7fvToh1DdAP/uqp40BiqoDyOpv/uOx7mfCCcdfX6qlmQDhYGN7ssWTugkr9c2nC+fkslxZcoC9RuV9xB9LmpFEQw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2036; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2036; X-Forefront-PRVS: 0694C54398 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(1496009)(39380400002)(366004)(396003)(39860400002)(346002)(376002)(189003)(199004)(478600001)(81156014)(76176011)(51416003)(7696005)(956004)(2361001)(50226002)(305945005)(2616005)(50466002)(47776003)(486006)(97736004)(5660300001)(6666003)(2351001)(106356001)(8936002)(186003)(81166006)(52116002)(6116002)(476003)(6916009)(386003)(446003)(11346002)(59450400001)(66066001)(26005)(3846002)(8676002)(16526019)(1076002)(25786009)(21086003)(86362001)(575784001)(53936002)(4326008)(2906002)(316002)(55016002)(36756003)(48376002)(105586002)(69596002)(68736007)(7736002)(16586007)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2036; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0501MB2036; 23:mXuMe5yRnUkNKin0YS1FeGACS4NAz/3Et+CK6tn?= =?us-ascii?Q?0RT3Whv9mH4MGS0/7w+G4OTJoEsV2YjVrYbWkCNKczQ7QJqgp1zvh521GbCx?= =?us-ascii?Q?M2oMx8YIKKKawDldSOPco9t/4uuDw8++OIFDilqFVylHKDE8NS9B2pt4/UAU?= =?us-ascii?Q?hXZhfz0se9nNWH6QI82uLfH+hJNgERanOAXu1k20u9iS4HneS9ykupTymu5P?= =?us-ascii?Q?TFyCRNFpdBfFfD/4bmRgVTunNki3tvkG/LdcGsGCYHYtTSmd0XMxsKqU5Vnc?= =?us-ascii?Q?CjpyilFI/2mtpmLW6V/204lo7+ot7abYbHyJRMLqWVE460MApUODaYofytzb?= =?us-ascii?Q?2AfvWSnTqfs7EzrP79DnEz/GbN9wKY8Z6mi9UGzTDQjeQPY0p/ikNgZsRDLg?= =?us-ascii?Q?KnRpsxs6b85UMj/8UzIrIJqHA7ll28irpb5ltS4Wihy28ZrxS2zUB37bXeBk?= =?us-ascii?Q?8KjBny9XIoewTDbxNppXghEUrd4KiobnPRKtXZaoSvOnjhajSrXKcqWW/g15?= =?us-ascii?Q?KMLK/aNTiIJr/ohMRZ/ZQtR2vVn8Vt/it0GNlPFfli4v1m3ZxWJb/ZotHhZG?= =?us-ascii?Q?mPsFoPmoDiI9xSfnuFeESBXjsTK+SXqLKPfivfBHtfd39400gT/VYWhumeD1?= =?us-ascii?Q?wxc72zMpEkFIqRY539ZvNax1H8lhxXeZpMAEsH7uDDH79Bn4RQQ1vAJr12Ta?= =?us-ascii?Q?FKkdxlA0xdxo+0g2/a8GONJ9TyXeFaa5rZ+LsL22AwXQFRFnK99ObCuFNZeN?= =?us-ascii?Q?RoJGb42H7N8OrIioA+KWl98XdpOQZeKslkm/tgtlWEhwV+OYncKgKadJ6NLB?= =?us-ascii?Q?/s6kADExwJqR/kxcdqbFa4QN/QpjHOpU/nNulk/HxntejfTooTBqBlw6H1XJ?= =?us-ascii?Q?Y/XxHI34VqtYov9EMlYtMiZM04zxpyDra9LkFQ+Sb0Y5WvWGtevrWy2tThox?= =?us-ascii?Q?eiDXBad3xVvitHu/mZoRCdzqbv/hmZbEa/tikGSReHvbxLs7jBPctk2QAif0?= =?us-ascii?Q?bDTCoQvRXkBHxmzeVGBT4P15DcLqkq4SRP5yBmYx0zYtgqsrR0sUaKKVKKQO?= =?us-ascii?Q?JAQ1qMHx/+Im1L3zprZ1cmWd4an5QQgnL45TCzlfEaOY7VBy0jtdsvwM/dcz?= =?us-ascii?Q?BvsNp7qNrXcNwR1u3rxRUi2UI4I+4kbW7ap8GXZfNKGc177ntQ3cpj86TGvu?= =?us-ascii?Q?TMR7YU18xdmrA0aH8wY+WunaTnitOgwhU0lLZltJ95LCcvmFT5hVyhjisf1+?= =?us-ascii?Q?rfnThqXxoJjTeomXgGtF3lT1tL8a0C3hLdQ+9KSu+MvU9aC70MLN7QX20sjQ?= =?us-ascii?Q?2VPwnNQucojE+uAtmw3wfbsLzCNF96ioI70oFiV/zKf9PVQr2tUlFz63NEDJ?= =?us-ascii?Q?p5tWSs7/C9Jax4WXvyM6eb6jqp9bduDkT/UDZPy8ccBgJKrUMZwEZOgp1A5u?= =?us-ascii?Q?PnL32+IiZiQ=3D=3D?= X-Microsoft-Antispam-Message-Info: ZZ7j4kZs02ora+3hbb8TVk3f22asvdy3ZwN458n9OcJXdHx7ZklWfNzM5PBlB2Cw2hB1kZZ/Bly8UcrLnC/w7GQ059qjVMIDd4lPn1lVSeq8XGeMkqM2jtH7ShT/5shLVMGDjCZeTsvcCsLpvA4gSxWNcEKbtjOzqzrWS4D0Kz5qUZZ084ZAFyrMZlTPteqB X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 6:k6bgp++Qga70fixiD/XxjO3z+10o6IjqdCDYzyXkQkYQW6axivwW3nj1B33fXmgVvo4FhixY7TFcADhvzYInuPn1iW0WJw9peaZcBHoLaM4fxiSiVds2rK9vQYymYoY/2aNj4GuFIQtWbb6iQ0iyj2vDwVxlvpzYFFxQCx2tZJr3hM2flcKka4uxkarGKYGvqGvjiLOAaMHjFatgHsRS+kgNNf4Ys8jJKCvePQQj6+BfSWjSavvfpMceldTxLWaBx0YJihHDvDdmU8TuO23jRrMJfIfygwQHqNX24+r6IX5hdaSrjVXOLzIzan89CZIP+QCNzzJoHw3aYEGhIP1hS25NqDbDSpqClSUARgGt46afmw74/Yq9v27GUiqrhM4VXCK9xnoIAwCXy7LepyVyWaP8Q3yihu+ceyG1wKSuo6gVmIJzt9wo12k2xJJOkA/k9sfEYre64jsTkk6ykec/4g==; 5:T+iJ6SCgtukVhfQzym9whYFJuPrXyl3eJ4QfU4GkDXNOw5rfEZjJxlpoVwFfnf4IZWICGEueMu/1QXQvCpxESJD1XlwoYb+DnAndf2D7azhufvLPJNn4JmmlaTY+DKp7x0dY+mehdm3OdDu2icQP9ULmVgH0BC7pxa4N++lc3+g=; 24:vWY/vnB43pbyYZfHGPN6L5uBjwREWTMkwm6ZA0Pji0b5WsZizZlSXcuhrScFmazIipXNG5hLmOxOwIMdhkT++7EJ8VZZLl8syVf4rNX4qwU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 7:lMomJ4ToCF4JEmUqa2K0IPuGU6zuo/v23b4DZKy42aYLympaKS3sEBbiM/BfZ7dogP82W7Xyd8q6vl32fm5KYoTBLR7MTuCdeLhy/XjWPcmj9h452o/bInOIwTEHJPNkXKMqYbG3USb2qXk8TNfWW4flSHZXzZXF7y0/c3XmNLo08y7/vyVsUlFNM7jzdYfojHD24ZtgjcWibo5cDAyBsILqMnNxY7x/gwjYDnEM7Tu1yzB7GtCCmvoNe0w2c+Xr X-MS-Office365-Filtering-Correlation-Id: 93d7033f-2bd7-4995-ecda-08d5ca791eb1 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2018 00:13:08.3716 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93d7033f-2bd7-4995-ecda-08d5ca791eb1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2036 Subject: [dpdk-stable] [PATCH 39/67] net/mlx5: enforce RSS key length limitation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 00:13:10 -0000 From: Shahaf Shuler [ upstream commit a1572312f713f0b218063c6213499e36a8b47c86 ] RSS hash key must be 40 Bytes long. Cc: stable@dpdk.org Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_ethdev.c | 3 ++- drivers/net/mlx5/mlx5_rss.c | 7 +++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 18e1e534c..1e869db52 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -334,7 +334,8 @@ mlx5_dev_configure(struct rte_eth_dev *dev) if (use_app_rss_key && (dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len != rss_hash_default_key_len)) { - /* MLX5 RSS only support 40bytes key. */ + DRV_LOG(ERR, "port %u RSS key len must be %zu Bytes long", + dev->data->port_id, rss_hash_default_key_len); rte_errno = EINVAL; return -rte_errno; } diff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c index daadfbe5d..029e0ec49 100644 --- a/drivers/net/mlx5/mlx5_rss.c +++ b/drivers/net/mlx5/mlx5_rss.c @@ -78,6 +78,13 @@ mlx5_rss_hash_update(struct rte_eth_dev *dev, return -rte_errno; } if (rss_conf->rss_key && rss_conf->rss_key_len) { + if (rss_conf->rss_key_len != rss_hash_default_key_len) { + DRV_LOG(ERR, + "port %u RSS key len must be %zu Bytes long", + dev->data->port_id, rss_hash_default_key_len); + rte_errno = EINVAL; + return -rte_errno; + } priv->rss_conf.rss_key = rte_realloc(priv->rss_conf.rss_key, rss_conf->rss_key_len, 0); if (!priv->rss_conf.rss_key) { -- 2.11.0