From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0083.outbound.protection.outlook.com [104.47.1.83]) by dpdk.org (Postfix) with ESMTP id A99BDA84F for ; Tue, 5 Jun 2018 02:13:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EsyXCV/3KKjKsnJav/HuSqGFCj0FKj0ek58QChylmAg=; b=B/uhWud3z5gOYLHXMoN4kGLGGj5m9/aPYBeEVZ7DG7pafX2MBFBlNT5bSLB6x6ZSWGuzNz3OaQV4cPIE1+BuWmm4pTC1vg108y6aU47J4oalnSrR5KJYJskb8jmqd3cokJWLzDcBUCDv1Qr89vvfAcOMPOPkDmTPJ8F7sYzCBVI= Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.820.11; Tue, 5 Jun 2018 00:13:15 +0000 From: Yongseok Koh To: yliu@fridaylinux.org Cc: stable@dpdk.org, shahafs@mellanox.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, Yongseok Koh Date: Mon, 4 Jun 2018 17:11:05 -0700 Message-Id: <20180605001129.13184-44-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180605001129.13184-1-yskoh@mellanox.com> References: <20180605001129.13184-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CO1PR15CA0060.namprd15.prod.outlook.com (2603:10b6:101:1f::28) To AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2036; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 3:oBbYmoE+w3EaiRQFTR5MOK7u02zsCSfzsnOttjXtGC7t8YKVW77/eV/NFbL/v1qrj3EoC4LZuKcUrmXwuBZaNva9fKi75iw9K+2nbpmjlAha+PzFyFvGUzAemRWh3qTZIksHjhwKWJqS2yZlsjM7UoN2ppSjSjNfvSMJ5RfN1q/X6qOo5lD/1fYigz/eAUPEEKm25pFjc9uHEgCB89YMzNCK2j9zsFBJSKo1L/5vcvzebGaQqsIb1wNUm3KHoYZu; 25:fxwGlLtED/5yeueuAPq9BIa1EcYENP1vo6DR7HgU/1vKECDVY7zO31RiAJfZ8gKK6FToyGSK8sIl8IAEVi5i0Gsrl9G78MLhkw690vLg540r9wLtHI/d/1UWlQVp92XYlnJSRs8t/DD5VjJ/GhLXcq2py87LbT7jFDgngM+SJyyM3mvZ0y5ZhWrkJplURXijUMyQNyxt1bQLs0NvyviPPGSrnEzCKIcnpAcsAD/8OKcNI6NexNGRQeL/BW+sLAX3ktL9tEmV4pTHBkR0ABQpHD+aPAqx8clXMPz23saYG0PXgrzNvXJW8YgDcSGL82tSAtZdqfrcLlU1LjWLbYjPNw==; 31:QgP0CgicV8UZH55Ijt25dBBwyBcXw56IpYpdrG/evwh6GmAYEvKPcIz6Coo7Id7PD09ijW8PWPJe2CphrTUunlER6foFNuqibut+dfkinxM/sQ9nWkie65SKbwbzbfD+GvzHbm3fhKmk0VGp9ymqhww8Newq8Dx9BH36vT34/KnfPIL52A3lYbEBicbCJA2uePxz6oYw+C0Nfr+4DspXH4jeTDi6CZzK7OZoV3qgL8M= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2036: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 20:jKc7hXSzSvGd8navYfK8xyzT0pNyewqn1D2r72d4/8WFWi3VAtyi0wMeUAGrLhLQPQUEFQpJmP+YrfSfuU3H9/U1SdHX1vxzCaddI/dnHQNI5gZ4MMYkDbtBiasU8DMXPi/rSCRR1ovpgIDs66tDtMdxB27+D+LMv71HJwiSzOHGOEhlBbINeU28o+ExBtIrhK6oPYIb0DtAmoAKH/x8aZX8tz0wNEWyl1iGxaCBCGcXJ92cezT0yPe5UJsqO8uXvKTtwzIWtrTXBuXCDU8m5ICJjJ0Qv79xi+EIcNR9VzdzXh9+8zUQrzYy8jCsWbxp12JZgZM2hqa6Zh55EBYOOUBySCIal+Zz7fdhp2OfbEymaEgCMum3eM0sOhlbNSo3U9bSRHpB4JicTKxHv/AX5m2OXOPfeB/MplrgbZb8/tiYdAR5Nxx6CjBKUFz7UafrTQK8lbyeiYdiQg5E2Kvpea6ezs7BH5DdxZt372WDfbg/B1VZW55dLdRzMk3XwoAk; 4:d168RxIgF+WjS8QBWi4ecIIh/9T+b+Lz4AN2is+RHPbqY9zcVt9xp2nmmUVOjlHI0eVhv3U9qbxBFTb4iGUP6vP4aMhUeVU14vSyU3xPruJeBpAuc4aJvumf9vfMafi+1bT3aRauRxyDT7XNIlKO6FcACd97gF1hVkDgtPgG8Q5FJBEudTFzS8V8e9xu+P6zuxOUhUOG/wouuePhvjUWW3ecMgfqAvoayMjT9o6eFDY2RTkzHY04rkZHvHiLJPkyQ8AI/Zm7oRhKk7BGeyBfAw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2036; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2036; X-Forefront-PRVS: 0694C54398 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(1496009)(39380400002)(366004)(396003)(39860400002)(346002)(376002)(189003)(199004)(478600001)(81156014)(76176011)(51416003)(7696005)(956004)(2361001)(50226002)(305945005)(2616005)(50466002)(47776003)(486006)(97736004)(5660300001)(6666003)(2351001)(106356001)(8936002)(186003)(81166006)(52116002)(6116002)(476003)(6916009)(386003)(446003)(11346002)(66066001)(26005)(3846002)(8676002)(16526019)(1076002)(25786009)(21086003)(86362001)(53936002)(107886003)(4326008)(2906002)(316002)(55016002)(36756003)(48376002)(105586002)(69596002)(68736007)(7736002)(16586007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2036; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0501MB2036; 23:XjGCERIVV/wTw62mpvkUNlpbZ6U+tQtCnN2xZUN?= =?us-ascii?Q?28V+UIgT1gzsGb8wfZ2zYVeObxOnUP7Dlr6Zw2SwD1b9eCZ857M0diAeBQT+?= =?us-ascii?Q?gZXI7JhlaKv2isJpoalWS7jtnHEk8jCdsEP+cocHHfmdGvwnEOQjXjJ13VMW?= =?us-ascii?Q?LwinTwBm2Ci6R30xogjC+1/TW9uXjRUyuYkY8sNZN+zBgTBn3xHohm/vX+6s?= =?us-ascii?Q?oHT2caJcNxecli4vJl6jbCpDLFYCTBPPVw1PE/jnh6lqfK1rzL8sfX5pDX+O?= =?us-ascii?Q?X5cBiTOGBLupu69JLXiAOUXeTGOKOzMLIxxuS3XvIrZ/lcjaGZNLbOnTkzKm?= =?us-ascii?Q?nt6JsdwRoyF55fUaQdgea0l3eprQSTEu6saWShW1ZsBXo5FfVmNeAlqYsFpe?= =?us-ascii?Q?1uYZnDui8ZxMlmr71C6km27jWjnvz6CyWF8tb6DxW5S+h5atqZwKuzHi24Et?= =?us-ascii?Q?m6qwdgX5Qu75oHgrA4g9f+10WXCS6VW78ygzeQiCDsUTzBIZ20yU7Yet/Xe0?= =?us-ascii?Q?UJgo3soYsAxP/+G1KjlIDEYM4x3IJuZj2txqFiUeelRqCiIyInAlceqaLNu/?= =?us-ascii?Q?THhHxDAQ0988NwjJNZBLJgsEDwPjOjygebb1yb0duv2dggKhoDjGwVz2EJ2b?= =?us-ascii?Q?pI95fSQV3W2WGS06aIagn3GpxNOldkzsmtACXbEoPvLZEGi6Dd8DHW478z5A?= =?us-ascii?Q?v6hq9KQ4IJRtM9+uGpqERRHA0WqGbpwd3Q1ZB5FTe6+cB5t2A1Eu6AsenJqQ?= =?us-ascii?Q?9xZqlNPWZJgzVt2jkNJvFYb0Ls+Hck61NKZvlKjdtQqNrPXGqZocTgrh/Gln?= =?us-ascii?Q?jAdFSuT/gu57VgnhgEy4X1QAAbtY4JpgoI80i7Koxr4VT4tf9lu9Ojlb9O0w?= =?us-ascii?Q?/2xCLx/b5GQDEkmNmf7BB5JC7r/eh1MGiWWwVE/cT0zn7UiQm0EEwSp5xfCA?= =?us-ascii?Q?caJ9sVrGvC01CkerooRza3bq3lkxy/HWOPclKc32ZwnwkFNlyqQbXbh1AzOT?= =?us-ascii?Q?5MB5cNHCWdRzwDn8Zy37657DG1DIG/VyngltSa+fI3PueAPpr5oiSlzNiXSx?= =?us-ascii?Q?eg0LxxjFNUBa02RO3VvPTmGa3+ea7XkaHfHOvnVEq9QsydbNEE7j9IcMT+Hq?= =?us-ascii?Q?s2D8PgcLoh4mxLCsx5PIw12qYwcLIilMjCK1WMTJG89MqmBKeCh0Z5BBohZV?= =?us-ascii?Q?rRUKVpG+KC4ySUYPbNkPCBdtFP/SGlu2xLXp1oPJrSRsNZX0+DHBMYmczaWo?= =?us-ascii?Q?JLncLmQrZS3GvvESfbuoOWlVS7YLgQTNzWjJHcEfK7V00ik9GYZnsoFUZtYG?= =?us-ascii?Q?bcQ=3D=3D?= X-Microsoft-Antispam-Message-Info: MwIxed/zn6dcOFHHrfnZJWWIJuvzG6dOO3AeXQVwpZyPLnTvcj5z43nJNNBSEFxqMexnNRRCYMwZjJhrDvN9RRbnNBGHMe6XRkEd+XCcUKP92rfaWL6oigpXowdCJxN1OgtYUG5YwDKc05wxMxDOj0EmbW0lj08THVPdRswgh3Fg+IPrrg6YWz/nZONJBve/ X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 6:daZut9TMXbJ+e1SyF62JkCNc/rWCmwmj/h6VJy01SUVwqyuF6bM3diUm0ijAk9aSMnh3A17cLSQPf+zNHHXRmeGQ6b8Z1DFaA4WGtGvz4i5hlsIIYuHqkeYRnkBk4b6T3CzgKUvnEYG1yqpWEOe3p/Bc2TtzmlNjy8POMUILpHYNmRi4S20xNEqPtjv4ICSkXYo4pO/CA4XhBbliDh8NiO4BFXHSXqR+fKp4ZjBcbS6VlPXifLrWT6ObAC/qQaQuOE+JOoBU7NbLyLmbHriblXXCsf4zTK81uDt1In/kP7jI8hKmFvG2qfp+RIsKPsseoOpXjg8x7nlRc70wcTZ+XdXC+joG23QHeFIGQaVGOvXVev93nv61t6UHrwcMupwLV2V060EOkzWywRtv1hHgZvobtkR4TksrYxCSxUilNlkwZxDKYLu2lmjLfMxK2Z/Qy4XCuYrrHNB0ivGvJ0hsQQ==; 5:9QpWou1P+5Edcz5szCCh7eKBuqqo55/mRFQzPLIR3mCAyLd2/rhFYGaUyRklYHgnNDmK6xoIsswFw+sVPPNRQlG0WT/kz7wK3in1kXGoVppvmwGRFKwf9/KZwUUCQoOJ+pdBToSIJMTSML+tEBiWTuvgly/hQ+xtxYtwUoKfU5Q=; 24:xAxEMejcFTqhz4pc9VUNiDK2y0/3I1FHOPvTJzU6fTzLAg/vkDKYp3qvK/oSMCZUktUuRNPKZaZ89XQ/u/8xibMUyfTBpzx3cierJfoE1aM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 7:bwSEodvRou6TqMYOHwX6NbUKEP5dz55N0Sj4g2BGpGAQqS3uCyWN6YSva9NhUh2i+LQ96IqNOqhT8VpN2BH5E9BN84a0XjKN5015cTcPLmuFYVJmlaHNifkCugmX0Ru+PBWrLdvbSayw3g2gtkZNLdVNtc0FisTOodfEhsoPAqpQehHuuOrYM5aJnMBS5NBI8vNwtuRQXS45iiLYc6HPVJlBbvEAbh7HMgRf/Pu7P2/DPXolg9AWTKIxibpd5zNj X-MS-Office365-Filtering-Correlation-Id: 97339784-171d-460f-0758-08d5ca792328 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2018 00:13:15.8721 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 97339784-171d-460f-0758-08d5ca792328 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2036 Subject: [dpdk-stable] [PATCH 43/67] net/mlx5: remove excessive data prefetch X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 00:13:18 -0000 [ upstream commit f84411be9e307d2723052a8ae8ee80a1fd9f559b ] In Enhanced Multi-Packet Send (eMPW), entire packet data is prefetched to LLC if it isn't inlined. Even though this helps reducing jitter when HW fetches data by DMA, this can thresh the LLC with evicting precious data. And if the size of queue is large and there are many queues, this might not be effective. Also, if application runs on a remote node from the PCIe link, it may not be helpful and can even cause bad results. Signed-off-by: Yongseok Koh Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_rxtx.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 9c571f160..2e003aeac 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -1378,7 +1378,6 @@ mlx5_tx_burst_empw(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) do { struct rte_mbuf *buf = *(pkts++); uintptr_t addr; - unsigned int n; unsigned int do_inline = 0; /* Whether inline is possible. */ uint32_t length; unsigned int segs_n = buf->nb_segs; @@ -1555,11 +1554,8 @@ mlx5_tx_burst_empw(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) ((uintptr_t)mpw.data.raw + inl_pad); (*txq->elts)[elts_head++ & elts_m] = buf; - addr = rte_pktmbuf_mtod(buf, uintptr_t); - for (n = 0; n * RTE_CACHE_LINE_SIZE < length; n++) - rte_prefetch2((void *)(addr + - n * RTE_CACHE_LINE_SIZE)); - addr = rte_cpu_to_be_64(addr); + addr = rte_cpu_to_be_64(rte_pktmbuf_mtod(buf, + uintptr_t)); *dseg = (rte_v128u32_t) { rte_cpu_to_be_32(length), mlx5_tx_mb2mr(txq, buf), -- 2.11.0