From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0045.outbound.protection.outlook.com [104.47.1.45]) by dpdk.org (Postfix) with ESMTP id 404DE8E7C for ; Tue, 5 Jun 2018 02:13:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8oyf2iMfsrTQkJ5RwOjX53w6nvO3h8Mi91DwzD9OoJM=; b=MIsjuPC84mkSHN+ZFvpAs3N3g3Z9Aa/RraWmW4cFAtUlr1mgTtw3CqmnDzwuLJTeKqniT4eOrVtwZfOjPCNWYRsBCAfI/45EUfzSZDtKe7VBgu/6LJwkquWLE0YCqChfun5YjUtXB9TZS24cBgiMmwQKSR41MdQBl1fauM8bT3Y= Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.820.11; Tue, 5 Jun 2018 00:13:17 +0000 From: Yongseok Koh To: yliu@fridaylinux.org Cc: stable@dpdk.org, shahafs@mellanox.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Date: Mon, 4 Jun 2018 17:11:06 -0700 Message-Id: <20180605001129.13184-45-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180605001129.13184-1-yskoh@mellanox.com> References: <20180605001129.13184-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CO1PR15CA0060.namprd15.prod.outlook.com (2603:10b6:101:1f::28) To AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2036; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 3:TGHzuceJpmb6WI2YthG7Q+I/JjCOjflVjzM1Lgq5iTtchtuWF+8V8w7BCS9C3Kz0m9NO8IBxDkvG2gwhs4IhU1stEAA4MPMKr5TcoXFfoOrMgO9X+vsWQWQnIMAxqbD2uFbITtgAgFE9dZmgtL7xGzOzoMWcUv40bjWnDIzl0w4vlJhG6764LjszqF8W9splmGqJ0WuoW5CAPcM7ykF1RFx1I1M1o/OzILmvGbIkUoUbYOiwp4/Aw0EeJrsyGBRg; 25:MvEWflyUwmz723IxkDMj/ibFeftPHChXm+L5mLR3MX50oVQx2D+cQDwTz2FsCNA589HjwwmmxPCjCTmx5AQn3HetKeq8sB0zdfKiC0xlwRqGowyjE1MXibudYZ7Mav3I9mkBcuLEQUAf+hsK93cuZnfEYt2D+jX85lW5N5qDUwTNvmTSchNVhFPcueG8qI/JbsbBwIZnzEyaipmFKeaAPDbdWqAIYCIY0EibupIGNTgxU66k6iQFJgIw+3ImD4/OFNJ1t4aGOKRXyN9+oeVrRwfLwpeOXSv3QM/Nxq2hzbS8BslmUT2g5GaKl0tTaS7GQahCwsCeFc45yDhrfVpcVg==; 31:U7RWZJfsrPpvrIkQxN4vAIkyrNcNT83XOkyXY0GKe0KKn5exR84VPbsqihc9VKVvakzo5o2vD1MUv3tI60f79iG/w/V+E04hEeaO8PWDIoukb87VbOJACNY89jysPNeB0dJxbqR8KCtHIp1T9jFf0FLvxhJU0ZO0GijfRGEity6jmcEhwo/yaBGNmES4ARAVdlK+aVuQDRNOGdw+HUSoosK92b+Gxfv03yexGa/ffiM= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2036: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 20:PWnXpC6W+6qwG2jejDz0RPVeOW2+h6jB31gV0lvJLUhZcctQ5zKw8n6GQrWjMvcaRHAyJjrbAzNKCArvnmQ/NtoLIc8Q/85yNagPZyIDdPC1NEbVSOpJUIlDHVbQJRkdcjcCNiQVKxupN+E6lM8nToJTmKSH4L79v9/iIx0WQYcss0+jzIhH334kvKmSBCNN7eQnetLSFvfSClnuln1BLUtDZWNjLkOkfBRaa4V5V0o1WW0MqslfIJeuQBtk/jo0wKlvdcNKvilOqEOI/SVrLc7YocC7HIPg3kiVyEZRylPEfma8O1CwN3dY8itTvSFvIME6v4t0Ez5vAFKm/Ne2vVk6e+S3v/cov4YEdMUrJFEakdyBQFT5Ai8VK5k1O+D6hYkqAPhGglY8QzWS15LP2CJgzcYlSQInAcpnbBXmZdnclqZCN4s31pMXD4nYvaLf+Fkcy0NBTcS62KWhAh/VhZB6acoTydZLCCS5v/EukPxnxttY3OkRl1xCZF/0/9QX; 4:gmpAGwpd28ilhY0kGuJ9idutjFL9dlrvKpp/zDpZSI43bEL416A/ejWNwKn7ckvX1OF+WDXxXcwixD3u9oNjd6d6BuC3KS/znDDShW0yTTt0Ea5SaOZlD9mCkE92KpGtfwtYproJ2jS/ib90yAiXCbH5HWnOaiQ1MYfFaQrD4nTKyCT3iLLAR2QoNf7WRwH73hwsk06zGEwxUa8Sqlwx6zz6IlgQRDAfWYidVlr235OB2bbX5bcH4lew+9gdlXOU3revqO0qNn6NMugynK7bQg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2036; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2036; X-Forefront-PRVS: 0694C54398 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(1496009)(39380400002)(366004)(396003)(39860400002)(346002)(376002)(189003)(199004)(478600001)(81156014)(76176011)(51416003)(7696005)(956004)(2361001)(50226002)(305945005)(2616005)(50466002)(47776003)(486006)(97736004)(5660300001)(6666003)(2351001)(106356001)(8936002)(186003)(81166006)(52116002)(6116002)(476003)(6916009)(386003)(446003)(11346002)(59450400001)(66066001)(26005)(3846002)(8676002)(16526019)(1076002)(25786009)(21086003)(86362001)(575784001)(53936002)(4326008)(2906002)(316002)(55016002)(36756003)(48376002)(105586002)(69596002)(68736007)(7736002)(16586007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2036; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0501MB2036; 23:kWRGqvSTSlwg5rtuxZy+Z/gcyIMyOmuFCdBD7il?= =?us-ascii?Q?Jrky/FCHWRkFlRKMk1KN6lO6IgmYql+Nd6Pi7sodxVh2kduZjMH9+3OOTDEh?= =?us-ascii?Q?atF7Ml238yjTVvaAvLAFy9jXAPNVdWWu6dsUfsKiEXTYfAZzBjtXkIeQMcga?= =?us-ascii?Q?B9FLOtb203tHeQtq2dyqJuzO5UhBrQZR0yjz3eYIynqJ2+3BSXZqoDcz7zvo?= =?us-ascii?Q?LJjUzA5pQX+QKQCJ5JIXWhq351vsDCNYcMvbF7QEB+SSud8yzMyEVxDvdOLU?= =?us-ascii?Q?F+BqCS1afJ8qRUyXYv4uRJ+QaxFdlIEPubL6SyYJfjQrDNBDFw6ZSSJdEytC?= =?us-ascii?Q?MNWIOmOzbXIqtXL7jjPmeAyrHTbLNMQa3dZNdYfFtMzSbMmMA+PUcs/ff8uK?= =?us-ascii?Q?lbogSUGMGPa3/t60LItQU65x90D+4GKYzvw8UKm0sBPoy5+N6MBoSbBI//kR?= =?us-ascii?Q?cnmTtbiYT97h2CNQGmr5j3LiknSP7hreuso4MNKvK8V8clNXKcb+QYW6824p?= =?us-ascii?Q?7AZPEajqxMbdG3pKSFz02W82LZKq0RrFGAg8wb4d5IxYTzrIv0x14MSoTbp/?= =?us-ascii?Q?8ID/ZUiA9Pka3ThU2ch5ehLFNsZ+VGFooNZfeAzLcZHraiqCbQfoVrts6Ytl?= =?us-ascii?Q?NlrARw8QZcI0Q25Po7gXndPtVFdfwTrzz/LCTvUY4BOd8l6ZabgSEDAWxcn9?= =?us-ascii?Q?J9AuW2Yif2/XumdUsdrC+9AJbj59vtiebIAxZCHGoLvM6t42YHzCQ/LnB2SK?= =?us-ascii?Q?j0YcHHLtnunFSB+PqC3TVmgB3J+YE/AnmWU7mlwK+dACgLHg6Vs0dqG+ZRfm?= =?us-ascii?Q?LWAOKT/XsdCXH0EtwJGiDYrEvyI9386O+HbzrJHpblbfEdi0GeTZOCo+4E/7?= =?us-ascii?Q?rnDHBS0mN2GpW+6uAAaFhTyyj7WM1itKVVSGP8H+M4L50ZFd7aGybVXcoM9n?= =?us-ascii?Q?jwg6CxGds1eVgdnwaPD2OSTBClI2W0dtHylOlp0mYioQaSaoUhL3sBHyL/jh?= =?us-ascii?Q?jHf/ZWvxgNKQ/YufyWiJHwQ85EabD8S0eVlcQPViOa26ClBOaVbEMUDKyRee?= =?us-ascii?Q?/0PnJAnKUjqXX8oqCq3CuyQVktCgNuF+freBRRTG5FSOMH3AkOZRm74glfHA?= =?us-ascii?Q?zsSf0o+K986hd0rwEjg3gwcrPz/hcZp3+fLTFLqNz79wJhOIY6NGHbsCgHr8?= =?us-ascii?Q?+DCR1H/uTyMu4S9wEPaTGDc1oM3kHSOmMOvnG/4zX+44IZRihKtUZ8ZBb/J9?= =?us-ascii?Q?PwSSeNJRujOvR284HJX4bpDDJ0CT0Aj0Xe3UbpenMrPutYuCNXMv46xa4wmp?= =?us-ascii?Q?KJKJAyubMEj249hLWFtCcDCo+zW546L8ME88QLt69bmgU?= X-Microsoft-Antispam-Message-Info: tKBU3YXj4OyTMyDNydxPJQG4J9VOSJMKWfXXEfNFQj0tOzySsyWCa15bUgiij7xntsd1gXEI9R7fyLuj+EHpUNmsCa1CtRYE7/mTu4WCnBrY8omhPKfiPeyR6f400YBnSiIf14LsuDiP/AyYBnW0FpwRLuJBZGnP2Q54JJS0HQmsXku3doJQc45Y+zQUd6K0 X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 6:d10o+zeTSpkFwatj/vXejIBW7nw6A95UtpFSCplqGNHmgoMCoHxAEjBB1sXPa0P/SvyqGfO+fPtNyuZijrTnTydcR8QUUEN/TW0l9YoMnmQtQGcHloxw1cLTEZ8CAete+S5xzDas5oOujFqXWbDDW5j0+u9wux9XSYXqss3tBCpk+y9Qt9dHikJGv2w0h62W+/0MpX1dIW+UlhMusJnFSIOn8I7XpCzAP6SPA2+vNsD5n4t1Isy34W2eGB332+ST0ENi9lXq9lvsiWarAHRmWnSt3fYJaacBjo5aqJJyFLNqMJiYxVtmvr+EFpZYlWBEKptqTl7Pl7LrSev5/Ee6cM/+c8pYMaTVfFJUVAyDy4XsFtNxE9C0lqCXSz3bAC6Q72g19TmWDuLyovpdRehQF1zGy61mcYtsEw79QUw9UXSlh/PAmD5XAMJJXP7H2MRNZqOv/VnIr1CsQJufJIC7vQ==; 5:UpiXLpZ4Dy2QKOHcYMoEKogrp1W6ZaizLRGlzDAVtu7gVvXHVPTl+j78DBLDr2Ypp1D1I4rYALzQq91xBsN6aMN2fyog0UAjKG4mdQw9psN5KC28IwH3Wu1bfk26YI8KvrSHjx9xzwgNX6xcDk+Oe53lLqaw+8dM8UxXkaZnhlc=; 24:D2cB3B/N466R55lXuaJYa3hjizLzHQHmHU3eV7kT5FdHuuACVU7/Y1b6EX9ChsAE39wDNThF6AfLZOPOBkIVmNvl18w/O/9C8j6PQWJ3XMI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 7:4lbfyr+M4d9pTQiwhyec3mHpdfliAJSb6n60MacnIYgHhHdNV4M7hfbO+/oN4rDyGu/ObhHOVSAhyCnJDxPvMCSt/5PjlUOgv42WNXXl9k96IQNbhJS1dey9Hvbyf9PRkFme34SYTv/v04EcToVa62yPRI/mdHKw7BrCEyqlCpxpiuMIHIt8gZ9NxQ3w/LqWixanT8VgTO2w4XUG5G9r2APD2GQK2yekaHU5VEQ4F5e2ao4tDipKUnBlxXHDYM4q X-MS-Office365-Filtering-Correlation-Id: 21af3e13-022f-42ec-268c-08d5ca792446 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2018 00:13:17.6691 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21af3e13-022f-42ec-268c-08d5ca792446 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2036 Subject: [dpdk-stable] [PATCH 44/67] net/mlx5: fix link status initialization X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 00:13:20 -0000 From: Shahaf Shuler [ backported from upstream commit a85a606ca501296c81c4b3a5e6b359c7ad7e0a77 ] Following commit 7ba5320baa32 ("net/mlx5: fix link status behavior") The initial link status is no longer set as part of the port start. When LSC interrupts are enabled, ethdev layer reads the link status directly from the device data instead of using the PMD callback. This may cause application to query the link as down while in fact it was already up before the DPDK application start (and no interrupt to fix it). Fixes: 7ba5320baa32 ("net/mlx5: fix link status behavior") Cc: stable@dpdk.org Signed-off-by: Shahaf Shuler Acked-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 858a6c108..d7cf5a63f 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -1063,6 +1063,12 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, DRV_LOG(DEBUG, "port %u forcing Ethernet interface up", eth_dev->data->port_id); mlx5_set_link_up(eth_dev); + /* + * Even though the interrupt handler is not installed yet, + * interrupts will still trigger on the asyn_fd from + * Verbs context returned by ibv_open_device(). + */ + mlx5_link_update(eth_dev, 0); continue; port_error: if (priv) -- 2.11.0