From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0043.outbound.protection.outlook.com [104.47.1.43]) by dpdk.org (Postfix) with ESMTP id 460962C02 for ; Tue, 5 Jun 2018 02:13:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c0rjksYUyl0dYhyipMfn/MXAEFV2/h3z/yKKJrftZGU=; b=RP2epJ4bsg1/5E1mOxi6faXx+KApcmNqzQ8QLDxmV7DuYOutpjFgFnDi+MhHImlY1mcYgQARxlP1YMa5zZypK08g9CPcbSRfu1WtM5EsgEz6rLvIEKUeBliEhj8metn7gZPuLIEW2JqY9/GQyUXaEqMGGRpmSG1FpW58P+G1Des= Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.820.11; Tue, 5 Jun 2018 00:13:33 +0000 From: Yongseok Koh To: yliu@fridaylinux.org Cc: stable@dpdk.org, shahafs@mellanox.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Date: Mon, 4 Jun 2018 17:11:14 -0700 Message-Id: <20180605001129.13184-53-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180605001129.13184-1-yskoh@mellanox.com> References: <20180605001129.13184-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CO1PR15CA0060.namprd15.prod.outlook.com (2603:10b6:101:1f::28) To AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2036; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 3:O4n7J1H0l8AxzvayZtSo7B3u3iHgcBvpwNlWTyca7oE0sP8ueyxyDVw53FWd581S5duTMhn+sUgJVh2vucNd9f3XZFQ/DM/rFQKbx4JzBhMNHinm77H9yDwzpY9A+dssBImzBPtLWbh1NdDGTrSxoSZIzJ7ghwXjs6j/Oli8NBfYD2JglNvFq+ebOGefnmzk7/9wyx80ap+g4XVfJu5nTnv6GICW7vGZfvzT5pCTXYX/1no8iCpMFuS9c8SRWGsX; 25:9UX4VT1LonmENq9HfmwHBk8RfMLEk6XAwEzZkpSFOk7acJw21mMolbeVFmG/e7pPVspbrhRfJnSzmCP1QVbQzWuWzGF4qc4vBOngC0mJ47nU09LsJJgUu6Y15cB1AngUH6l0+FcY0gHoHJCZIbHWQ8K75XVaq5qdrI0frAP1V/O0qxk6Sf3cuUIi1kuKsIOU1DGv6POKmbq88++Ri/EAHer9zaLMVoIbuR3huxNKK82ooCQonHAsCzRrLI6Nue5fuSwkKbERjPDKd+nXIR1VBxzCZuJzc0LAOZ+i6/AJ1T8M9cRQi+MvLNsN5HEoiOTlCy6Vk7bjnfuhCEkxqLATvA==; 31:5zXxtvNOhtQix1TmNIr8iOtdAEoFvnORuDoUihu4XTOyQOAp+6K3Tth4laEmgDJBhyzEsQtgi02xJwAPT1TpaFAwv/rGPu4RFoKOhdJX+AAwgdtjIMHktBWH4mrQSYkxrqu2buNu1LJEcLHJPiuJCoQw25TJvj+T8MfFDr1OkRtkaUnu0BJuAh/o8DKZdVPWT/b+rxSVhky1lG/VCYfueknNEHy4P0KMmbyKkELUk/o= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2036: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 20:O8qucCmAxzgv8nbpaqLz3Rhq7VU46VCJ+ncWG+0LH8e9wSIUqdmqA7KxBk2zGERzdthPU0JvPWkRNRYbyk+swfVDx3giMtoID2MYKyvWGjKA2JVhIArUV5eM19oDX3k5RJCk0gQkYmlE8ZmQ7VP3Jp4ySe2065xpqSXiu3ozg4YvwSjfhgFkuSdoaM7f84MHiyeirI5zrxz8d+QzklllHcAVcLjLFWqkQhsSq19SsJHFNhf0n3R8MKJWXFr4QVqkG0qfQMYo+Tg4ZjOW5Yc8ojBdwKjwT73j4iYRH6Ixql4zfQb1RXYF0B+8uoJHAP5rwY7K9KAkjKBcby7VpkgfGWydVIgwg6u96UJG9jW3UvfoHKjl7+KCsIyfmXGMAn55KX21wSHvSePQyGiis0Td0VsmJhAwvFJVcz9KY9koqFjKzm1P9PVQ81rtSOAHSwEXv6rqYXaDDZng83kOFbc3EU26DJ8lAX2cLOomM5fz86GUgKBN5OvBdg3onZZH5oC6; 4:61dmCbWLzN22grbDxiZLvWIuJNNfx3LlMEzdGhytrRtK884BFal3UoRfYl6CYNkiIt9pOJ9PjSv6bJULGkt3ct2uUqD+Kv1mb6RQZvYkVMhPJ6bRCEe1Z+EAw+1AFAiJZeAVVcZkje+3hQ69TM7BWJ5gj66LzEnl2XcICU1t+nsQZPjtrGajdtWamf4SNxb2nJNxYxZdpL2a9Wyt+ONpiUyLDsnkols73pp34jfmdjcULi5HnCOTpLoQFi9ymx8Kl5tf2M1PcUSd80fqGnB7Jg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2036; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2036; X-Forefront-PRVS: 0694C54398 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(1496009)(39380400002)(366004)(396003)(39860400002)(346002)(376002)(189003)(199004)(478600001)(81156014)(76176011)(51416003)(7696005)(956004)(2361001)(50226002)(305945005)(2616005)(50466002)(47776003)(486006)(97736004)(5660300001)(6666003)(2351001)(106356001)(8936002)(186003)(81166006)(52116002)(6116002)(476003)(6916009)(386003)(446003)(11346002)(59450400001)(66066001)(26005)(3846002)(8676002)(16526019)(1076002)(25786009)(21086003)(86362001)(53936002)(4326008)(2906002)(316002)(55016002)(36756003)(48376002)(105586002)(69596002)(68736007)(7736002)(16586007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2036; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0501MB2036; 23:NR/rypHhf7WMQf6iKLTgH2T6Yt3wQOpLFJG4hNR?= =?us-ascii?Q?e4sQ6/3xp52CSbHISCh2qd7f/eFVqsncswa4Y8QMyzptEFD2yU/ZRk7YL7x5?= =?us-ascii?Q?8OAwLQu/acBOQHMtk6YSUUV7y3tdhkP+qYv8Ky6gWs5mQN5VNW4iH6vYAXf5?= =?us-ascii?Q?QVaDX1NGTZIiCNX7DGPXEvm8Sm/BssC/g6KhxMCWFFP69NYDbmrjDeuPrSx9?= =?us-ascii?Q?30fGBlASFW34RmChGR7Dkbw/fDvTuaFdlvIa4CgODFPqu0Hwd/s+yjmxF1cY?= =?us-ascii?Q?Bg87QZx7kANnb+cmSWR+t3E4tDbjRFeV2SC97Iv1psyxaGfa2QkxTLVPZ3xb?= =?us-ascii?Q?3tjJ6KYF0r0QOBlyvE/jlInCQYP8gA19RKYrnSCcBSGKKMQYCPjQml0O1b96?= =?us-ascii?Q?r1sspQmDH4GxlOL1mlacpqX7lwYbhLGjEC/fskDFBps1+WGZ2kzRiebCFMp0?= =?us-ascii?Q?piwe9EySME/zb5WutJP3pQaitH1ulKhUI/Hsk4PbB9gqqEr0oAY5aBfQQOqX?= =?us-ascii?Q?KtXjwFsycDpxpzljfxZM5EqOamQdlswIREeXPSEo4SCvXnNru8ABoyamdJXp?= =?us-ascii?Q?9+HaTBDbEXoPTVcy6QWVLG/Og+9dY+/E1lj3Cuxke5ldQwXHK+b9Q8+B35CD?= =?us-ascii?Q?Ar8sqiL/YnjvRbH1NBuj9lP4JRojpu5+cItJUDGCp+/UcY3APhrT5lMoTPa+?= =?us-ascii?Q?YDRlXStYkynLPhMp7P2XbTds5a3R5SZC1kAWAuJzQTGwf4kcRJkN2IRcWaru?= =?us-ascii?Q?vRwqgExm5KXOAr9ccnnG2iWE/8nWk0RZovF8uAuigAv7D5CE9++jsRhz6FVd?= =?us-ascii?Q?bydkcYFf/y7B3aRnBisFrub3j5AWNYlj9O1O4b1KC5Vy1Q4hPhJBd+bVX8O3?= =?us-ascii?Q?iSr9IrAFn5hW1hCozl8Imm5tHqxBc8zGFOcCX2oSmvuiYwKyJQynmXdmzsYI?= =?us-ascii?Q?BKs2rIE+WCAhoxiOsPeR/eFKnW3K2ACYTNEh3GO93ZBn1EtN50ti4ClWRt36?= =?us-ascii?Q?5yyMFUANdwmeN48lJ6FE0gf1E5WkpDwQ+yCgW9djM3g8cyPC1K71scFwLDGR?= =?us-ascii?Q?FOSlG5RIODQJ7lz8NHWrNQhFvRVkg11HealjuPWhU/lanUIDQlZ3nROR4pKH?= =?us-ascii?Q?ZhynIx/qV6xzaJ8aS+xkevtnKJrExMwnvpW6Z1KAoDCSM0FfCXFP+28Pn8ri?= =?us-ascii?Q?4zUen5WBt7KixQX+KZBBlwNkgV5LMLikSwxD+khrB/wRJZhb7z4FpMcnTHzR?= =?us-ascii?Q?lECHbocrs1eXUQLJxU+HtZHBpjG4AGlFeco63awWSuS3vsdM4DowK8Dv9alu?= =?us-ascii?Q?ejhvQ6BQUit9BKhJ6B4v2FC4=3D?= X-Microsoft-Antispam-Message-Info: Vh0z06lqCoU3JrMNuKrEbqrTP/b9TLXuP+iZOfT5Q9Nhqe6BgYweQqIwapqJy7ZlXtkva3eL8ZQ/wQLctoqbb7lL3PY6d4J9+DJzys9UfU03qR6Re2tIF3vu3wdX2+IEulEIPt/tNjPEWjBsyhAHJSG7KSevcdQsEzZYyegUh75YM+ZKyOu7JUhDOLTjZJpG X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 6:/nGSZ/XJMHWC9QqdR0UdJM9cGrAyVTqQ6FhecOk4ViNHvfxM3juXRUOcukuK6tIO0Zdgq/9GYbPcS5yq0bHZibivxY9bOp1uD2QJiFp96qy/7Ij/0ttUMQdnaQQkwt6a32jTK4KEZlkSL8UgEDCvCxiE+fYBiamUToj5DftcjXMjJz9eVBOxUhZQo+B+iW1KfQJrhHUTBbtqvS2P06mhW6MF1p9hsMBMlIFadcHc6Jc+tRAgx6IRIPnRqDbXdeMWf5nRlU/gVzocGXTaZq9ZZoXkVRNfbCBkOVS7hFkxWBM8YOA0lKClKl+G08PX+GUe+32hgzjYLmDy3CQvq56qY8Ab/HsN7EfvEiFxinfygy2dTRAgIYAuD1BFo/u/RNnb8r+4vPVaPSrLbhPRX+hOPwgJg0Er7T9lQX9hM4Z4pXgfsr5Xo+5ebVmtaDYemXuNZ7lhd5HmyD26F5bLBbVWFg==; 5:4XWREPbcQfZlU0pRjqV0Ue6zL/bR/YR4TImVFSBVsZXyF2dh+qwe/tmxXxW70NjLwUV2ojJUgIaX9h9wGUa3FZ8+pL18uvImDPQSiYkW2+IU4MArmvFHr/5u0S5V85hl7qwDjYY41dh4RnfFwbMHcRLy7D/AfbP9Qf25ytfel4Y=; 24:Agpiqk+OgmTBtnwVuNMOWsBNJ6aMhvmJNnPe8E6nxyCUOJDzzkBitE3GgzWjv5d9OOQp3WvOQzUeaxma4PddvyPYWsriQqt5LK2yypXxMCI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 7:I+Ti2LKasMQau1eus3QJBPEcYiRPlU6FlxB47u/PhQS8Wf1WnHibv6Gl9xBnofXAYYIRSg5YiI6bzjE8pZ4Fc6CzsEo74CAJA0dYvdk1daYD2ChbYbfhbyTze3cxiO/8YuCPySH8Yg/3PGnOx5ruEqKUg4IOM2tiV5YhJte+3ykttTNFEyFMO/9u0lGUShbVcCnVYPs/2m6lOnLcsxukmlLJcfWibGyYaiJK4FPm5wiScdUm/ObC6jtxAilxslHP X-MS-Office365-Filtering-Correlation-Id: 823f0f9c-ea58-44fb-066f-08d5ca792dde X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2018 00:13:33.8421 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 823f0f9c-ea58-44fb-066f-08d5ca792dde X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2036 Subject: [dpdk-stable] [PATCH 52/67] net/mlx5: fix ethtool link setting call order X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 00:13:36 -0000 From: Shahaf Shuler [ upstream commit 7d2e32f76cfccdbc565738a9bfb9ca4512e7f238 ] According to ethtool_link_setting API recommendation ETHTOOL_GLINKSETTINGS should be called before ETHTOOL_GSET as the later one deprecated. Fixes: f47ba80080ab ("net/mlx5: remove kernel version check") Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index e9e56a2e0..5edc75114 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -692,9 +692,9 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete) time_t start_time = time(NULL); do { - ret = mlx5_link_update_unlocked_gset(dev, &dev_link); + ret = mlx5_link_update_unlocked_gs(dev, &dev_link); if (ret) - ret = mlx5_link_update_unlocked_gs(dev, &dev_link); + ret = mlx5_link_update_unlocked_gset(dev, &dev_link); if (ret == 0) break; /* Handle wait to complete situation. */ -- 2.11.0