From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0043.outbound.protection.outlook.com [104.47.1.43]) by dpdk.org (Postfix) with ESMTP id 00E008E01 for ; Tue, 5 Jun 2018 02:13:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fsUi0qb5YvB2H9hAWVTTQYNh8D/B/dTHnY+8CvtQyM4=; b=hML3H7u76Jtq4SmA8s0esdLpm82S8NUtJsY+Ib8cggNdpr9QBTsfKH2M2BpfWEcDWfxxGfx2QqMGx7ozSHWoIp+wb5L+yoWt9hbvCrWsYRrW0W5JlAjx8DFM/ILX6bnehapgxMNzcGP5rfIvo1f4iK4rMeqYSpv2U9ery4i4N24= Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.820.11; Tue, 5 Jun 2018 00:13:35 +0000 From: Yongseok Koh To: yliu@fridaylinux.org Cc: stable@dpdk.org, shahafs@mellanox.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, Yongseok Koh Date: Mon, 4 Jun 2018 17:11:15 -0700 Message-Id: <20180605001129.13184-54-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180605001129.13184-1-yskoh@mellanox.com> References: <20180605001129.13184-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CO1PR15CA0060.namprd15.prod.outlook.com (2603:10b6:101:1f::28) To AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2036; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 3:dO8vRuBVQ13k+v7/3bHA1ydEDlo9lPeHyzq/ECK7wzzk+Cln2MFBWTc3BTrGGw5ugIpw8s7cMM2XiYRJq9cocUK9s2PllO+LurT6mRKcQlbX50wnIGdck+HW0j6peiDkkLRyTzIF7pj2n003xfrBo2TgAlAbeDZZ+pJ0V1kiuxBwLAS5gRyofyY8GYOlc3z+76wlG5HQwrcPC8+O11AT21IbWKeuBXvLXkSSU9mZSqXrvZN6KLMZN837LenZV2rt; 25:F+nxcOyiiaCbdajlGSgLQCVjcRK2W5uNULo4go/P4D/rJnlvpHH4HTp/P3zXf9U+iIZqa/6qbp5lV4EqY8/whFjaP6cvZJWkB4B8f6Uo4irvLM30fWsvKD3vW23BO3VKdPGzaSwtDaavOmSIQGbfb+TwlJufChAN7dQWiE42bN10tVKVIlDXYHUw8Uq5QXdVnC7OkDIqRk0Sc3bqOtjWHgLYZtXjN4S/oQunpjxFlFpdc2eUrjY1eRPKU5AZ/I43pgUPhfYMmL1dCDNVhhKgMSSSWlwVABzs6GwKTWk7mXFMzhRGH/VHlANzmjW1d/ARO2TDdfej1OULpwbiIvVZow==; 31:ChRI3Lm0AcclLw90GbINZYgVZVFZXJQIaYW9HX8hkzhyqNhBdysHIFrph7QtU7zBMUpAfQZtZ0xYY9ezE588wgF0+LqSve5HpLvWX/9APUr9vpjxuEVXl5Pye98C38qx1AgwTs5Z2FWAtnbxpSk3vRl5EnkQs0VzSuyKQQVYV0CxQwCqNoKFzHYpkz/ILMzRXhFdt9XdX8HrCsnKnjFyzLQi4RT8RSkNULBLj0uxVlw= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2036: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 20:WmlJZHYk8K985chXeraQR/WSSK8lmhNyTIWhFNZiCQO0pydz+oB14TTgNmuawpQOF2IDA7YbBVXqp6fvv5EZ+E0OmxVyPvam//lZ6p2fpl2HElusx4aI+O1Wku4lF8/apckZVkLKqTRRFetsZwnGmmyvypvA59zxwsHd8SEVGV8D2NtvphHtNBIbd+h6fZzyAuES9JkQrX1cZIawmqvz0bhp1gzZJT6JNkKCEVsBuiAdRqRrY04tW0g7fVkq0LBUw7qOebB1epZ2Ro8s7lJ1iWu2YFN9BsT5m5VQxmLSuRUtttmA2Kmt3RjnmFOKcrypyAQiAgiu4Xokg2ViP+qhPd8pIJZH6NZf8YWMudJjrqvYp7NWnWJWapVHensDcMUoEXtfVyg3JhFagpi/cMp9KliBw4DeRlLRmD/ckyPFBohSrOZPocMz7Z2pjG+O7S1w5vY/yst2hygAKhDRqB6l55/cvwdaMeaaQswA/l5HoOnX0x2WXvLnPSY6+VtS4Qgf; 4:Die2AvnkoT/390KZ2JVUn66qRdq8crIHHPsr4b4H9BMocjOFv07+KKmj07VCb4/pRpwaa1a+QpM5nvWL1eMZEXmmtSSVPe5I6+oiI9hPaAt+vs6bGBtQfQkVTqoB0v3nIBBb06rK3IOOaR6qAmnKj6Q2CVkhHceI8svrik0axqc/ESoI4SOSDgOocr5zUHX/c3VTvPTpKsH8bSLSuIgVVV5FYSh5w6358k0MY/b7rbuJ7fbpbvUT0nnnHnO/k7a0YXgv3wBZwoxLiHdPJ9rn6A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2036; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2036; X-Forefront-PRVS: 0694C54398 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(1496009)(39380400002)(366004)(396003)(39860400002)(346002)(376002)(189003)(199004)(478600001)(81156014)(76176011)(51416003)(7696005)(956004)(2361001)(50226002)(305945005)(2616005)(50466002)(47776003)(486006)(97736004)(5660300001)(6666003)(2351001)(106356001)(8936002)(186003)(81166006)(52116002)(6116002)(476003)(6916009)(386003)(446003)(11346002)(59450400001)(66066001)(26005)(3846002)(8676002)(16526019)(1076002)(25786009)(21086003)(86362001)(53936002)(107886003)(4326008)(2906002)(316002)(55016002)(36756003)(48376002)(105586002)(69596002)(68736007)(7736002)(16586007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2036; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0501MB2036; 23:F9TSHStHHJcqWApDoISG0XlIkHkecv31lmt+2N1?= =?us-ascii?Q?Kop1IxP0Wy/BBlm2GDts9n2CCxMbTu+yRlZpYTgDC5NXKpxpq2u0xrb9OLNh?= =?us-ascii?Q?ec2K+LNZaATQR/ToI4oxJu5k+EEBhemi0CarMcNlB21hfpREJh+pU8p2eGCZ?= =?us-ascii?Q?dWT26CX/RjRfddwUSUVBinGNhZ9F7zVvc7Au3gvYgWz2XbGleDKAkXpJOLF1?= =?us-ascii?Q?4NpzlZo1+gmRBfctwZ8QfmuZ27NNFV+VjcS2zf/dKhGExyzVPnYhQiPzT2nL?= =?us-ascii?Q?3j3mR7UatQX7x0uMJvUQ6tXS4ij2JUuRz6dyrWiQFFoaMaBg+j1KCRVyOw9P?= =?us-ascii?Q?SzYFlFYQSUgBi877XNTEFnp3R7c7ljpLrGEOUnDc+VO6gH7jwmqS7ZPiLgxo?= =?us-ascii?Q?0CbC8sB3UXVietBzf9rPpjgIT6DKUZ61td4GwPagbiwfQ1aA+VSj29E10jCA?= =?us-ascii?Q?xA6HH222SyWyZp8m+YL8NhrXClTgvMxB2AdCnQ4DI5JKU8enijPjeIdPDiTU?= =?us-ascii?Q?Pm4pgBbwgKIFxh/QrVwT6V3ASmhkn24XI9kNSixDyyqNbtQZTx5fRpxC096z?= =?us-ascii?Q?272sNZ1EA+OWRIOFk/x8FEpt8gt4yXHHrKYJRuKV/8o078ZVy9bwsKwxDhFw?= =?us-ascii?Q?2cQ3E1DPrBKfQRrDLCPSHIUTpotmBYR88tiWPe+ytWmRJOLFjsoD5QYueKTR?= =?us-ascii?Q?K+RBLesC/IF3Dqnx59WvEMJB2u7j4vuID3ZH/yK1MC6jVOpJygZNc9sXNoDb?= =?us-ascii?Q?Vsk5OiCWLyrGQQ69M6qRpfHXlo1nbHrNiio93YVwZrLE8ZUU5HtvgzkgN3rT?= =?us-ascii?Q?hgjLRymzSDYCfe4JDl3uxyLM5vBe8ip4PLR8D9XRtUWuzx3P+dHsr5MgBFAG?= =?us-ascii?Q?bSxzPMTC1NBEGzS2xW8BBatY7QSFc31WEBgTo4kI7oAN8eJaJgVPfXGbgEH8?= =?us-ascii?Q?BsSkR9WsOLLjixt1vNWLl7dLPAf18PpxMfhOlyInOTAXI7LG9dO09yuBVg0Q?= =?us-ascii?Q?auyH6ar5nBF/6AJr4UA8jkSAvsi1w7t56JauLDFnX5xqJUJrDTP3mUFuC1e/?= =?us-ascii?Q?2fq3poROH+Q2XsLZnCrrtOGu+Cc5PaPa79S32rg8cZsiHHQXWvH94BW0OCjN?= =?us-ascii?Q?CLT8vXTrWhlvgbqTT2JK2UG8GSMSGqniM2vtE1a62DwZCH1WnD8OCiC9WXgq?= =?us-ascii?Q?Y5sXzdyWhiJI7BWMwzlaG7euXPhz1KyqtJpcfumPa0rGdsHHr2K3ca50IKdL?= =?us-ascii?Q?AS60Xi0AurKelqd1l7Dmisgl7QKBBpKEiB5E2OgGnF4ltqpUsla2WpEajSIo?= =?us-ascii?Q?5NMCz0yDZVcNBZG5AJmK9bobsv9q5zMAyx/yDpwbyAeHt?= X-Microsoft-Antispam-Message-Info: cGFoKPg9yvdPrN1Vlum4VD1+sBEg5/oBvv5iDV4MzLi5jDVC6KtQIQqKoBVvjLgdwBU7thazXKHwUaCCzp5/9q6ew1B1KEC5LYb0fxOEBwrr+VAIetM/X1VaH67pyO7yf1uQLv6qUEKqToh5p/jk1b6J0SZ2q7FCHdOXxxhAIfRM4pAzVuTjKXswYlV0ihUe X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 6:42P8UqUdrcwuno6UmgXdbwPfflNjFuWokcs4zI4DLQlQG5JGebMQ4vwbgadFIN1bgcYQekRtzdfn8RdPCYWEOqOKKclg77e/MeqLnGE89Jh8YEc5aUFn2O+af2yDRMGsZYkSA+iJne/VPNS4EYfdL+hRJOxxUJx7IuM9O3rD5gb0ffb/E2ngsBNmt8Ljd2SJUCY2jkElQYAMzAhAFw/0nM5MqwkxoMYSlB7FpgRhJ3c4XhXQyA11LdYvrAJbv8RL1u+c/AxBuLnyOCYw9JAWOLVCYpr0ZXpVTRVr1RYke7jIzjVav5JepFcaBW0nAKyrjNoFKa0GiZnMagedOaIJLt5J9ZBMO9MVKAwtpg+0DNrII0pGbitWH+JivjXZAphMIR6/L648AsvM/03ny48fcDNxQs85X6LdC/NpY1Z5x4hMgjY+w7PzID23+e29KnbopP1eIlli+PJ01q7GS4sxYg==; 5:QiE4xVXPWKR9MX/GloMHiEbXh5y6jz9UBYCPVMY0emIC+FDH5H6vaNqBHGuOF1I3nmEkPpexEVXboAyLIwTiphhztfbOCq3boL9BnQxsRBiWBgqtvwJBMakegyUb2d/XYWeN7QCfLPkqAvD7AvdTcLfR52UmNO4aT2SaSF9zCdQ=; 24:1phAW23/dXnl1qFNkoTBaKdsaQABuFj6n6B9nYA0cZHb7RPdrGsVeJHZXqXVrqOwOhN5WsbOom8/jHsCv7zeq93kAKMfkhJeodftX33puXo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 7:mnlIW5nTRcHPxZH0lxGQQStBh+1T3AE/uKYFK+gY86oUGZ7k9+4NzUuBjQcPi2+/OpB6F1tLJL4ja6jgpH76XEzmtXGB0U1icQDoTSBItC8v32MWn0CtpQGx9DnXn1kcsml+2CNa1O20gM6WdhH5uBWSmGi4lhYDgnFjisox0UOX/eMHZKcpkZNaEozTBmneARCVkzeN8HJDC53mZ0C+zifaCdvOVumE8rfmGB+e+K4KHk9epaZr5nFnwvh2a3GN X-MS-Office365-Filtering-Correlation-Id: 6bea0d2a-f15d-42ec-2534-08d5ca792efc X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2018 00:13:35.7172 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6bea0d2a-f15d-42ec-2534-08d5ca792efc X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2036 Subject: [dpdk-stable] [PATCH 53/67] net/mlx5: fix socket connection return value X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 00:13:38 -0000 From: Shahaf Shuler [ upstream commit eac9cd58dec1b08d241657b1a81deebed9d4db9d ] Upon success, mlx5_socket_connect should return the fd descriptor of the primary process Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") Signed-off-by: Yongseok Koh Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 2 +- drivers/net/mlx5/mlx5_socket.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index d7cf5a63f..ac43d80aa 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -827,7 +827,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, goto error; /* Receive command fd from primary process */ err = mlx5_socket_connect(eth_dev); - if (err) + if (err < 0) goto error; /* Remap UAR for Tx queues. */ err = mlx5_tx_uar_remap(eth_dev, err); diff --git a/drivers/net/mlx5/mlx5_socket.c b/drivers/net/mlx5/mlx5_socket.c index bdbd390d1..7ab310007 100644 --- a/drivers/net/mlx5/mlx5_socket.c +++ b/drivers/net/mlx5/mlx5_socket.c @@ -320,7 +320,7 @@ mlx5_socket_connect(struct rte_eth_dev *dev) } ret = *fd; close(socket_fd); - return 0; + return ret; error: if (socket_fd != -1) close(socket_fd); -- 2.11.0