From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0042.outbound.protection.outlook.com [104.47.1.42]) by dpdk.org (Postfix) with ESMTP id 77666AAC1 for ; Tue, 5 Jun 2018 02:12:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=avPABMOKiLXoyfOI9pryqNYuc/jC3we0hpgBH7aPNiI=; b=Tm4w0SK8vee/EBpkM50A+HGjv8boPrG+6jJkuxZNB3u13OI6h+/FIPdGUij+yq4WEoFXfhbWHI//lLaZ2odVOPJLghh2cKj+AcbC+1F8Nc3FTNZj6tWkVo+CsaesDw030GTbhkk3tBM0FwgfElQeiD1GJs/87YHWJeMxtcirFWs= Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.820.11; Tue, 5 Jun 2018 00:12:00 +0000 From: Yongseok Koh To: yliu@fridaylinux.org Cc: stable@dpdk.org, shahafs@mellanox.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Date: Mon, 4 Jun 2018 17:10:27 -0700 Message-Id: <20180605001129.13184-6-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180605001129.13184-1-yskoh@mellanox.com> References: <20180605001129.13184-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CO1PR15CA0060.namprd15.prod.outlook.com (2603:10b6:101:1f::28) To AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2036; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 3:OqZSTYBsqbCSQzAy3y6MCC5n3W+dAtvKg87C8UZB+a1yswQHA9Q/sXd1XpSpk38SdwngKytGzCC4Dg8TZMigGiAhSMaIzRWkb+8LecwQ7TSo6aJOWXnXWBUgsvvqz7DwYFG3GKs4xtHKZdfXG5pghP+aqFA973uBX7Vb4UPniRAcAA2wA3KvE6PfCSxtZtzQIWY+QUSB6WyD13Y4TAJ2QXXdDq0dJ6ekQ2eoinTiOAlsYMEmmrNxTuy+AqRziOgN; 25:z6SdBujIXI326xgSKx/RYeMQatj4r2Ax+5wf82RZE/we++0MKHSsveWZpQsrkx6VGqRrNCiiid0UgS/EP+u3IadtqmTM/7zY1iNQt80CK1/KJ+N/fyx2f7QIVsYxR9L5VNtYB+HCvdjaSaoFKx/keQRxkhVmDVFA2y+cgSfrGvim5majaYWuu/WwIwIycMF0UWbYZ0fule6p+O0qU52LZs2PbGN1StnFLJ9PZG/f5AzEjirNKMOWnzmaV4a4qWo9+JwQMIAtgrfo1vhsH6u3xwwqc+6SFHYE4drEAsAJwyh20eliuaHaT1Dkp9tENEe26b8S2wscoqlW3c4nCEgkdg==; 31:IfaOvZp9Os+uPBHAjEP+IIWsgWP32MvW8iCZbIBvw6yQIjPaKmzQxBmw/36QkY7aCDRFclFXr9Y9dHneXnGbDr1ekRtzxmBW6AgwKxbO3J4zMmr/DW9a8bquEajfm2DzdOV1HLSLFO2K8YMfz68mNgvFwtZjpW+8tewklEU3eZas/4cyldxOwXOrCYOvlrQL8khUjkF/SN//qmh8O1cIhI24cgLIbPKeWcXx6G6jTy8= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2036: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 20:v18NAAdw5vdMlKhN0nAWBW8RuTuRuZhkW6pkqKjI98iHHN0XYYPsFF313AA/f2dQNN9MXyzwosLVjZU1jOQad2aFXStExsIz6qZhGJYtGYDGi3d7GxTnxXxi1CXwTi2GsBBwjmUalF/sxzjLgNsaEpECoaC1RFQsCo7BKlCJWOgmmj0qbqXWqMAiZc8zWDIFxHsJSkmULFGY3+QvAGJbqgi4+6Vbb3iPtwIG2NZDabACNOcKLn2qEpM1YvEHNCvUHk+lqqceM1u9y3cx/4A49q9wR9rF16o/d87SDjKHZlULBCmPaXff+vg4HXq2AnF9hHqvkPsSkghfA7Gr9UoxBT0COFbD5kGARpdnmHA8ahq3KW/QtbzDt6RmauLXxKCQ1codr58NW13H4//E4hvZlQm/rT8dCzTQIUrhNVFaq7c9OFsMVtiajKrzkxCPQXJbdkX4kvLDqqxETl51PpCK/8ubB5KMygObLKEBK4ZBy5bC6yBzBfcY1vzjbHBKnJ0k; 4:jxF0jyxXSBh869VBbmar3CdoBWz4DAjrvccr04xubz/vnRCEqGK0HJ4QNqwyCa0QG6Y5bIO0EDX+xOLMDTfcP/pNJp5KBrfVSFawgAczcr07DxFqunPJ0F89GZ8iaoDdtFEz1t/mH8+wfbtqBknNPF3r0yDXHNEZTPJKasikhWp+KB8NtTvCVk9Gc9X2BcmR80h6GENTCk83IoTv0ofD35/9eF+MYz75WOZBVgNLxFAMzHxwuOTcSGch1UJsDRD4aapFsW0Lk7Id8ku6f1h5BA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2036; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2036; X-Forefront-PRVS: 0694C54398 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(396003)(39860400002)(346002)(376002)(189003)(199004)(478600001)(81156014)(76176011)(7696005)(956004)(2361001)(50226002)(305945005)(2616005)(50466002)(47776003)(486006)(97736004)(5660300001)(6666003)(2351001)(106356001)(8936002)(186003)(81166006)(52116002)(6116002)(476003)(6916009)(23676004)(386003)(446003)(11346002)(59450400001)(66066001)(26005)(3846002)(8676002)(16526019)(1076002)(25786009)(21086003)(86362001)(2870700001)(53936002)(4326008)(2906002)(316002)(55016002)(36756003)(105586002)(69596002)(68736007)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2036; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTVQUjA1MDFNQjIwMzY7MjM6MWpsdVdlcG5tN1NNV2M1OHBvNnc4M25s?= =?utf-8?B?WTF1WFFUcXQ1c2RiTnBCTm9UTVNqWlpndEdVWXFiNVRaV2E1dGRCNU5vb3RO?= =?utf-8?B?MmVEd2w3RXIrWnJtUVc5WnRqM3VnNjdYOWhNMlFRSnNaVzhuWGdqcTBrMk1M?= =?utf-8?B?UXVTTmJQVjFXWWFtUUZ2YjNWWi9VaFcvUGhSd0l2dys2WTBucXUwb1RQeFFq?= =?utf-8?B?blJyZkZ3NTBXUGkrVGRSektoREpOcm9FVkpKamZxTEY0TEpYSDZqRzFmbmNm?= =?utf-8?B?RUVoZ0ZyMFJWS0Z6OHI3d3FzQ1ZoUlpYbTV0S1hSejBtRjZTM2gvcUpUR3Qy?= =?utf-8?B?TlRCekJzQmpBSkxFV0cwMjEwR3FvMnFicjF3eEVlTnp3MWk1UEJ2MEszcFBt?= =?utf-8?B?aXpkOVBiRkJzUGFJOTd3OEJLeHVCWDVpUDZ4dTJiWFFCQ1pMdlJlTUR5dWFX?= =?utf-8?B?VlRwNHFLMkVzN0Y3STY0eXd2MFdIbStISXEvQTBMLytLMjFndDVudVJVdURR?= =?utf-8?B?Rk1wMk9JR0VOa3hhb3hLQkVTbTBvcEZGRUVlK3I1Q296RTdGOHhlcjJpTDN6?= =?utf-8?B?M2JEVFN6M2RSczMrOWJOMnlDOExoc3AwVVdjSzF0S01nNXN0NzJXZmVNc0pw?= =?utf-8?B?RnJUbHQ4c2hMbVNsR0ZxRDBtWTFYMXlGd0swbm1zb1VRTDZKb1lncWJpUGtU?= =?utf-8?B?Um1HditwRVI4N203Vk9lY3Y0TXh5dFJWcG54ZTBaYWp1SkJIcnpBNXhVem5t?= =?utf-8?B?SlhJRC9qSEh6SGZUWUZ2d0VqM2Z2VkllVUlkYUxtaHhqQi9YenI4YnFhMWp1?= =?utf-8?B?cFJiUGllMmc1UHdrTERFU3E3REVXTnJ2Z2xjOFNCNmdWZnNsQ01uaVMzOHZp?= =?utf-8?B?aW00Qi84eU1DWVFHZFk1NDBwNmdkQzA1VUNCZWNpU3Zyc3BrbTZFVThLaUFI?= =?utf-8?B?UW5WZVRUc1IrNDM2ZTJSL3VFVHpHbkd5YUplR1VUcjRwLzU5c0c5Ylpvenll?= =?utf-8?B?c2hoRFpteDdDZjQxdk8yZnp2S0ZncTJjT2dURThnbWZJQkQ3R3o4VGxoZ0Vy?= =?utf-8?B?SjJreUtvNkdQRmpWR0pJdVZpUGtHakRmT2d3ektjTVhVTE9pL1pPOXYrdm5p?= =?utf-8?B?TnVaY3hpMnlmcENoVmt4aVBFemVSMGFpOVNLVy9Ca0llaEIvZzc1aXp2bHpk?= =?utf-8?B?clRReTZ1S2w1QVMvN0w0WTlJZGZUcm9PSDBneXBVcHZLUlFIZ0hjR0RNbnN5?= =?utf-8?B?bFF0VE1rRWFXT05QVi82QUNMMTJ5MlcyRVMrNnk5THdicHRYYUFYdnJpSXV3?= =?utf-8?B?UVhiVG03eVd5QXBHbHM3YlFvSjZLNVdtZ2hFRWpTUlhIUVhlNVNXVkhSRHBm?= =?utf-8?B?N0tjV0Z2ZXBUV1pxZEpWR1V6UFVQYUliSFRyYmx3UnlBU2kvSTJLdXZaM2ZT?= =?utf-8?B?bHoxM1k4Y3dOcUIrS3R1azhrUFZiRUNpc1JVT1EvT2NpVWdXNWM5dldwajN4?= =?utf-8?B?STMycDhNbTBZcVlKYWsvb21McW9BNG5Ec1lhVDR0KzQ4S1IzY25oaWJsT2Y5?= =?utf-8?B?SzhsdEJuM2RFbjVTMThoajBtTG5pZGg5VHlFWE9xQnRsc3k2czNBRGFMTXFG?= =?utf-8?B?c0NSanEvb1QvU09raHNieGMyWFFiSjJUb3NndFBFQUc3M2RuUlRjMDB3MFlk?= =?utf-8?Q?wbg8WnpxnY6K38Hbc+9DQbgQpAZ2xgyaW4qPIe4O/?= X-Microsoft-Antispam-Message-Info: yNlMtLxTQJ4Yhbu3/GwW6dsr/2rnIFSA/6vrdKn+YC4DfnR6wHdAVUbflv3MSNx42UJbKDm8LIy99/4nia5zVrFcbY59SgEtk4ZskmitYr1u3runUtVX3ZTt7+cai2zDLbqoso2lxEyfJ9VAZE6AdebM7ri2Klmid2vXT4xd2hwGqO42H/ME7YpWqXcZRTA9 X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 6:hrIMTGSB5fXgtspd4DMzt4XV6Qk11tbDVoMdoXF7ARTI/3dE+HnhnmR+5Y83PxwXkg3pPCgiui7mo16niFdvpUkU4cVt2exVWl06rJ5xc61XOu6vQu0G7TTR4j2luX3uaggEz1s2ZHhv8Un7UY+Yb2bzRFdBlo4MCkXfgTQoOKHwuJygV23V93mXDeWaQP9s22I80ttUwmCwobryYSKmtXdf3IuAIBnsRCuP/ASwchomF9kqlDXiw8k2iK6HykvV/HMSLEPzB21YM3txnRdp2CzU3i4TSenIBZ3MEiJqxm/FUg9dXLkf8b1jFLbGMVnFFODk3tURel7kSoJ678QWL1vnpDmQagBEd37dww3GuUPxx7bK/tZiszwA0Zat2KvkCTl+JLBoqswpiExJXsya4b7Hgphb5EisYjd8LFbBhz8FcjKvjyqnaOglzuGpKATWJA/3d5fWUR8vcdqqIB7tIg==; 5:X8E6/610m6cNGq4GreB+thFSYOogB13Or1iTWL+0+ZENWUAFsxZjA7lGtcwXMDeCWwwh/llJc/UpkB45y8xsX1A6otnVNQXQKM2a/9d1hojk/nYyPClhIYdkWsAbBrcWjsOJzrvrnN1eSgXqmatnDfYN0WeBV94qgmyIcIIsyOM=; 24:dH4mQjECH2HTS/NdjAP8bZzw707DpnO/w7m+wFz3+3GjfwDvuXPVWUUWBexDpf+o0uK33l3USG0snMNz2fu+SHtQNIZOKLY1N/vmSiIUgzE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 7:05Baey6Pppiz+IUS4vlCIMDlpqq9aj0JUjOAkluUVo81yDQvyrNY5ttQEs0E+C9YQTvvd9qUCNPLtYiaGnCLRPP3SlY74feUrT30Kr3dbz/Bk8mLvxZKNx7C5v8yhu0zRwA8Ju3XuaXfaNl41K2aYA8ZGae6IE3m4W2U3zcgQntnqU+QGWgWYDRdd6z3CoBJygQanZhRJe7YlFLBQpLfpoElibFF2Lz2o8rfjips4Imy8IEM5zU71JZs8Qk51lxu X-MS-Office365-Filtering-Correlation-Id: 55cb0a8e-9221-49b7-6a45-08d5ca78f5f2 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2018 00:12:00.0077 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55cb0a8e-9221-49b7-6a45-08d5ca78f5f2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2036 Subject: [dpdk-stable] [PATCH 05/67] net/mlx5: fix flow director conversion X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 00:12:03 -0000 From: NĂ©lio Laranjeiro [ upstream commit d10f422fd59a7a6d01da1b2a79975e9776fba840 ] Flow director must provide the same spec and mask to be sure to be validated. Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director") Cc: stable@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 3a9407b00..76c4354bb 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -2650,10 +2650,12 @@ priv_fdir_filter_convert(struct priv *priv, attributes->items[1] = (struct rte_flow_item){ .type = RTE_FLOW_ITEM_TYPE_IPV4, .spec = &attributes->l3, + .mask = &attributes->l3, }; attributes->items[2] = (struct rte_flow_item){ .type = RTE_FLOW_ITEM_TYPE_UDP, .spec = &attributes->l4, + .mask = &attributes->l4, }; break; case RTE_ETH_FLOW_NONFRAG_IPV4_TCP: @@ -2671,10 +2673,12 @@ priv_fdir_filter_convert(struct priv *priv, attributes->items[1] = (struct rte_flow_item){ .type = RTE_FLOW_ITEM_TYPE_IPV4, .spec = &attributes->l3, + .mask = &attributes->l3, }; attributes->items[2] = (struct rte_flow_item){ .type = RTE_FLOW_ITEM_TYPE_TCP, .spec = &attributes->l4, + .mask = &attributes->l4, }; break; case RTE_ETH_FLOW_NONFRAG_IPV4_OTHER: @@ -2688,6 +2692,7 @@ priv_fdir_filter_convert(struct priv *priv, attributes->items[1] = (struct rte_flow_item){ .type = RTE_FLOW_ITEM_TYPE_IPV4, .spec = &attributes->l3, + .mask = &attributes->l3, }; break; case RTE_ETH_FLOW_NONFRAG_IPV6_UDP: @@ -2708,10 +2713,12 @@ priv_fdir_filter_convert(struct priv *priv, attributes->items[1] = (struct rte_flow_item){ .type = RTE_FLOW_ITEM_TYPE_IPV6, .spec = &attributes->l3, + .mask = &attributes->l3, }; attributes->items[2] = (struct rte_flow_item){ .type = RTE_FLOW_ITEM_TYPE_UDP, .spec = &attributes->l4, + .mask = &attributes->l4, }; break; case RTE_ETH_FLOW_NONFRAG_IPV6_TCP: @@ -2732,10 +2739,12 @@ priv_fdir_filter_convert(struct priv *priv, attributes->items[1] = (struct rte_flow_item){ .type = RTE_FLOW_ITEM_TYPE_IPV6, .spec = &attributes->l3, + .mask = &attributes->l3, }; attributes->items[2] = (struct rte_flow_item){ .type = RTE_FLOW_ITEM_TYPE_TCP, .spec = &attributes->l4, + .mask = &attributes->l4, }; break; case RTE_ETH_FLOW_NONFRAG_IPV6_OTHER: @@ -2752,6 +2761,7 @@ priv_fdir_filter_convert(struct priv *priv, attributes->items[1] = (struct rte_flow_item){ .type = RTE_FLOW_ITEM_TYPE_IPV6, .spec = &attributes->l3, + .mask = &attributes->l3, }; break; default: -- 2.11.0