From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0068.outbound.protection.outlook.com [104.47.2.68]) by dpdk.org (Postfix) with ESMTP id 4241A2986 for ; Tue, 5 Jun 2018 02:13:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Iihz/lRYc9R85Tf+N7mesP8tcg365iC0P2WE4sZjy1M=; b=WoQoEhXeWWy2CniSlMhnNLBWVyHcaweDZVgXLSK/QQhUighOUia01sVlYTAfdijDGNRaLDSu8+wffm/HsiDTkWQMUhSbvBz2x4AKG8fMLdeQuLEN3OUiZZokk7sjFjpWTNu3foBmYuBwLsB4xksmHpYw72Y2s+X9DZmm5ye5mZU= Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.820.11; Tue, 5 Jun 2018 00:13:47 +0000 From: Yongseok Koh To: yliu@fridaylinux.org Cc: stable@dpdk.org, shahafs@mellanox.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, Raslan Darawsheh Date: Mon, 4 Jun 2018 17:11:21 -0700 Message-Id: <20180605001129.13184-60-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180605001129.13184-1-yskoh@mellanox.com> References: <20180605001129.13184-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CO1PR15CA0060.namprd15.prod.outlook.com (2603:10b6:101:1f::28) To AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2036; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 3:Icz56DSv5pPioz6CuS9I8t7GE0Rk7dCtyi0Ldyt5YNxjBhdTt9uhXDmiLiwjXSwWxjx3OkfeAB9ttMwuQe7I8EHO08odu7oV+/zpO/TC/9tl2949KKq3pOqBQMFwTnw18zA55ECrC40zF+kGKAEtdQ6fPYP5CsEdWLumokUmeV4dx1t6uq+KTYxl19JjoDdAIYImAklhlMGOUU2pVTrDp1OIlWGnIx91ZWAoYz5hbnIzNbDF95elCAYLBksZfJnd; 25:TSB5AoredJuhRs7e2tBChhDeFSYbm365zMwKLp5hQZ1ibvr94c/ZpXPz7jaa4Ks7PuPzsJd0JYW8hJQk8MhuEaKdlcf2dv02MRebXJXNeVUjdpGzY5gbAHxgM87yqNf+hVGULwecqQFnw9WOhddn2GmhAoFvUvYCiYJTpTu2/++9nFM367UcAZr92ko4mu3KV6riBRK21jYLerp++PVaXhuv0cVNDXq9JgZ6m9RgcNxQDjzayF5/owhWNbwUpK18Uy/1+hHggWYS297Von7Sn5fhtts0gs+QQNhCMBrWcMcSXV80saK9hG6WY+DceOe7vLOXg5AJ/dR/TX4W7XCM4Q==; 31:d3RelM2MvOIIbgK8h2v6D3+KA2kdheX9paRzMSJQ3SdCUpilEdjsAx1ria8NNBPM5u/0K/ZQ8sGxByMA6h+SQaYzdd+MzxGaJPtEEUQGrVB9IHKCLrbAsy/W6sDu37tHRDatWDS0fVJsQIOEcb85arm8P0l6Uk/YDL4lHGc5dVwnT/+dgMTJ8jZ8uyZfJ53X/yYjwy7t02084//ao5UfWtS3QCWsPyjH9uP0P2wVo/0= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2036: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 20:qNOqXtgXRW0mzP7It7BNzMh/UYWAVimk1CdSmluQzvYeuGH5tpWuyiJFh2iOjMnHOpSgJfDk/2PHtpWHJb93uudPuVP3eEkwVoXkYl4wNV5dJES9wx38xekr76H6/vlPQD9hEpiwY1rJlbeqKqsNiRnuPN4+kk6gfPTtEsllWAtm5VsgG5uqnK6p08MHoU/b79/Bw9P49d8u9a2amVYxF6W9YNlF+0ty2GmcaaIaGngeq6piBcIglneNlYQr7kb10A+YEXHT6AquA4CBYK0nvl6yhs7tDUr+nH3w6TZdcMlLu7kGsQcDk6xWwtk5dozHSnQGAy3hPgX734B6Cv3Kg+bH9sPhG+Qikt25C3e9Wnkbo7F4nbbepiGs2WdeDx1FxfkMjj2irIMQrgtKlJJz4BtjvlbsWX7UQshixTTHiY6CI1H/1RztXIZvW3C/8ymIaQiZ0bU1SZ6hDZNKVNF1PLrUHtSgofEkeXm6WIsP3Eb7ffcAKd0Awt4ThMhoxkXy; 4:mYx6Zg09fBk+xdlu+H+P/bAEaiWzZsvE+/EpP+wU8naEc74tKqtkvfpZkC21T60jguTlMBc4YCVk2z7TxectP0bepP+H21Hn5j20rE0G7HIHkr4iZh+GvtbBah3t3maE5AsBx6+TSOkZKdQvg/h6TeWzacV8v0v8Pms12/tWwY3hpBfj9WKM7BJVHQEUPxhLbWC/cPh1RcjDhdasDaEEHdNdEWGv1CgqStFYtzKjY6QXCDisNg6fu7ehiSjwgXkQdGMhFzhTRgy1/Q0ZiRcn3g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2036; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2036; X-Forefront-PRVS: 0694C54398 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(1496009)(39380400002)(366004)(396003)(39860400002)(346002)(376002)(189003)(199004)(478600001)(81156014)(76176011)(51416003)(7696005)(956004)(2361001)(50226002)(305945005)(2616005)(50466002)(47776003)(486006)(97736004)(5660300001)(6666003)(2351001)(106356001)(8936002)(186003)(81166006)(52116002)(6116002)(476003)(6916009)(386003)(446003)(11346002)(59450400001)(66066001)(26005)(3846002)(8676002)(16526019)(1076002)(25786009)(21086003)(86362001)(53936002)(107886003)(4326008)(2906002)(316002)(55016002)(36756003)(48376002)(105586002)(69596002)(68736007)(7736002)(16586007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2036; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0501MB2036; 23:DXrxioOZ9depXmuc3mX6ERtpGKNryLCW17AUW/g?= =?us-ascii?Q?BbHNmxpCi5Io6PPVzVKv/dTUO+B/1+q9UnOXylmBB3Cugdw5C0HNHEOQE1My?= =?us-ascii?Q?Ct1oNs9tyUfHaCqXmSk4+ICqvDQNRLjIeZL5+Kt6YQgIdHWrjY5m6aDqmco2?= =?us-ascii?Q?6HIQJbjWbT0UlYdXKSqN/XEpzLMHBmSqqr7QaK2oyzM0UiA3ex0NvoZcU+Q8?= =?us-ascii?Q?iCeGTkiw2t/WoL/PzSvpYwHUgt4LyEybreiMUXRapQM5muAiaP5KJK4WbcYe?= =?us-ascii?Q?buA9tI4X93p1Vv3lOoSOR1XDqowtp2VTt21qwuqfv0L6xwbOKOQuDp+B/par?= =?us-ascii?Q?Tkd21jB+3iDlfCpDUNQnOVsEtyX7ZH37gZaJmwfYS3eS5LH4so7cx260KHbU?= =?us-ascii?Q?0UM6eEi4vCctIkvi2ELPtAEGtrrKX6HVl+HGJ7O7ac+1DjVBx14PXVjBRV7f?= =?us-ascii?Q?jvhHBpuru98E72Yn6QmEEsXRVHv3i//IqzUVqKDnJx8DdxXZ3CsUPs/Ht4+P?= =?us-ascii?Q?s4o9ja/Ci/RrnZoWYwSdKJXRKvjy/qR0WpWojDGIM6qVQOBKzn4HTPYVuzAJ?= =?us-ascii?Q?oH8qFGzaaAMgaGL34eMcnKqvUF7GYKZbDfiF4jiTuoM/yPp/D02fw4qTYBrJ?= =?us-ascii?Q?is9su7YyEkeNv9ttcTSEVmZseoAvpG6jLkpYM0IL30ymNdNVLYaWJ5KThjSe?= =?us-ascii?Q?hBSsrpv/JNi+c1pYnqx62Ot/EzYuemCVbqp8ecdUKA1G7NfuGo+BcztCp2+Q?= =?us-ascii?Q?XJtO5DlcTdg3ZcOeVsHxd8e7uqXy526RLVmzH32cuzo0FWcwivuVaq0FWFwB?= =?us-ascii?Q?4rYhgPfesRAfRMX92k9yKfAo50rqG0wxmUdIUxmmzOFL96lGqHW539hA4vZv?= =?us-ascii?Q?h/xxewPJZDg+ku9MvBX+t9VvYQUd8BejI0FSAlIkBFtJXehoVN0MykU1IlUS?= =?us-ascii?Q?oWrG2LkGW1oxe6IbHpqS9SgZ9dUjzEll7Z1WRHYHnVTHpYPVkU2H/LNSeL96?= =?us-ascii?Q?FIQEyviJEzfYoMkR65vlIaIpEllO4yOHLo8N8a//ux2nybrq1v5EkuEGX8q+?= =?us-ascii?Q?p/cXQec6E9Zh61w+1kXOzaSRg4PqtBVHYpTrcERLD790ztMThl43OwmYByMl?= =?us-ascii?Q?j7gHWJpA2p7GtxP9U+6bvhYVUYAPIL/44h40iligqQaf6tVGHE0/hQCSWSRR?= =?us-ascii?Q?/3NwBd9yOSUR3A34/59ZVKrcKP7y9kc4LLCx2bXUj/ZJB2UpW8l+hAduCn4b?= =?us-ascii?Q?1zboWI/niSQTs7uL+qA9rHTih4cY0kS1kwhL0BLeoFBUJdgIac6DAHyL+NOU?= =?us-ascii?Q?ysDP9Sx4EgBjr+wKfzqSuNViUVdIRn5TaZV/IHGenutJ/?= X-Microsoft-Antispam-Message-Info: zcAHTzdY2Jgwc62O4sBC6ptXgMnnqMnf+H8xbSgUYAWXSljJV7EZ39cJm6wpikZS1LdN8HKx+T5+fw2djAfpkZ1T0x1ejQ7Z3XEcQ4g6UAY7gVWu+QVMb5yuCFsyYtYuF7JqTuDy1DG2WkXJwoweSzz8JJDGlpbqFV7avYs2lcZjFymDdHDwtmFOjCbT3/v9 X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 6:DxhNYtxiw4TawhhAD9gyrXshtQPn++4eM2RZtw7kSmNMkrCq+hiRSRsIwpN6dyDrCEAjcxVBUyVOKdDHkYJ1Gl/12nNOKtpQPU2Q9WqwkX6RpreWyQ99SI6cf33dIGpCGx0kdR9FSY1qD9AQ8aKSnS+/Xf5VmkwlBLuNIOwsBpd4QgNFxmStBWMeekYjPevPKZYZVulJ+4wp5fbh3nf2W+Dh56GhX5ncPQzP+aMcBIXwMiY8rdH1ibJkriqqyHx5zgVaIiKTZSf0+Ykh6wrghz7Ic2Mn4IBS71IiNGE+6PgNjk56ZiJWZKBg8n6TjaVy2ObLy5zNVWZUEM0hsBlMK3tG1yYJBk+UzC22B6rhfiUUpQ0yb9tAVPj27Isks7CrGYlGmLOLzN7dP1JAbl7ML9Sq1l1A7VBnVFgbMgB5NTLoVdaeqC/ZlGJiVI0e2783oS/mgVZYb/V0hct0REKMQw==; 5:SC1pdw2eZuf6RHJQmZJqt1ealS8/yZ3drPAMQV4Ti7VbzLMpfFf/cHsggBfi87gRQnKxxwLjd7hgVALs2TF6B2WPqY+phGrtiCMtneQvOD0IC881ShxWvbFRZzllDgWQGdiaOs28145EnQQLbe0mmBzfsEOS9gz/gKs1xvEqSt0=; 24:QxN+EPu662kGExq946afFOdmk1+mOvqsZYFkoDSelL8z2s0acFw6lLiDYlQElrXe2/zPZoKnfVLlXOEuLIChpGcnyWeJrKxJdh1UNLYh2J4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 7:uQ4RsUwQymQHYdfrAAMke0BFpoNUCPgT7T/KaQeKchqI1EIM0d+nM9g7rzUzJzbL4+QIfyXh0SrMBL+8squbK5ru41635QfXnWRPASKJF7wkX81cWD0JvZXfCEhSHf461RHIAOZjeqibmx/eK3CxoG9TQr77W9KgYcOO/+goQD2spobuKK3Rh/ZQkKSSW6qg3jIdFv/Qi8XI622LuxYILY40zKG4e1sVjFToVFH+2g8gOUqud2hH/FMz8zM5n+JV X-MS-Office365-Filtering-Correlation-Id: 77d86c2a-c900-4c09-1539-08d5ca793628 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2018 00:13:47.5773 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 77d86c2a-c900-4c09-1539-08d5ca793628 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2036 Subject: [dpdk-stable] [PATCH 59/67] net/mlx5: fix resource leak in case of error X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 00:13:50 -0000 From: Raslan Darawsheh [ backported from upstream commit 690de2850b26466ad5325fde3e1aff040e3868f8 ] If something went wrong in mlx5_pci_prob the allocated eth dev will cause a memory leak. This commit release the eth dev that was previously allocated. Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox ConnectX-4 adapters") Cc: stable@dpdk.org Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index ef17ec9a1..bb56bd22d 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -1089,6 +1089,8 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, claim_zero(ibv_dealloc_pd(pd)); if (ctx) claim_zero(ibv_close_device(ctx)); + if (eth_dev && rte_eal_process_type() == RTE_PROC_PRIMARY) + rte_eth_dev_release_port(eth_dev); break; } /* -- 2.11.0