From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0059.outbound.protection.outlook.com [104.47.1.59]) by dpdk.org (Postfix) with ESMTP id 33DA9AAB9 for ; Tue, 5 Jun 2018 02:12:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tgIx2ymg50fhgg/VXBMsWu93nACP90YEswl6VkaiKuw=; b=HL8sm04HLeyrbgbhcItgw6yDMASzFmClY7KgdJbX3HK3k9ZEdxNoU663M2dhJSbNZCiLcjpOsKE4ekX4TFlLV/rrCVLEK08pE7eeNdwmqen2KFonatlTd8HvVii+bM91GWp/2oexSd8IylITazGYQmdNltdxIdECUXYdJJrklAI= Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.820.11; Tue, 5 Jun 2018 00:12:01 +0000 From: Yongseok Koh To: yliu@fridaylinux.org Cc: stable@dpdk.org, shahafs@mellanox.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Date: Mon, 4 Jun 2018 17:10:28 -0700 Message-Id: <20180605001129.13184-7-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180605001129.13184-1-yskoh@mellanox.com> References: <20180605001129.13184-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CO1PR15CA0060.namprd15.prod.outlook.com (2603:10b6:101:1f::28) To AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2036; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 3:9H7skzpQAR9Is/eujC0O/LggNTv5lqV23APYk8ezPe4J8/X0UnK9G03YdMg4X2+fUY/hdyHjuc6KW3PXodHF/ZZXi/aFfaQ/aQXEmAp+MX+qzmjwfohvTTPy2bBIT5tfLMZ9JYoIAlTGFU1IWY6FTPGsfdhXUzJ7KB9mWgQ382SzUC9mjL3T7DW3/bfUE/cNl60I/jmap8I2p65VNJlxAcSF3lS7GwTn0yFjZB+zyhFp2VA/dtmn09TvGe2U6S/e; 25:cQ2u9+ZI8xRyIW5Aj/mXptNgJ5wYD/zfKSb+7TaxyaJRK4MFsQ1P+AK8ZLpLbEFdk3/98+qrd20ue8Q+Z5m/8eWQC8CuxXmi/aF43CncHMqvUpbi/Jm2MfEFhmJ4kNF8MbQSAtU5EjUcKW/99gL8TnBoYcQPfdKJTYoszTTjP3+8Okpr1fkloirReVtdswqsZLtPWuMQb/KfBgj17zKtXNFn1ynUA8xz/MM7twjDBH3EGI2hIKEanDRXTkG9vKcdwOdKTOgoI7JzH8X+14Oa4l6YD5tAktKpk4ju28eZBB3Yl+rVVwCBWlMYBbcmbNsDlqcBnE2tVDT/QtyeH9qcvA==; 31:p2azCzWA9ONPSaM280KpTUbCMiDvTUGA6y/igH/5VOYVcl/+hdcr84/9MQZkAfv+aV4qsa8NtEYSKRqNNNJWKpEyp6AaXImJdA3flY41G5izPU1sBQI5Gw6fbXPHE4ckU0Jxk4fRGsx5mj6JH8C2PvKJ5WMIE/elNmqMbhA/WhhWj1VN3RtKVzS4SvyedN1a2udQoibNhx3HQLOcinfaZ3XxHStznJWBV2XPf08yrNM= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2036: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 20:rGA5VV39kQKMLc5pj6nDw2PDxuArRB07iN4uWJCqNpE4ErYSD/LTEcV4x6xeoAv1zzgHI7p1L2c8++/oQF31ke7aHq3Ck41FgxPJcn2IC0tZS7U9vQsg6ZON6qPsb4lpxoBDnlvX6/xuMSjMNwyI9ZfAkNgtQpd87Sdj+yLK2wPAOaa566rukkgHOrWEeuGbkggrxmzyWXq0d56u92KmpWEYJMtyuLnfjyhMYSMyOM6QxfK374TlPA9q1JU2ZcoYrhCmRoZmExDRxXb3tL4HDKZyOwvTJEotBolu7ZUeZxUt8ieK0zbYmACCwoh1/2WR+WKE+yqRIcvnBUTonQG+//unHgZUjY20gxLB2RpVC2JX/0W+858pOujZF1tOj9O4IMQK/4z2bvNGTf5dV61TYyMd0zQSAUMuW81aZKcxQK9GuAbjGpGnJFfpYcvNQUnn4a2RReyim1qB5zyaB+BXfiWYm6zZRO8YsPWVN6yT+jLUpVMuzIgw7OKqnBTQpAIg; 4:rQgC9v2yByuPd/k8e2gmMmQIO1yXaI2Sep72uNDEY+9fUSrJ04RR1+wQ20OQEp+VdibNP0vGtwlvbblFpCvzDVSSCNdl7dSWcWPwxizMxwP2Hvfm+URzwm6m7cYLHegI2Idv/LdbWVPBkUtvI9LrvMHHsvk7Yaql/vtwy+A1fWZw+XnZQXbSa0ZMKLKdtSgtT/eeh1IXX09mhCOpl2G1JNzxHi3RaoflWXrwdYcVeWOfsAY6Onrnd6od/ShS4QMS7AjVcX+5RZbqBZfyTdvs0g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2036; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2036; X-Forefront-PRVS: 0694C54398 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(396003)(39860400002)(346002)(376002)(189003)(199004)(478600001)(81156014)(76176011)(7696005)(956004)(2361001)(50226002)(305945005)(2616005)(50466002)(47776003)(486006)(97736004)(5660300001)(6666003)(2351001)(106356001)(8936002)(186003)(81166006)(52116002)(6116002)(476003)(6916009)(23676004)(386003)(446003)(11346002)(59450400001)(66066001)(26005)(3846002)(8676002)(16526019)(1076002)(25786009)(21086003)(86362001)(2870700001)(53936002)(4326008)(2906002)(316002)(55016002)(36756003)(105586002)(69596002)(68736007)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2036; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTVQUjA1MDFNQjIwMzY7MjM6c0RJdnVETDZoOGd6VFZZK0lKWlF2ek5N?= =?utf-8?B?eitrdkpnckcydFU1TmtyWWl2dTlpRThKQWp6YUlaT1lnUXkzeFFVb3RwWlQ1?= =?utf-8?B?Q3o0L3NMVWd0ZE4xWVZKano3ZVlLNHR0VS9MdlpQUVhWK2NtK05OQyt6LzN2?= =?utf-8?B?bDhJcTZkd3d4WXNhYXh6S0hzSm1FY0dHT05kNTM1WFFmUi9OSEZscmJwS1lR?= =?utf-8?B?eUYxall4OUtwc3NacU91UzMva3ljT0hOSGR5NnArK2xrdi9BNldUK21Fa2lY?= =?utf-8?B?LzVNOEF5S3N2WVFJejlDc0QrSlQyenZGbStwdFdySVRJb1hUMXYrUHZpWTNn?= =?utf-8?B?c2l0ckVjcHJHSnkwZmt1OTBrVWU1TTdEaUUvNHZ1NUp5MWVsMUJ0eDdRQ0g0?= =?utf-8?B?OU5pMzNKaEc3azg3bTBWY2F3ejIxYStKT1VKZUEzclFrMklSaFhJeFBUWEJk?= =?utf-8?B?aWtUeU1udGZZWDNKR01DNXZPZHpVb0UxWWQ3S1ozT2FUUzUvL2d0VTN6ZURM?= =?utf-8?B?OTZ2ckliMlczR2FFWE1tV3N0ckppcFpSVXVtazhHbWtYaFlvTlFNM0NjdGkr?= =?utf-8?B?cjY1aVhrVHpsNm5vNitaSnRvb294REFwWk4wV0x4WGRmdXRNVFRwOGtBU2Rt?= =?utf-8?B?a1dLYVdacnhXSnVQb1FSOEtLQ1laQnNORnFvc2hzOEFlMXN5L3M1U3YzZkZF?= =?utf-8?B?ODAzbjNJc3dhWklNNEhsNVdsYmpmK0ZMOFFxT0xMYU5ET2FaYVJwVkpoeHRJ?= =?utf-8?B?Rkt1RXJGK3QvTURYU0pLTzdLaXBGQ0tvZlQwSzRCRDNubFZBVU1UMFFOUGc4?= =?utf-8?B?VmNPWVJOQ3FOb1dCREdOMEhtTE9NN3pSWnhiOFBDNWVNeTNKeHp3Zjk4bzlj?= =?utf-8?B?dkdWY0llZU9XTEE0dTJuZ0xuT0hBMnZXd3JYcFdteHRYbWdQN1BuRFQvMTJR?= =?utf-8?B?SU4xVTBLYm54YXBvditrR01XZ0hLMWxWWitydmJCOVpaNnpqdXllRjRHdzBE?= =?utf-8?B?SjIwME5UZkloM0VoeTJKT3UyczRqU2ovTi9hTk5Da1RRNjEzcTFVVEI0QVpB?= =?utf-8?B?MXBDWlNKM0Y5dndUem5DRFRTcXZrR3dxNnhsam4vaGRIREJPcFE3UE9kRy9v?= =?utf-8?B?djIrOEoyK2h0Sk84ZU1FN0dmdDR6QVE0M0FOR3pNRkJUdFYvWDUvOWI0S0dt?= =?utf-8?B?ZGROR0FXRXJ5S0Eybml4TTZORWJ5TXg5L1NzK0x6L24wdnNKZVV1K2lSOGZn?= =?utf-8?B?KzY2NjFRaW9CeXF1M3pOL1hEcEt2SEZVZzVlV0tJdGxuSlBMeGsxWXpsa3Fv?= =?utf-8?B?d21hcDgxTzY0SGM3UTJJVlhGRFBVWjFpZnNXSVd0UEU1V3pERS9pMFBtWUJR?= =?utf-8?B?d3k4Q3p1Ni8zWlF0bUdwOFZpYy9aM2dJcWg4WDRRR3BLSGFaRXZKSzZSWWpM?= =?utf-8?B?V0dVUkRVRWNWUnpIUXZEYk9Xc0ZvelluS21KWVVPTTIwWk0yeTZLb2RkZ2Q4?= =?utf-8?B?UUMzRHkyajd1S3Z0NEsvaFJDclZNOWRIVDJ4T0tLajB5Q0h1Y0pJa0pkMWJ2?= =?utf-8?B?TUMzdUZyamNZanFBbkxteE1laGgwVTFFb3h4UXZmbzk0d1AzWitISWhwNGRw?= =?utf-8?B?eEt3bDVwUWxsUHJaSUlGckJWbnJlWndsOThvOXVMOEM3NjkxT1JOOGZjRExk?= =?utf-8?Q?qcbUv6BlLTc7RL4Ueeq9T+yirZ+0T4Gx3IOlT8yq9?= X-Microsoft-Antispam-Message-Info: 8T1uP3A6t6/d6KAkdBKxXVggJ4KLnNjiUWQMnmRK+lSYtPVWIBD/pbHqvnqsoULuBMPl2x2K9yzOB+WAPAwsrCniFpLJK/NfItGwfgERZmXeTT426EtbLZ75we86hWo2l9AKXoXsw3ovugzCqepyq7HwcayYD091zXQ5EZ87UwsfNiiK3wxaJMk8vFqwFxUD X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 6:R2uWAx5wjAfbvCw2iOVTmgeu1MZSsVtFLe75lAGjFOIretOwMJ0C0EqSguKrPUsprZpWQkYQ1HEWm0jr2PcCcWhsn9BOfmZvTZr96WGeM9OZZ2uSHhM3g2bTl+vI0dAgS/YmwS34Naf1gmhGKvjxed7q0VLiaxgvnHodMi8z6O99ZEHBA8kFOlk64T42X8hUlFEmJuBwy0Z6YjZy6VwLEEXqa95C6jbr0ggRQPwamQLvojgqEsy5WZpLc9XsJGtSf2CDkxh2SD6An3vBiC8Hjw95NQGem4LYzomkFT7pazehasBTKG1pMR85eLO2I0UxMuMdT7AEmK/dgo70KIHjiMCr7YRAP1y1pTjIhqD9RVNpjM5jU6bIYwtScUZTNt+kqibbMOL1W4ISC+ARhZy/t28yP99WLJmBPBOvlURvpDyK5vB4mBKe1occAuBUjUwxLR0MtpvM5zow3TP42qHfdQ==; 5:YHmwAkTnXfG42Ex3UcBsOkakS/J2yzc8cHzJKHsPQgynrqW8GcUC1bWCpkaRUrQAIaJLz6k3A28zyYD4Giyj5N4Go+AbTFhkAGUn9Bj22mbPLJxxIF0zpGx/DG1hCtnRatSs8OYhDDEoG2XR4EdXhEZdIre2EEtkBHymNfoWtBg=; 24:LbuorrQuXGbAaRj5a6CpL6SC3wAAxp4v9gh4VeMA4Wq2Z3AoxUDRMbs/LLUsQmK0I5c7pURyUGdebJJJdbV060ZYYCtf1LZBBFrOnGFpAJE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 7:sOqUv8L7DMRL2F489RW8/+Df9ezo2Mr9pgj0AmwdeMZ+p6bqR8yWnIULrHCQ4a8f8Y6vCRGUmD7ClKodjQPHQJUYA8SqWZFQleJxNe2OdVMkScVozxPfzJ0u73v65/aVDS8/l6ATZJcF0oKfljySzUz9J2IOQBMJuVFKccWflNaCpzujbXB4zq0S4jDLlm8XvUnQeDCmm2YPpgJeQbBiTom7FSz044qsoLCiWM714sUCuiFDDI/qV3AFuwhoKWvl X-MS-Office365-Filtering-Correlation-Id: 2dbd734e-3581-4b9b-3b1c-08d5ca78f702 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2018 00:12:01.7890 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2dbd734e-3581-4b9b-3b1c-08d5ca78f702 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2036 Subject: [dpdk-stable] [PATCH 06/67] net/mlx5: fix reception of multiple MAC addresses X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 00:12:04 -0000 From: Nélio Laranjeiro [ upstream commit 5a29b9a35a7214e2e36764ea67e13d7573eb925a ] When promiscuous is disabled, adding/removing a mac address is ignored causing the packet to not be received or still being received corresponding to the add or remove request. Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic") Cc: stable@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c index 9fb5ba5e7..3ad21c000 100644 --- a/drivers/net/mlx5/mlx5_mac.c +++ b/drivers/net/mlx5/mlx5_mac.c @@ -95,7 +95,7 @@ mlx5_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index) { assert(index < MLX5_MAX_MAC_ADDRESSES); memset(&dev->data->mac_addrs[index], 0, sizeof(struct ether_addr)); - if (!dev->data->promiscuous && !dev->data->all_multicast) + if (!dev->data->promiscuous) mlx5_traffic_restart(dev); } @@ -134,7 +134,7 @@ mlx5_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr *mac, return EADDRINUSE; } dev->data->mac_addrs[index] = *mac; - if (!dev->data->promiscuous && !dev->data->all_multicast) + if (!dev->data->promiscuous) mlx5_traffic_restart(dev); return ret; } -- 2.11.0