From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0049.outbound.protection.outlook.com [104.47.2.49]) by dpdk.org (Postfix) with ESMTP id 198A1AAA7 for ; Tue, 5 Jun 2018 02:12:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P0TOukX+vYhgoFfNJBDfQavr3V7MVLTFWwJLG3a8Rno=; b=YELjiXMdLJAqKSosWW61L+LxbO4aO4DQO0+mhyr25W1urtRZ1cZI6mn5u8lkdv5jBrEoCcoiKVKWuxE42U7xhz/Pmkk9mR3S9G+U0fBnkIVg67RMfaihYCnVZvj9Umi3R2YN4UIDcV6g4xmf7891NdJr9XfwaCCiltTBHMaaGEw= Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.820.11; Tue, 5 Jun 2018 00:12:03 +0000 From: Yongseok Koh To: yliu@fridaylinux.org Cc: stable@dpdk.org, shahafs@mellanox.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, Xueming Li Date: Mon, 4 Jun 2018 17:10:29 -0700 Message-Id: <20180605001129.13184-8-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180605001129.13184-1-yskoh@mellanox.com> References: <20180605001129.13184-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CO1PR15CA0060.namprd15.prod.outlook.com (2603:10b6:101:1f::28) To AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2036; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 3:sHfYjq+Ag7Aw4ry+LOuRl1wbUFP/1WCKdhZ0sMgtuGduZTN2Ma7GD/bzb7cgIsw9+sGtkTUzX3ctdtsdx9+P4p+ArPTJb4CuhDKNAQm7X5rnp4wExDxQUcc8umX3kbGY8Qezh36Wpgj5aA2z7fr+c8lRKqQ6JXEdsDiFSeucHpNIWskvw1GE3ABJbi4+s+zC2lqvYwYCkvNO5fDLM/zi5pXWPmYqZsm0qwHbGFE54neg9N7yRIPtZ2i7OfrHcOuS; 25:J30jCCT0CCIm1AXs8ngvLvoUjJysFGMFxuRG93fhand2qT/+detZSb/19BmygdjNqC9yiUMcu9mlcycvuz/MWO02GO8hGgBYfHIKuOvXcEAyviLSaN1rSsB6sr6+08JmfPDnAZRPlQjr6Gz8fz6gDVivefwuY8CMRmVxbfYOMkSmRqPj9IY5Lnm7mV5Oj+l3jUVqkpubK8GQMlHmcF8qFvNdCbv+RMd4gmGsI3HfUGvhH+/nQlTpuA78PNV4vj4KE14CkfKjop6xmCr1HYhmerT8p5ahqXm91JL8AV5DOv3rZQXDpYAeBG956j9JIrMNG8Ri2QPv5lLLuzjrxuOUYQ==; 31:bhAO9xQBaW75Nn9OlSEu7TCy3aok5v2N9dEuymCtrvIn9LI477/ORNSUaGa+V3wCGi2ORZ4CwVNJxxG4DFHzgqxujiyo6TVlXNtEN/wRWJrhlbU6tswbH5Gpk9/D5T7wYi8lNsdymdLELD7Rm88GiM6vfOe6O123itZXfjf0BGKhOXuWubi4BPsdZ/7zT7M0kozgJ19c8XJQ0YFkr1YUyPxWWD0mTFzs2xaPihnFQRc= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2036: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 20:gvOjWQHMOk9nn7qqy+ZQfukAn7whmfZDrDJhzx2RjANw4sVhbPU2WoJdc6LSwEBlhd3H1LsarlgVkt6wdQIURY+FeJEBX7hM1Cx9Z9KW81Q9dkVfxVuycc5CQfOZhJMJyxEmpu0LgE4t4gbbyQ9nsHYdoFFpYFgfAEBqFUjN9WgLrX+MuvV5i/wAEJMCysQUF/wMFwsrkTCa3EKCc7AfNP55C+/ZhA+Cyt1DRwP3lKuhaFATqXIi8Yr2HFva7dyjrtCG58CTAOxAdxV2qiSLOyA7e/GQE+r/6Z2mpU5B6NAtnIa/0Gn9iZHOXg67qWfe1rhoAJp7ly+4j5TfKfzUeshN1l8M6vMdNvqT4BHVdcR5GwxxKx3LWtJLqWUEkTtnZVwWdYRwcWIHVuhLX3z06XHijTxQYOPC/xQY8w3jcjv7vJRhN3dw9C75hdskg2sf+7OjWI3C7tpsQWj1p4i3ARoP/9T0gA6TinyeCjeApcoND0EXLWai1VXn5pbsq6n0; 4:eKkkqxVF6w0s8u/qAEKFxW8ATiI6k5aIBHBKjE84C3iaqNqgBlYOmTDcLyDYwgM2OYqwJlVw1ryoE/b8jTRoVAd7M14sBAQOoVRg9VjddDjOZ+TXlOnVJvX71TU8Vg/nZc/qjD9iTiMyQdbO3e2JvTHWeYwaf07Z3i2MrkilmnhiL//IRY7EdivUm7kVgmRfXNOqKtgAjxclWfQsXz562EcefYDT1YRd5YNP/8uwqtdPFdqsb5SJ5v+u/XDfeyF9TsvXCTVYaGMd3wE6qXD3Bg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2036; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2036; X-Forefront-PRVS: 0694C54398 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(396003)(39860400002)(346002)(376002)(189003)(199004)(478600001)(81156014)(76176011)(51416003)(7696005)(956004)(2361001)(50226002)(305945005)(2616005)(50466002)(47776003)(486006)(97736004)(5660300001)(6666003)(2351001)(106356001)(8936002)(186003)(81166006)(52116002)(6116002)(476003)(6916009)(386003)(446003)(11346002)(66066001)(26005)(3846002)(8676002)(16526019)(1076002)(25786009)(21086003)(86362001)(53936002)(107886003)(4326008)(2906002)(316002)(55016002)(36756003)(48376002)(105586002)(69596002)(68736007)(7736002)(16586007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2036; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0501MB2036; 23:iEfBk5LZdwq9JyM/aUqNS1aYEId5BYZVetPpUvb?= =?us-ascii?Q?WrXIQwYq34Kyn8Z3/zhdRIg+O1Hgc60sCUHbe8GHrF3nNvhx3ptoQefV0Pgq?= =?us-ascii?Q?rBIGf4bxQeBcTDoLjsVKawxC1XH5C/o8mxE1O5oht0qN6sm5QOtxbPdfYj5m?= =?us-ascii?Q?4pSfRbWhQV6SMHV2VRjfqOkVrqh2/4/gU41FENQFb62MAz9ViwyaV/OHw40v?= =?us-ascii?Q?vTFUvFK6/r9owz6zk2/g7/75ts4LUpFJOzteUDI6l26Tb7bWYVkvH4n9pCKd?= =?us-ascii?Q?8aJatGO2OW5pS9QoajANqRENdLkQx/ZrzjFSyMMYo6NHhOmHHpVeUZauROWo?= =?us-ascii?Q?lB7z9m34FhRmO8pxx+wUyT1+27PkKM0cUJIQ4Eg73IR8oRWJB5Uucp9l3IUL?= =?us-ascii?Q?sr3Gf4i0cjw4Dd8xhmDh57SWJ/WzFCZZFb2T0Izs4UQe2l3M4zeCRcDd1MKg?= =?us-ascii?Q?j7tJUH820VcccW4TjevTSbgANNNyY1MJjk3kKbR1EACgYFNlGxrNGDYGAtmA?= =?us-ascii?Q?u2pS0BduyVDTETPnMAdNK+D/RfCAtykslY/aDFgZ31x7FdJlLNQKTn7lAFEw?= =?us-ascii?Q?K25PXUDhK1+YsWLPqjem4gUPtoRViEi1FEAmAbZZmrXs5rQvk/tXK+hHCZe4?= =?us-ascii?Q?YtNSCRYRjY3HqvuhlhktDOy8Ap75rI1vUIn5uZPeEAI0PkTUJEeQRsJasPcW?= =?us-ascii?Q?GLKtPBkCbA8ju1WTTuFVrptqNxmwLFj3GpEOrzTmp544ahIk1PVhsf8oKmiD?= =?us-ascii?Q?v6PJ5UqoJ5JsuQ+uAybOQVKOzSRIlTefRyMRR4rFCaqtBoPGXhOOVJEJE3Sd?= =?us-ascii?Q?KcMLxEJI3V3xs23lME2GHB634UDiKYzN9nKhqjh1dmvoSJPjjxB4CDlZODEX?= =?us-ascii?Q?12WTITEZqd3YPkdhEwT/HHDvHh/fxTofJtO4S0HpFIVpEYFfpRMX3rMEJ+sk?= =?us-ascii?Q?KRwZ8br2JSd+6hkSngNtuixMoN162ibyHY2BA4Icxg4E5N0YKbNA+xHQnPyO?= =?us-ascii?Q?EY17kmjIQ5OoGCR3aUNhHokdXqYaobRpSMutGGKa+2ax/c/Th4qzvAGJ6eKn?= =?us-ascii?Q?5ix7+nLoaaiO3W6zbLavSjh6zVVgHhK5Cou4IO3xbBYrom7iRsNxUyBlZ9fy?= =?us-ascii?Q?i0jSeLkkyAJNmQM91/fXSXgrXw74b1b0n+TGyNXGNlENKTnKV7SNhpyrtdQL?= =?us-ascii?Q?QuoQN/s4WHEhv+x3zfYOChwgsAezRWOcF9jQ5wYUSPUXC2DqvCq3bDnwOE4e?= =?us-ascii?Q?QZl/uZVk7ZIir+Kpt2BMsUWzFLRaLBGrTN/XTxU/8kT0f/BLLg2TAxn+NAHK?= =?us-ascii?Q?5zA=3D=3D?= X-Microsoft-Antispam-Message-Info: F0lwdVYpeEhDVvtiVlHtBNDG1Z4h2acvKMByjnma6fGeVkZ4tAkuu5HK6UO0cvyXwIyP/Y81ltYiWcpAmdzEuMMwflSHq7OGZ+FCzYxypjbbp+lO7Z1kxVzcrWcjSunKEk6pm8sUhKd3HZPiZYB3eEMoeRLrS8uVkGMwCzwETsTYvymURulNSS8JWoxwrK6o X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 6:wHZJdjTnz2APreCfG+IydaKF29PF7RbI1S49epSGkk7xpGBufflW6v8IgvSv/X77U92EsRGOG0KCfuKxHA3bZno52nSVFuMtX7+DEj4ZHG+yw1p7nnsu8BCRgp+7Dqvf120J3FzCtbnJJqFnX9dQ4vTLmiw6RM14BWRlF92ty3wxq0gTUWQBgUMMiudgEskZwYjArrivnnCGeh0431F8/Z5bl0N9bULpRytzn5qemdtCFXSANQPZXAdu7YgcH0C//u7Ywu/Ubp6WEl8X05BwdvDvCM6W5pfvZlAPHrrgWztgWmhLjXBiLPxqtVf7fia+rHMeuBPnQ+/nsCksm0iP7z5p7hWtYELqvkjd3ME5y+tS3XwSrdU/SWdF2iuU5erQ8FySibPJvq7GGm96SgY7QHJKvS0je9AQQgjJ7z/9W2Xj32cGw4w8Ib8+jomltSTtbMbuiXfTKVQwyWY+2BxaXA==; 5:BnEkf1HbUeQFlB+0m8kBXE4Ews0mYyj+BCYUYx7rjZcnUyApMY0ENNLFEAlHS4UW+Po2+FlAuVOYzwAh/ZxMwGQUDSOiwctDORwspMIKWjtYKYwzDwPVSqkRLYaChU+aONzdXkV0yWNPi5YfUl2lVEKmCvDEzCA/fz4uJu4z4Qs=; 24:mRjnXu9Hpd/h5eDlm7B1mAL/K8xp5bpQXX52FpjRRbBfZkCoaE8/dGXU1n4+s4CRDiF7Qt/X9T5jVzZ4wBCJKOIR/eGwCyGxNn7cXLAtayU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 7:CvHJAqlRTkkMjeW6sXoZkAMDA+4M6YsAVUFeIURS0zUyiep9FgvTJQareJSssxe6qE0rV+W9FdPlNWCO5YtMF9uQDd1835ZhWjUlsWUoQr9Oz8h30y7ly3MexG9ksUO6SZ7SEmMAS5eEvkR85PwM0jrjZOSOWGwceEaa7Rr4Rl0KzFLW+2waOgFGHXMQoMJrUEUlso59y/2xAK35g+5R+EUNCXcRBY8rg0Zkek2GA9E1fmRPyceTXCy0epHDRQwB X-MS-Office365-Filtering-Correlation-Id: 207a3967-048f-44b6-8189-08d5ca78f827 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2018 00:12:03.5548 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 207a3967-048f-44b6-8189-08d5ca78f827 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2036 Subject: [dpdk-stable] [PATCH 07/67] net/mlx5: fix secondary process mempool registration X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 00:12:06 -0000 From: Shahaf Shuler [ upstream commit a482a41a638749b2a5b9a1f37c8774453274a8f8 ] Secondary process is not allowed to register mempools on the flight. The code will return invalid memory key for such case. Fixes: 87ec44ce1651 ("net/mlx5: add operations for secondary process") Cc: stable@dpdk.org Signed-off-by: Shahaf Shuler Signed-off-by: Xueming Li Acked-by: Nelio Laranjeiro --- doc/guides/nics/mlx5.rst | 6 +++++- drivers/net/mlx5/mlx5_mr.c | 9 ++++++++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index f9558da89..50fced3f4 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -108,7 +108,11 @@ Limitations - Port statistics through software counters only. Flow statistics are supported by hardware counters. - Hardware checksum RX offloads for VXLAN inner header are not supported yet. -- Forked secondary process not supported. +- For secondary process: + + - Forked secondary process not supported. + - All mempools must be initialized before rte_eth_dev_start(). + - Flow pattern without any specific vlan will match for vlan packets as well: When VLAN spec is not specified in the pattern, the matching rule will be created with VLAN as a wild card. diff --git a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c index 2776dc700..33d037d28 100644 --- a/drivers/net/mlx5/mlx5_mr.c +++ b/drivers/net/mlx5/mlx5_mr.c @@ -141,8 +141,15 @@ priv_txq_mp2mr_reg(struct priv *priv, struct mlx5_txq_data *txq, DEBUG("%p: discovered new memory pool \"%s\" (%p)", (void *)txq_ctrl, mp->name, (void *)mp); mr = priv_mr_get(priv, mp); - if (mr == NULL) + if (mr == NULL) { + if (rte_eal_process_type() != RTE_PROC_PRIMARY) { + DEBUG("Using unregistered mempool 0x%p(%s) in secondary process," + " please create mempool before rte_eth_dev_start()", + (void *)mp, mp->name); + return NULL; + } mr = priv_mr_new(priv, mp); + } if (unlikely(mr == NULL)) { DEBUG("%p: unable to configure MR, ibv_reg_mr() failed.", (void *)txq_ctrl); -- 2.11.0