From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0076.outbound.protection.outlook.com [104.47.2.76]) by dpdk.org (Postfix) with ESMTP id DEA3EA48C for ; Tue, 5 Jun 2018 02:28:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tgIx2ymg50fhgg/VXBMsWu93nACP90YEswl6VkaiKuw=; b=yKGllHIZIgaZs1tjYOZihcWJLu7vxCSKOTl9zIMeyd/okOmk/EaHfhu79j8inWF9FMxIn1Ne480XJKsGiWhMqOCaD1sSUY1Nt0vyILv/1vge5g+2dtPTLydpVUOUTAJf2u4UlJOChQ+DVY7Mw9zmgieC8hWhEcjYijjZzpNaqXE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by VI1PR0501MB2045.eurprd05.prod.outlook.com (2603:10a6:800:36::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.820.11; Tue, 5 Jun 2018 00:28:01 +0000 From: Yongseok Koh To: yliu@fridaylinux.org Cc: stable@dpdk.org, shahafs@mellanox.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Date: Mon, 4 Jun 2018 17:27:29 -0700 Message-Id: <20180605002732.13866-7-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180605002732.13866-1-yskoh@mellanox.com> References: <20180605002732.13866-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CO1PR15CA0050.namprd15.prod.outlook.com (2603:10b6:101:1f::18) To VI1PR0501MB2045.eurprd05.prod.outlook.com (2603:10a6:800:36::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2045; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 3:nzQjVFC65B83QNCmyD/12FiYNCKqZqPMFLWKkUrLpERv6u1GPJJAo7lkRSXxCPtgQntRqetppvcukCUNyOAh/3e4MHcSrVSVVtfz9wE7lv/sHEZC09sd21TbP2lrVZx9yXy/k38EE1jQJDXES1dh3vduFvje5plmWWmVIDbgoP7by9ALW9oLtUS+cFOTcedyzY/U6UNMEuovyDhuMX1QPzXBlpKvVrovL+CyJWJ5R3kJ/Fi0Q37CfiDTU+uZ2KfI; 25:X7d1vkEKXxPsviMJ5/EVHM91wtDZVqOpsdywD02NnYPkmLtIm+ISRPHcTAeuiPMdpbB9xG+ThoMz5TFAIuPVRfZd9iqpDq6wzNz6w4jTlPFMk8rG6RNyszyui2F9cbv2dTFN/AjXjKDrBws7S+kmcX2ZkjqRvwUctUv3z/COShRTGeVyev0Dv3mk9Nrah9NAr4kj14VrIbIH2HfQUOJbAJVdpK4U4xdhX/T1PutM7aknIMmVbjg4FbuOX8mqC2lX6uLbEkskVUvXDh9dc6hJ1wPG1Q+rOCSCHf0qQFueuqMu1Ilq0o6aP7sQVg1dgVU1QuxB86pS2BDVzlRnLIT/mQ==; 31:zAEyq2F1cksiCj63vcfO/94kX3tjuu7Cf3mCAXxJ2IsT5AcmibjdOFXpJSdFN9dMfo02hu3OEi9msjUYeNf/EEeAroPUW3fSmTDxqAeR1yhljlf56hqBSVcvX3B+1Wrhmf0UvA5Y0La6Juf7bpOjmx+iHjSgCJcQ1Q+AKQZRAST9CLWl2Vo+YpVFEEycEFxfsH/3DOD+06LxyJEsSXH9rDje2fRIxh7Et8v14V9/bs0= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2045: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 20:I9KZh29mIJlvbkQRorZS/CTJ919J1nL7PThqLpfMFSdS/XjWPPCp3SM0DWKqeuC6KOZ8bKqCYUyaDKZcZeJQrIv6S8a5lQE0IV6X++jJesdZ43JYW9Z8+bw8nlw0MR4GFHDwuSglHDMhRII5tCkn6JLx1ISinsGUfgjN0IAYMThyiLGjIbTQi7LBUunwMzT0Kk5M7Lgh3lez+MIMR+iOT3p1N8d0V7PUDEsrImQd6R3mk5QapwiQ922wgBbiH5b8YaU+/bsbRHLeA4d72lllxE3CfgCWaCbyx0s5QpGDG3F1a6irP9Gpj7FxZIRvNLz3quq24zCmqTYYLKsRhgX+zIytjrs7i8A3CnW9YL/m8IELRkmz+zikFruKPRqy18hAvea8iS4pyzcsR+HEX4Ksa4p+6A/UlLHDJRIZHfg55CmbIuU2d4gEU6IXp4sp56kAlWPCiIsr1XI8V6jVvhYMJ9l3nAjKmxa9dPWMLaA3+QomysmSDMWwvqvz/ee71ykg; 4:NHGbgX3KcGCjYNq/ZmWyoMwXs+fyqqvmGhzWOo/BJf2XRzavs8g62q3vwqfL7q3N3bP+4mXofyvz4h3EfSYPQsPWNEiEnJGHxq0nhmFWlnjDu2OhFVw0gajDo/3AqWD+gw3xDT0q3F3fZg1PUXkp2HhM7+OWoaShE1zPxvScrqKUj1OAOGNgGTzSQnNMU9Xd4BtflcBYImxd29saYUNnm8fmQQRn8K/Ua65fK5cPYfDOcVCUMDxB8W1lOdr7a/52fJr9bfs3mKsoJ3PgUzAYkg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:VI1PR0501MB2045; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2045; X-Forefront-PRVS: 0694C54398 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(396003)(39380400002)(366004)(346002)(39860400002)(189003)(199004)(316002)(956004)(2616005)(486006)(7696005)(476003)(386003)(11346002)(23676004)(69596002)(52116002)(36756003)(105586002)(25786009)(4326008)(186003)(21086003)(76176011)(16526019)(26005)(106356001)(50226002)(59450400001)(478600001)(66066001)(2351001)(2870700001)(55016002)(7736002)(305945005)(8676002)(97736004)(8936002)(5660300001)(3846002)(6116002)(6666003)(47776003)(446003)(1076002)(53936002)(50466002)(68736007)(81156014)(81166006)(86362001)(2361001)(2906002)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2045; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA1MDFNQjIwNDU7MjM6RGhGVitEWnBVZTRxLzNxNkZidzNQeW5I?= =?utf-8?B?WTlaMzVMejAyakZCQlFFVGp0bitONjZIbjJXUy9ZTXY5czJqbG95N2tVQnQy?= =?utf-8?B?UzNOSXpCdzF0WDg0aUFHTWtDanFNVndFVndEYnA3KzhBdE5xd3JnbXdKSTE3?= =?utf-8?B?YzJxbXJJNGZMbVBldGllUXE2MVZ2MmVlY0F3RHVFOWh1MFFQMTN3TmhMdk5J?= =?utf-8?B?Nnd3RnFKNjBySzRZN0hTTDFuK0VaTXdPakRrUUlkekgrNGxEQjgxS2ZvL2RQ?= =?utf-8?B?dFVlZndQZSt3T24vNk5lMmY2VlUwaGw4aTFpOWh2ZzdUQlNjYzJFVkNTVzlE?= =?utf-8?B?aklqaFZVd1BHMEtTamZYam1RWTZFRFp0WG9NVElTOHhIR0R2TnJ5VmYwRUFD?= =?utf-8?B?cUt5QVYxbWF3anQ5SnJMdXN6aVNNYTVFeDYrbFRaREhJQ1diaGcrWUZUYllV?= =?utf-8?B?cmRLUktFUXlvTmtCak5XblJ5MVFUSFgvUU45TG5VNHBWTXkrNlloUVliVVgz?= =?utf-8?B?TWUzb0xmdUpZY0t5MmNseDZBdjJ2L1ozT2QyR2hwU3FaUGRzVEovaWtOMzlY?= =?utf-8?B?ZVdieDhpU0d5c29pU1VpS1ZFZS9RbWhyWkxSaW1YTm1ydjVVRy9QcE5EK1Ry?= =?utf-8?B?Umd6UXFaYzJlRFNYdE1WMWw1bHZuTEZCTnNKUDhXUm9vdVNHOCtyV21TLytm?= =?utf-8?B?WVlWNkVOUXpYNGo4cWRrd2hOZVQxd1R6N0hiemhodXUzbnRJMlhPK25kcXJF?= =?utf-8?B?eHo1RXd2ZkYrekk5WUZ3TWM2N1JUeFRyU216eWNNbWlHamxzMzNIaDZucnZ6?= =?utf-8?B?WHhZWlVuZ2h4VWRFWFZXbTcxd0RmTndacDJvYW45ZXByUmhkNU9vcGVFeDl3?= =?utf-8?B?dmNzYkVYZEpaR2Z2ZW5UNU81bHBnK012K3NxREN2R3NFL2VxQ0FQMk5mTlRa?= =?utf-8?B?Qy9YaEdIOURqRko3S010V09iWmNSR0trRzYyRXJSSjJSTElLWFJPQTR1dVRL?= =?utf-8?B?eTB2ZlNYMFFXbjd2NEtHMjZWNGpOc091dWxacUJKT2FwK1JlY1pLTmVkQTJw?= =?utf-8?B?allnTEY5ZSsrN1ZFNkNvYjV1VmFqZ1lPKy9FNHFPOHpQSEZDVjJMTnNIMFZF?= =?utf-8?B?d202eUlJb3hUVFZKU3ZpVnZaWlB5amNROS9nM2ZuMUk0cmVKTUNUUlRjOVdM?= =?utf-8?B?STF0dlBOejlkdm5KVlR4OWczYnhnZitQYnBqNWtmK05Sa01lT25FR0xhcHRx?= =?utf-8?B?ejhwS0ZLK3Fvb2ltc08wNDU2U1lnRFNmc0drWUs0N0FkZVVSc1RqTG5yZEQ5?= =?utf-8?B?OS95Y1R1ZHVSLzdkL3lvSVdYcFdZSWRYR1JBMmdpditoMGlUZ3lHT0VZVHUw?= =?utf-8?B?YkhiMTRiYTZuYWQwNGJHVG1sbjlEL1FYd0wyMDRYNStKRUlhdWpwU01YQkRs?= =?utf-8?B?MmFmaUtTWHRBbmJJeXVvZnFKdXQ5UFZxZDF6c1RhMGs3bWhYSmIzZWJBaEJy?= =?utf-8?B?MkVrZ1d1cTBnTDNyTlJFOEEyc0VMQnAwVHUzejRBZ0RNb2dKOG5uVGZhbzlJ?= =?utf-8?B?VDNQcjc3b3ZNWHpjZDdoMnZZbTNlc2ZtdGxJS3Nlem9aRWZQWmZOVDVIMTVZ?= =?utf-8?B?THBSc2hMYi9iL0tOS0RUQU1DNjZ2eUlwNHUwZ3hHd2JtVnl6VER5YzVjc1hn?= =?utf-8?Q?3tZcCfxQMgz7H1rfwCNGEWGj5HAVFpYYnpSuOAuzt?= X-Microsoft-Antispam-Message-Info: Pf8gKdRXSMNWWX+ZB6eP9KEACMfLDWs6NPIv559O58Dzp+bL4XQkjOSdAgCttxWUOttzroaysOfFnIFISJo+COH4lZHx74WLuZbly2+RfL/f35ufp3voPY9RBC7II57pgGgsGK9z5KPGhAQsR5YZ9TJlCPHrpL7vRZ8DtbTxNrd+KP2JfbyBxQLrYrlD26Mr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 6:57Yr1nSzeOVHnecCf63CDf8Ts1lQh1MRAYhXVqE2C2vB79plIv0ovAFNHTW5oxVhm8hTCzvyKXILaf08jmu1DwTPsRQCyIjGdISOk0cf0wHET9kXogA24PlaSGnaG5BtVeDXcwfCn9InuoFk+ary7a2o+Nf/fyAtD7zxCMW+gsglSzbmVPtcuf7KMcDoALOpp+k9+3mP38UrDwpXmhkUyb3ID/hoZIsPZhCWBki475HYbEUHYiiX41037gPVFJa+F/ZYLupw6UdE/UWq3lV/1/C4o+dm/VmsRDzKZRIxMUiE+SRtMJFAS9Llg3vosrzURRni4N3tzj5DYYHFzwGh5AGAWzLv8bIrI88unCLZCxAIWnbTRJjc2ZLk7wLVTXB7BGelBOudNTF5D0TKsl2PmdXZQrhH+cckEU9nmJebhf5q+xVcI2IA+4ZcaqWzWYccC6dEblwHkXmI8H4daY96Cg==; 5:PO7cm8ka9+a9p84cF8lF3CXCE/+Lsi36ch7B8/lqsttwk9M99Oj2q82g38VHyRVvhJJ8wukSwK5Yq26f66MudKtGYHPTHnCH4nm9KhjPmcc39kc8kFPpZqJiX3fhmw0tzCxubSFhJS+DSVI3JvpHj2R7sM47ihE3PZpg2ZdAzz4=; 24:iV/+kTbHJ2Yk/uNMz7M+5shAh+LOWzH6DMfflhndBA73pAJBf3yuoPI+s6OLKFStXrBpchKp4jbkKWeT7fQa6fgvtQlBZKC3vH2r2b2nPzc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 7:haotKyjZpdVxMbPbG85lMNca+cJkmoKunYYfYHM/R64MJn7dm6jKKIivGhUEq9BApKyYYe8q2MxrZjDQTYPYEeU0c6fx90Qn/9JCQ5CuoIbWU/M0tNeQFpOyhHlNKSmPpO5uANWyhVzEFVQkbtjGtlw49ZqzCMzRuf26AMYFjmut7FMkWJKmuMu8QB/Z0VeYAIHiS4TnV764fjgzRldNhiQBWi6KmH0FJQ0yPzL1EDIwxVHRRnhGYoUgy1b52nk8 X-MS-Office365-Filtering-Correlation-Id: 486756ad-a7b2-4d5b-b634-08d5ca7b3333 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2018 00:28:01.4889 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 486756ad-a7b2-4d5b-b634-08d5ca7b3333 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2045 Subject: [dpdk-stable] [PATCH v2 06/67] net/mlx5: fix reception of multiple MAC addresses X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 00:28:04 -0000 From: Nélio Laranjeiro [ upstream commit 5a29b9a35a7214e2e36764ea67e13d7573eb925a ] When promiscuous is disabled, adding/removing a mac address is ignored causing the packet to not be received or still being received corresponding to the add or remove request. Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic") Cc: stable@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c index 9fb5ba5e7..3ad21c000 100644 --- a/drivers/net/mlx5/mlx5_mac.c +++ b/drivers/net/mlx5/mlx5_mac.c @@ -95,7 +95,7 @@ mlx5_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index) { assert(index < MLX5_MAX_MAC_ADDRESSES); memset(&dev->data->mac_addrs[index], 0, sizeof(struct ether_addr)); - if (!dev->data->promiscuous && !dev->data->all_multicast) + if (!dev->data->promiscuous) mlx5_traffic_restart(dev); } @@ -134,7 +134,7 @@ mlx5_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr *mac, return EADDRINUSE; } dev->data->mac_addrs[index] = *mac; - if (!dev->data->promiscuous && !dev->data->all_multicast) + if (!dev->data->promiscuous) mlx5_traffic_restart(dev); return ret; } -- 2.11.0