From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0049.outbound.protection.outlook.com [104.47.2.49]) by dpdk.org (Postfix) with ESMTP id B2E46AAD6 for ; Tue, 5 Jun 2018 02:39:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cHw2JXWVavh0AX4lfPrkVUOdsjydVNcjjWZdz6zLSb0=; b=R2w8pmmlNQn1B/ZfFslhBURwJ+ObyDtQK3X5LLjubiwIPEO53ep6TI0MHdiA+NiKNulJeTyTx3XVYQlPbczxp4L1r/Prq4lRgUOaR+MDiYp+SrhHsiDLn9ki5mrXLAGna+kyogNPSV/ksdfsSxNJyegR8+aj8oLq50uxsrZZOP0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by DB6PR0501MB2037.eurprd05.prod.outlook.com (2603:10a6:4:6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.820.11; Tue, 5 Jun 2018 00:38:54 +0000 From: Yongseok Koh To: yliu@fridaylinux.org Cc: stable@dpdk.org, shahafs@mellanox.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Date: Mon, 4 Jun 2018 17:38:11 -0700 Message-Id: <20180605003811.14448-10-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180605003811.14448-1-yskoh@mellanox.com> References: <20180605002732.13866-1-yskoh@mellanox.com> <20180605003811.14448-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: BYAPR02CA0008.namprd02.prod.outlook.com (2603:10b6:a02:ee::21) To DB6PR0501MB2037.eurprd05.prod.outlook.com (2603:10a6:4:6::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB6PR0501MB2037; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2037; 3:i63WVNzSLnUXZbZQ0hYKOM+w8+SLPJUvrIIVIa4u+/QNBbpGc1Aa7/QxTdPStcqM1PXwkMn9Q5GNuN5Ic8F3KZkReu5XifFnSUKvqq1Wo5VFeXSn3AVX2Q4CFVKaQLn0FdXPRHcUwaw8t7TXPhRkN4wewsc4+ok4xohsK2CFXmR6kCtvLgTUFgZEkuNQ8WvNwGFrFz+RgF/4pwkA4Gep4V5rw13CJ4FKdwRqGlunuPqAfd1LMxAx9WVKrn4ijdqL; 25:CFIF6KpXsun97yLiWUI5GBpUw7vMErz/TsocdWaAMRGDh/8qHrt3E2c+hXpWYhxiRwjZQBfxcp2GOs4OpsJfbbNXOU5W4oEXWEfeUcmxI2ehKKl4nVvjipzyeygq2x3C8PHbbMcNrZNaa9HM33Z+FhI4fG118/FFB0QaKtW/3sk12Rl7z9Fp/t4FRVB64igBp2L1BwpAulw0cqAHbGjjf1aeInIbCglgbk1qn310ToZzKslX++XaWvOq+lN+vjSgiXauusVBD+Tw/uSR1KEiTXa+LvKVFcws63wYqodgtjpmg7OFf42tqaHpxVoNs71eXpVQnXXdh0bh7cWKD0ycHQ==; 31:qd/78Bn+JPU/9hpYBdnSCkN02bQbfYnPmUZjCjT5DgtAinz+tzX4dFTFWb7B+YL4wWMms/tse+V9kp4i3gH/SgNDXGeGfAM9/1MVFeG7E9kGZ2VRriXffIHlZP+Gp1h9MjNrF3pN4VxX6AY6WUx1Nk11mXUs3U5JdNryNAZKvmi5D9Lh7aSxwTKM6qA9sUSOiCrXhJJZxQ6P0PoMmzyF3nOEYxnpcunZVZabuQ/TwXk= X-MS-TrafficTypeDiagnostic: DB6PR0501MB2037: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2037; 20:t9BPSUX83aIw6jLpRXAdC9aLu4yvxMl06sVGXlNH56KhxBBhefHRuwupsl3dpGOnZsCV9MVaau3lFaPDuV1a6o6WShgmuJD3LyZcWTA2l4jkjna02loFlMlOaEhW8A95iQ6tyhweZJDoRbDl3neZ/ej6m92ceC3aMRFfamgA3M9IAizmlBz2EdfxTxfxgjwpWe43ACI/7kLh5TeH9KZ3lKJLKQ41DiIAmdwpEEMkM4ygSUZk9OCpEyPYvIxuSvLWqPNLJc3arJG/Fij4w+avA5p1ONqnfdd047jEHmTPyVr1BEnMTp0Tj0EbZzxNy0/9Zn8/u+FbbIJjytsZCphkeOb+6D75eL1EfO0rMfWSQc1iVog/zDbRI2T6jBJ0C7Lzre7E3C0LS73FWlTYYyt94T2cyOvDmeCb4Mx3fj9GKg0tWHdSY8D3RWOh49xmmWeuP3xPMa90o/lX+l8W9NEr0wfq0bZ5mESoasIGJo7rvFq23NQAfsz1iRDXcxoLN6y9; 4:1wm9Sa/fB0UrjH/LNHxmeEOsosvQA9V9ZOeftp3MohF3xeQmnK1nEmlwmGa44OLLQobNR8itbG6LDI9RCTXMqpRG1Aj3vGsVZFkR8p2mQYWWnxR2ebP9lAJg7CvL6h91//n8W/ujTh7wPTnCGh+KJ/dDW1WNeq7jhV/fDyZrKRwmM2j41q6639QGk46UyooEcEA5mRF2fDQZgdqpWxfYhJtsbWgC532uiAKA3E//cnus9QWwnE6t3/dg1xC1CCPV47gOMuiKCowgHzGGgRcw3A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:DB6PR0501MB2037; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0501MB2037; X-Forefront-PRVS: 0694C54398 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(366004)(346002)(39380400002)(376002)(189003)(199004)(186003)(68736007)(26005)(69596002)(21086003)(2616005)(476003)(4326008)(486006)(81166006)(81156014)(16586007)(1076002)(50226002)(386003)(316002)(53936002)(2906002)(956004)(106356001)(105586002)(11346002)(446003)(86362001)(478600001)(575784001)(6666003)(36756003)(7736002)(52116002)(51416003)(7696005)(305945005)(6916009)(76176011)(66066001)(25786009)(55016002)(8936002)(16526019)(8676002)(2361001)(6116002)(47776003)(3846002)(59450400001)(97736004)(48376002)(2351001)(5660300001)(50466002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2037; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0501MB2037; 23:7u4+YrdEKEa0Woi3M38X4fVKPicSl9dhVreW77F?= =?us-ascii?Q?0CvueG6MZZxTE72IEM8/Dyx4RlgOMrTOAga6OUNQR+gS6KbgvSvR7VdoAB0V?= =?us-ascii?Q?FvzVPQ8tflwzc+FqG0RfX1ZIvkAIbwkvqkqnsxgWjq20x6zORpyqHEOb5/5+?= =?us-ascii?Q?Z1UrndO14XtcJS1uRA0x1K/xxwN4mOF0Y1sha0wTAiOYyt35jVfPTF0lVLA9?= =?us-ascii?Q?2U1tqDkWLGbNkWhuh0VmTIb3jB/0WncrP7KexejlFC6YPFByyleMYfM68OzA?= =?us-ascii?Q?pJYzoaHCgxTtgtu3tr1GKdIiUKoRSay645So/Pnfs8LlKupDBKT1GtAgFPWX?= =?us-ascii?Q?JQVsryHoUno2j2dMu+zwSYwCe99vl8NeaxEv8PYMvrzKLWUO6nAWOk6SAISj?= =?us-ascii?Q?hfi7tdXmCNKOYjx4vc4dZyYvLdQdq5HtjIaeWBSe61rTkUDcyGQxpnDSy1b4?= =?us-ascii?Q?vEpT351e9nJjj5Uc5O9pWXyF2j+8CWcp3L6/6KTY1HmN759S/qvOUUmewA3o?= =?us-ascii?Q?kpKQYso6zDxTC4Fz38PU/cOXQLeiyWUHBArPX6reuwnpWKUpzG1VmoVpicO/?= =?us-ascii?Q?nu+H4jgJF8ioqPI/4Ki2PZuG/ly/E7j2R0hL3Eh6TIDJXdR1vO4D6q8CPHDY?= =?us-ascii?Q?sJKl/9PRtQaXKniM/0PAbKC4LrPsj0+RXspnvriiEh6Qm6S0Ii5D+T9iQcNL?= =?us-ascii?Q?GTs6X9PagMIzRANXXiCWMWvyoz4+4P9Vm1sFPyS9PbjnjDGTqw3UOWi+IenE?= =?us-ascii?Q?uUQH/ttzqQL2XiFLJ6kefMLLp7h7P416oC2BncciuWjzNgiJvLqzChGr5olS?= =?us-ascii?Q?LzZGGA774DhNqhxZubuVbUlxhnljBp6n7T8YWr81CS7RYJnhzOcrUT9HGO9D?= =?us-ascii?Q?cv7di55uUeHYSFNDwQhMQmtqc5G6caB3NASM9vcnZVaYGZM05sOQeYGJP5bq?= =?us-ascii?Q?weBpZn9wB+xkRSUYfN/oYgjdeJyMZJbTbjHPGRvxmeceMFi8CB19a1R32mrR?= =?us-ascii?Q?rlUAXLzF46QD2aaJ4/zgsDL+DtgXaDHEGLekQC0EKLa3piNGutFYk5lXoKaG?= =?us-ascii?Q?rfVBaaz5YBXMTupCvUS1Y1yuj0Cj7s/fgb5VjoT0vPTDqLOwIf4QHLUAEyW2?= =?us-ascii?Q?2ij3SrLTwwFmg9qbrfKIREOnf/AVV3DrQvmylVr0PQfftz/Ma8QVR4CkueJw?= =?us-ascii?Q?P7vOyOklr24W+N/babO5bw1/BrPe51/ooagtqFCJDxwkCsagkskpAdQkehKX?= =?us-ascii?Q?DcH7AEPKUF/Y9vGQ1CUtvo9orBml0v4CMPWp4wDyeToaNn3sX+E3gUnsM+rs?= =?us-ascii?Q?x4gGD6bpNTrLq+uce+Cvaa0k=3D?= X-Microsoft-Antispam-Message-Info: /UNKhgPFPyvjnccaI65mQH43JkuhxbqntMk0lv9TBVZZu9fW6TSRKcAf7RzFbTaWOqbKtqKseCn93mu/kh1a0H7V1HxmNcwTzHJ2OsJ614LL76sIXt7cbiuM5FyohRxn1NaiIO/3PDPdK05Wny9owcisSUa26cnT/46x6AWrQI++Sab4j4slN0oEi7gEH5us X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2037; 6:Tb+FBkTsCn8bvc6poDMjjZt6qPay8SSmhfQs4o4LD3+51wTigYITi5qwZMZvHZbUXHcxXTXkdeNhk9uuXcQC13UVtZFM6zHeOoFVU0YCO+OoBnwS9P0evDz2QKNCW/jwIl8h6T9cCRSLjYJPFankQ7+UEtAFnM8Lg3eFVSRYjxFwX7wbxr0cSR8BYsKHPwiTVLGyEdlCBV6/kquaX+5hjQO+OKsi9AgB3gFSQIDvnC3EXp9/cK2cyLQ54JIlcAHWndZ5+eTKiXbXxo//X7AjD4wLDYqOOf7B9z1kT0GV7p6Vs44XL/EMTG4VVmZNL3T6W2zKTFE8mnCDj8yWkR80ELDSrzvNscNjmNQnim2HM9ZEucY9cMBUfC1OgrzTyDP2YVlI3EsrWgfKdStSGn4mCgh9BelOmsRVaX/21y2yLWeWLTG4QeEirZgfNR9ZBjDNd7lfQmyrfT78kIxjNtF0Ww==; 5:w6luRpDmkyThaFsaM+i1W+9TiEfLIVEKxiJHlTT+bwLnkb3oQ8Gz6DwIFiM3F0qWhnqXEY1N4APWa+5nZqwGehI1uym4jwYq0XCUn4GKba7bYfFStpnON3zc8RPeag3VTQhkai6DoC4YEPscYFWPWWZBhgzNDM3JY9Ey0vpKAgE=; 24:UD2yrzUYVdkqzA0hgFyrtclx1dNgLbe2C3hx23dr3jl3S8MhMIYUAUYwnNlwnAXWfAWPiCTc8aU3ntEAANLNM1yqVBHrsdPPmNOgcs1T1Q0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2037; 7:ou4oI6JmC7sBiJBU5Yttw5nlmniB8aGR9rWcoVEplKouFLSIjPBfWmpLaavHvf9hqWV467NEoJwJZ8HPFQnjYsUAveJn5w9PIO1EQ9jI8H2rEJ/23oytIwjKvekzknjadWvgmenBKOruGhSpUKLvL6QFyZyNdXQ/y+WsWO4coLFKeuvohgNJLt12FQu+Jqvwy2B7kuPHdwK0C4hsieIjuIXu0NSpnK49990rhDvtpp2QEbRlzxlyc1Gd9lrcqkGv X-MS-Office365-Filtering-Correlation-Id: fa66062e-89b9-4f57-a389-08d5ca7cbc81 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2018 00:38:54.3289 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fa66062e-89b9-4f57-a389-08d5ca7cbc81 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2037 Subject: [dpdk-stable] [PATCH v2 39/67] net/mlx5: enforce RSS key length limitation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 00:39:15 -0000 From: Shahaf Shuler [ upstream commit a1572312f713f0b218063c6213499e36a8b47c86 ] RSS hash key must be 40 Bytes long. Cc: stable@dpdk.org Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_ethdev.c | 3 ++- drivers/net/mlx5/mlx5_rss.c | 7 +++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 18e1e534c..1e869db52 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -334,7 +334,8 @@ mlx5_dev_configure(struct rte_eth_dev *dev) if (use_app_rss_key && (dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len != rss_hash_default_key_len)) { - /* MLX5 RSS only support 40bytes key. */ + DRV_LOG(ERR, "port %u RSS key len must be %zu Bytes long", + dev->data->port_id, rss_hash_default_key_len); rte_errno = EINVAL; return -rte_errno; } diff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c index daadfbe5d..029e0ec49 100644 --- a/drivers/net/mlx5/mlx5_rss.c +++ b/drivers/net/mlx5/mlx5_rss.c @@ -78,6 +78,13 @@ mlx5_rss_hash_update(struct rte_eth_dev *dev, return -rte_errno; } if (rss_conf->rss_key && rss_conf->rss_key_len) { + if (rss_conf->rss_key_len != rss_hash_default_key_len) { + DRV_LOG(ERR, + "port %u RSS key len must be %zu Bytes long", + dev->data->port_id, rss_hash_default_key_len); + rte_errno = EINVAL; + return -rte_errno; + } priv->rss_conf.rss_key = rte_realloc(priv->rss_conf.rss_key, rss_conf->rss_key_len, 0); if (!priv->rss_conf.rss_key) { -- 2.11.0