From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0076.outbound.protection.outlook.com [104.47.2.76]) by dpdk.org (Postfix) with ESMTP id 1E590D075 for ; Tue, 5 Jun 2018 02:42:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q/RepweilfrBKkuXkpIS7z2OUXmzCf6g4WDrH8TP0Q8=; b=dLhcGX7jM8CEZU+hHjhOKwPYBMiyx5SLMUBuyh2nyoZwo5c/mwRSxsc/0CrLtxHaf8O8YYDYXrYCeaKmdKKT+4muTu5HSEdW28APxIRUTJ6AlD2VPGGqBtdAjJ+Pi6DEuCXbKz3c9fkiaeaofRuMGKFARx1yVr4M0LsjOhUwroE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by VI1PR0501MB2045.eurprd05.prod.outlook.com (2603:10a6:800:36::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.820.11; Tue, 5 Jun 2018 00:42:06 +0000 From: Yongseok Koh To: yliu@fridaylinux.org Cc: stable@dpdk.org, shahafs@mellanox.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, Ophir Munk Date: Mon, 4 Jun 2018 17:41:34 -0700 Message-Id: <20180605004139.14660-3-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180605004139.14660-1-yskoh@mellanox.com> References: <20180605002732.13866-1-yskoh@mellanox.com> <20180605004139.14660-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CO2PR04CA0088.namprd04.prod.outlook.com (2603:10b6:104:6::14) To VI1PR0501MB2045.eurprd05.prod.outlook.com (2603:10a6:800:36::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2045; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 3:aP3R4/uVNJq1oMTcZKX92YH7u637UZrIOmwv/SoL3qg0l3a6HqUH1Am6F//PbWQGvm8psYRgEiUIRtVhRdvyrE1Z3m0YdqPMleVa4oOiBe/aJqNKzpD8uGwkHvq6EK1Oea79rulAZ4/W2z2syVEKa0oj0k6gBWmAkgXGf33eef5SFjr0YZqEEgy7GqFVKtqUh/zCkgunIx9eP1K2y8EgSvhJ1IBBrbubRZEWnrN4KfnLNXG91kt92WO3E28+TYtI; 25:YY2sCJvFQnKkcKHEBae4+DLITgxwrThX1gIsdx2gS00ss+oJscEiIu4nmmqWioGALZqZTjGIsB/7aNbDZUBYXHCiH0eH2Njx50bLovhDVGSPl6FhHfW8dTnbKlq1onIIufalYLauJO9qdXdxkLk2zDXaqhYgBgq1Qlobj527GAnCQgQYHgJwII6nlbNLFLZsCXgEHICiU1BeUzrGDMz0Ynjiqzqd7RWdnF2jEnbXkiMmpaQvore4vEVgf0Wesm03DEq+yG3K1jZ3B0DJYf2fKVW/Yw0dqjPJhL9trLO7qpz/G3UH1+4pDtTC9wrtofhKz5esMDlm5kuTItw/QVOLUQ==; 31:ZsnJulkg2PM//dC4vr+REyq7w1vcUq0gDP7g3V/XNVRyzw7RuaF9beT78nMiiN0btGAsu25Llv3fdAkiQahem8EIZxdM76V6/MDo6qlW0mhbCQkWdh540arepOkQD0AQ6f8S8AR6V47V2Er43hi6uiWjoSB1eHdOCbDWENQvdYN0NDigA1Rdq23oWuw2MhnGMmml01x4hvUNdDxDvxQRN58J2NV8qaVdi0jvgnXRbn8= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2045: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 20:BWALxHrMyMBCCiL7JmU1krbw5YmRByFMWtHgxl4VBssMTsUkMYUPSJrg1Un/rl7shJkPQSkTbkB1yWembxKmpt7AyWMwQNJ5cdeo3c6D5Slbt/1vc4ICVP2SxkZUY8avQoHdtvJUkOyA89oT9J0q2T8rvSrVQC40zz0Da2g90gWh/qHn/coXsFHnvKu+emKoZ5hi6FjKZSGFRUkOMoj/SIEeeFFL+Llan6IxJJT+VZc7yIlByHhPvFi4EKPLS1S22RUGYLt7r/y6v7np6UKlRN8Tr2RMUk11RpyZZ2L/MDkBIhyZ+4EnrBEez7bBfijzSeiWY+K1y1JIKKx7Di9CRd5bUVUbrssLpBLBQZlMlt1Ec9NVKvy9fM6fSe4DJzkcIcGbB/VYhktqmnVU0EZnZM+dTzyb7gSmrAKEqPCHBu0himvBiyKtTeX8kcejOurPqtDEk7U0A78SEl3ReKVMw7Cjxg+SddCBdHSH3/Nk34I0bBeklcMxr9iRbcvBmS9P; 4:bwlzOeTYE0f0hYvykmVLLyfp3oIQhPKQoljNwjxXMEYZmX9KA+IoKHVsLBE0GkATNn3JIK93aUmVMaFKm2wEFdj1FGb8Xis5mIOhImdA8i26Nea/WXhqOkdGvVwd+qag7M+Gdraeg3c1k7wJY0SgKcrPmlJ52+6PQska0/AvW/byZWWdlM1K0KwVZJq/7CPnXfCXzr0RsEMD2tsSg5MFDV798rLQURI66o1JFxw8IoBoEvwSMAfJecvM42Hufmss5W0LeHfEBDo9jnsfX0nhLQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:VI1PR0501MB2045; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2045; X-Forefront-PRVS: 0694C54398 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(366004)(39380400002)(376002)(396003)(189003)(199004)(5660300001)(8936002)(3846002)(6116002)(6666003)(2351001)(55016002)(97736004)(7736002)(305945005)(8676002)(48376002)(68736007)(2361001)(6916009)(2906002)(575784001)(86362001)(81166006)(81156014)(1076002)(50466002)(53936002)(47776003)(446003)(16586007)(36756003)(105586002)(2616005)(486006)(316002)(956004)(51416003)(69596002)(52116002)(7696005)(11346002)(386003)(476003)(50226002)(478600001)(66066001)(4326008)(107886003)(186003)(21086003)(25786009)(106356001)(76176011)(16526019)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2045; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2045; 23:4ZrgLhj8SDxGw3z8vxZhO2DOgU1MmfSCw5/Ftn+?= =?us-ascii?Q?6iH/ZjdP6t2Dkg5dLHRoh+RHJYMMf+5K/eNw+rMnGnDgHJYKSyd/1S10qV63?= =?us-ascii?Q?P903DGpvEjoPZBypyYNXgGmp3KoRGAVnvaGJ1jmf7HYUGTL0TarKuGGv+2u8?= =?us-ascii?Q?ivGTv4vLTglLE3FQB+f/Ieh/3fFI4Tp7fZMGeejMnML7FUChReAI2ZFC4d/b?= =?us-ascii?Q?F+JaDdE8nUwyYgRtDDJ6mW3X4+mshHKFhQOCtJmp7gS4/iVu6GQW9zaMrU6n?= =?us-ascii?Q?+YI69u79auQFL5eyAqjg5rGV/mEkNX518SBwh85CGh72gixiBcClbjc23Zh0?= =?us-ascii?Q?6HTvxbqdbI2lpfjjHUfsaG7k7ZAxMApZrHdiD0XZVJG39XpTfNPLSlZQLkU+?= =?us-ascii?Q?DVITLyF2lG2s1bwmeEGfkiw9oOTfxtF9ARnEz4lH5Dt5MDHKLmTPGnX5DIuK?= =?us-ascii?Q?mPvM1Ys+zMPHIA00GSAbub69BmwtmJAAquFWXoVXqA7wKxAQ7QDMXxbmGeo7?= =?us-ascii?Q?bZhBKKNlKaT+HgyGD7C5SFcESW6bpCXJmq/g96oN0YKzmtXBF9FN1RV478l4?= =?us-ascii?Q?0ebi6p/lAYFm/pBOMtKtR6+jew9Q4f8uXz/hxTC9wwDOiEMMmKUa+J6frcrT?= =?us-ascii?Q?UgkXRz4vLzNTk7MG4b/j6p9li14/6PpeKfZQC5w5rdCzRO/h+QyJOba8cI2B?= =?us-ascii?Q?ytgndD+q2iT91xzPwp8ftXY3iNaSPdpZ8GIbUp6Ei4tqyysI16no+MgB1+1c?= =?us-ascii?Q?TH8uaOqXkJ+AR/w43qp5UPQxEcodp8SkxnQbV4jxYQg4d7G8WdqoePgy8nfB?= =?us-ascii?Q?geZUOYAmuD0Di7m8dvhRCLMTsnVG70KARebaWW+s53P0qptGDDUl5lIcnWcf?= =?us-ascii?Q?fq8Y5S8qdDCIB7RLbzw2cumK7iCkr37Nme625W+nw817fbog6OuiZ3UOP1d4?= =?us-ascii?Q?sU2m58ULhGQ/5WGC8WQEp9O89X9+rivrxPsIC4jOYChGKS8PuUz31z2zzpMe?= =?us-ascii?Q?Wj8rvtGUe0dDIfYj8n8HcnQjcgP0IPVqoHYI65mFGP4vju/QMH0jebuCXz85?= =?us-ascii?Q?bNTTPIbewlsfHHYGsiv21f+jkUi38X84r8EsfqbCW+v52hZEpqTPURzi0X15?= =?us-ascii?Q?VuIPw1OW8uon8f1JmFPVr9dTAKFxOLcdOeo3XMxfVS9rav2SjQOKdh0ejnzE?= =?us-ascii?Q?6BvpxA0hxWdBqSO0ZNJsJO03HmFqbPqFMnCP72NlKCw2aqPvOKyhQ3xlTGjA?= =?us-ascii?Q?1fXPx2PJhORM9DKmLMtGxyqhCTZcwSRFX7/rpJdhVHjZ21up4Ve39ETMEzO7?= =?us-ascii?Q?Vs93sg/yGS32R6vUzHhWwet4=3D?= X-Microsoft-Antispam-Message-Info: VqRI0qPnql5iHkMPdTrKEkw67KK4FQih4DCZDWSUq0XdMP0lNPdUjBPH6/OT4Hv87SvK41z3gTzoFLt/sv/DeJOSusUH4FgomCFNrWKJ7SPgknTJECjHqinI52bm27t3Gj2aK5Z7v1fjztgah7z+xthVk975biNnWMjx0IBSjKqe399bybMxszt4nj1bqX0g X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 6:tV3vEohhXNX9RT+yMo2dNz6KO9G2x9DhBx4eSzaDmW7/Sxyb82pGPst2Pyioa+sAi7d/e1KquLhOOjOJdNlPGC7WYrIKhzR0acs9dp3B9R0roOejnWTvA+Ff89ui0Lfp+B+CO8jJ1y69B3KLZYes00v2spZUUTUMqMc2qHm8M67fO63wSJkrf705LfOhp2BJJDcpsnoqIOh5Bm0wFwvflEXFJWrcIOE6j2aZzci8utn6T1FbLJgY09SuLL4g4jc/9P1mfpvEJY9bvV3BjA3QFH0y3KOW/V/JxvH4UsRiNeWsNOVBceLuKtj5fcLfNNbS+NvlM/7yfxIQ5TZ+wkkX2y877jRaEwFD573y/O2dZnL47COgRd51b5OqWWqH0jBkWKLLm0FrTnZE45kAbHT4lXYClzH+XxBgRXSPWQ0kos2qrDo+Q8QFbS9QxZY0MBLH75xNNS5pVSlo35+uz6yF2Q==; 5:+e/asOPD8BYhhYUTvqZhevs/nJ0fzIutgx8/3rB1H8f55GS8a3Fe4WCGy3TvGtkXWT4Q9BpVYTo4L3ylZuoSFAGbtPOcMqTSEvCAZSam2WgXS/l0cU/Bv4mUvTtQo5oK+CTBRNBriQvvDYG1WyNCo6vE+V+jVs1yNwT2T8+FB8I=; 24:mzJon3QoNOm0iJjgMAxptp/DtiuYbnLNx0LlX0MHZL9bSweIIom6M/HIvozOqg4/G+p0joBOUTmwXgEbLR+IFifACxQw6pdT/wEl08Dt3TY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 7:zY8ua0aPGBC3pS1V1IHPD6p+6prrV+ZP+1qSMVqKSatNQdJmkLoKjIegiVu1kcUM1OY8fUbnASs2eonedE87aCucbG1bYM+G+aeLxEI46zSKjCGiNl/eX6sFTeYPC6TVnpRbkzqqZbznV0oDIf/s796wWnl/qZUUJIqwvXMIQszELKOmwkrReKqTAq9vnYW0NT0wrsAN9LwVO0xvXnxp9kJSAUiv3DahzCAf32u3GUPyTxalA644l68Pj9Vnfmxd X-MS-Office365-Filtering-Correlation-Id: 798b7f32-46be-48b1-15e6-08d5ca7d2ae2 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2018 00:42:06.5256 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 798b7f32-46be-48b1-15e6-08d5ca7d2ae2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2045 Subject: [dpdk-stable] [PATCH v2 62/67] net/mlx4: avoid constant recreations in function X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 00:42:09 -0000 From: Ophir Munk [ upstream commit cbd737416c34c2f71227ac450db2c85a789dac30 ] Function mlx4_conv_rss_types() contains constant arrays variables which are recreated with every call to the function. By changing the arrays definitions from "const" to "static const" these recreations can be saved. Signed-off-by: Ophir Munk --- drivers/net/mlx4/mlx4_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index 472cadc92..fc0f06147 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -116,7 +116,7 @@ static uint64_t mlx4_conv_rss_hf(uint64_t rss_hf) { enum { IPV4, IPV6, TCP, UDP, }; - const uint64_t in[] = { + static const uint64_t in[] = { [IPV4] = (ETH_RSS_IPV4 | ETH_RSS_FRAG_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP | @@ -139,7 +139,7 @@ mlx4_conv_rss_hf(uint64_t rss_hf) */ [UDP] = 0, }; - const uint64_t out[RTE_DIM(in)] = { + static const uint64_t out[RTE_DIM(in)] = { [IPV4] = IBV_RX_HASH_SRC_IPV4 | IBV_RX_HASH_DST_IPV4, [IPV6] = IBV_RX_HASH_SRC_IPV6 | IBV_RX_HASH_DST_IPV6, [TCP] = IBV_RX_HASH_SRC_PORT_TCP | IBV_RX_HASH_DST_PORT_TCP, -- 2.11.0