From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0BDA737B4 for ; Fri, 8 Jun 2018 16:45:16 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3F25620B94; Fri, 8 Jun 2018 10:45:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 08 Jun 2018 10:45:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=e3P4H9LmtUpGpSGfC2Py16wkT4MVwOlpq+qks576o7w=; b=u4ShOlYq NfquY1qMThaNRjSMWQm8pt7vhSFe/UZac+1oIU5LfG20jF5S1dm7b92G6PqlOrTi +ZiRtz4by6G7hEpEApYQgel+qSNjyRRjeK6SR2xIOv5hvqVrvxXsHeznrdDQ2S+9 eZXgytwjtWkm+nhnNbkJoeGBHpDEYoUKa7lf5TVZZX7MmdMWznZilj2C25s4X5y9 eh4Lr6q+dLPCP0Ddofvao7VUZuuBTDjBf+zvA0bi7iv8uvh05Itkr1cgNSaXZUyl smSq2M+tuj2G126jD/1V4BcLx98qW+lD/HOoiOMhM/duT8eUtxeYaDnChh+ACyGv RxknpaNkKzNBPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=e3P4H9LmtUpGpSGfC2Py16wkT4MVw Olpq+qks576o7w=; b=VN/CBcl6YPdRF7eDAqtdEGNog4ySkpV5xDtfGH6lvvAzd PMTpLgrqUG1H74kkELYAoGxMistIncrjdNjMoyhNJQUqLfIlX/mZ3cghBFK6CLo5 RBLo1JsDPbUqa8pFR4Kkwh5RlxBmt01WxICDGlH1oA5oVw14TmjPTGOLr26eg+NS X1nYXH0iCQTOuRvQNFPQFrjDmpsQV/u/We0ouqHTA91I/LaomYYkTsLDK9srP6TD cQ2b0ICLT/r/uuCzm7n6PO3JXk42MzEOLOvgdXF1PtayVR+V+VUKPbF8ZL4S9vL2 mHj0PDNZMsmsRx/tJBt+1oNMWqkgrkejJKuUOAWTg== X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from yuanhanliu-NB0 (unknown [223.74.148.13]) by mail.messagingengine.com (Postfix) with ESMTPA id ECEFD10266; Fri, 8 Jun 2018 10:45:13 -0400 (EDT) Date: Fri, 8 Jun 2018 22:45:03 +0800 From: Yuanhan Liu To: Rasesh Mody Cc: stable@dpdk.org, Dept-EngDPDKDev@cavium.com Message-ID: <20180608144503.l7cwuoqsxzd7ulwg@yuanhanliu-NB0.tencent.com> References: <1528419074-18954-1-git-send-email-rasesh.mody@cavium.com> <1528419074-18954-5-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1528419074-18954-5-git-send-email-rasesh.mody@cavium.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-stable] [PATCH 17.11 5/5] net/qede: fix L2-handles used for RSS hash update X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jun 2018 14:45:17 -0000 On Thu, Jun 07, 2018 at 05:51:14PM -0700, Rasesh Mody wrote: > [ upstream commit 3a1a1f3f1344c8a3bc0b06cd23e97b3922a91a61 ] Note that this commit is not from upstream, instead, it's from dpdk-next-net. Another thing worth noting is the commit hash will likely change after it get applied to upstream, for, AFIAK, they do rebase for merging dpdk-next tress. That's the reason we don't directly pick commits from dpdk-next trees. For this one, I will apply it without above commit info. I have also applied the others. Thanks. --yliu > > Fix fast path array index which is used for passing L2 handles to RSS > indirection table, properly distribute rxq handles for indirection table. > Currently, it is using the local copy of indirection table. When the RX > queue configuration changes the local copy becomes invalid. > > Fixes: 69d7ba88f1a1 ("net/qede/base: use L2-handles for RSS configuration") > > Signed-off-by: Rasesh Mody > Reviewed-by: Kevin Traynor > --- > drivers/net/qede/qede_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c > index d266fff..7462f1a 100644 > --- a/drivers/net/qede/qede_ethdev.c > +++ b/drivers/net/qede/qede_ethdev.c > @@ -2084,7 +2084,7 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev, > vport_update_params.vport_id = 0; > /* pass the L2 handles instead of qids */ > for (i = 0 ; i < ECORE_RSS_IND_TABLE_SIZE ; i++) { > - idx = qdev->rss_ind_table[i]; > + idx = i % QEDE_RSS_COUNT(qdev); > rss_params.rss_ind_table[i] = qdev->fp_array[idx].rxq->handle; > } > vport_update_params.rss_params = &rss_params; > -- > 1.7.10.3