From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 489D81D8CF; Fri, 15 Jun 2018 10:28:11 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jun 2018 01:28:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,226,1526367600"; d="scan'208";a="208313345" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga004.jf.intel.com with SMTP; 15 Jun 2018 01:28:09 -0700 Received: by (sSMTP sendmail emulation); Fri, 15 Jun 2018 09:28:08 +0100 Date: Fri, 15 Jun 2018 09:28:07 +0100 From: Bruce Richardson To: Gavin Hu Cc: dev@dpdk.org, nd@arm.com, stable@dpdk.org Message-ID: <20180615082807.GB23520@bricha3-MOBL.ger.corp.intel.com> References: <20180615070811.18686-1-gavin.hu@arm.com> <20180615080120.29253-1-gavin.hu@arm.com> <20180615080120.29253-7-gavin.hu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180615080120.29253-7-gavin.hu@arm.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.0 (2018-05-17) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v8 6/6] devtools: expand meson cross compiling coverage X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 08:28:12 -0000 On Fri, Jun 15, 2018 at 04:01:20PM +0800, Gavin Hu wrote: > The default test script covers only default host cc compiler, either gcc or > clang, the fix is to cover both, gcc and clang. And also the build dirs are > changed to *-host-$c, indicating the difference of cc used. > > Fixes: a55277a788 ("devtools: add test script for meson builds") > Cc: stable@dpdk.org > > Signed-off-by: Gavin Hu > Reviewed-by: Phil Yang > Reviewed-by: Song Zhu > --- > devtools/test-meson-builds.sh | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index 8447c704b..f75ebbdb1 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -50,5 +50,15 @@ for f in config/arm/arm*gcc ; do > if ! command -v $c >/dev/null 2>&1 ; then > continue > fi > - build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2) --cross-file $f > + export CC="ccache gcc" > + build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2)-host-gcc \ > + --cross-file $f > + unset CC > + # compile the general v8a also for clang to increase coverage > + if [ $f = config/arm/arm64_armv8_linuxapp_gcc ] ; then > + export CC="ccache clang" > + build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2)-host-clang \ > + --cross-file $f > + unset CC > + fi Indentation is different in the new code, spaces vs tabs, perhaps. I'm also not sure the "unset CC" is needed, because I think the build function automatically unsets it when done. One other style comment: rather than having an if condition in the loop and putting the extra build there, it might be easier just to put the extra call to build outside the main loop, since all values are essentially hardcoded in that call anyway.