From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 4A7E21D661 for ; Fri, 15 Jun 2018 16:33:57 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CC73221D7E; Fri, 15 Jun 2018 10:33:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 15 Jun 2018 10:33:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=A9eXlhlV+usTZwT6IiF8YcadEaFlSdG0IbV/ybsj0P8=; b=sUOld2N6 0u5mAihNYLipoQu4aHuxbrxFwcYynglMJNQ+nGLXIdUjNve9aeM4e4e10jE5A7eh qxiHCIEsPQHWLhA1mVCNwQzSGg/9QRCoH74g6nPlQCOL5Lc50xNA1wGRRK+vBPL4 Eh592IEwPUyNBfCASIijhL5QbunWvoEvp2szOjCBL+sb5SnIC3CdUo6HAUYEbuAi kSV/Mx8lBfGIcMPeWOsy/KhWxgF8gRBbG/FDx+EV398c8kILC0o65hCJsdaNKSA3 xCdN9YTiuLAWHOp0OJfUngZQr1xcWrm2iYB8yCxHoK/rJeLjP5R56fFj6rlTYXrn oCJwG2/IqHk9pQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=A9eXlhlV+usTZwT6IiF8YcadEaFlS dG0IbV/ybsj0P8=; b=U4FJKGhBsP1eBFb9yx2PtayMW1F7gFum3KpFz+kJK/pr9 8hOjoRVQd7dBFJk8frGgfZa5MEMCL8n4QL7LTQyesdAGqQJ2Dd6neUM0nQ86Wzh4 45F7PsZm61M+jHuEjTjmZBwFSvppyn83oicNBA2vbswy2FYvU6M2cSpj6TyLEo+d ghvWIiH4olKwpOosTiFmc9m9419l2ixH6Nx+pf1eqd2AT4GC7JhfSdl2Db1EHvT+ 0MWcDJsagXj/zt78kCstogyvbdDfX5sGDKxKUvaQROlakY407Xtp4fmlv/MuVCS4 JFCqty25rzI8wrtC3089IiJVvEdBzNTIsyqOeGrgQ== X-ME-Proxy: X-ME-Sender: Received: from yuanhanliu-NB0 (unknown [223.74.148.109]) by mail.messagingengine.com (Postfix) with ESMTPA id ED3DF10392; Fri, 15 Jun 2018 10:33:55 -0400 (EDT) Date: Fri, 15 Jun 2018 22:33:49 +0800 From: Yuanhan Liu To: "Mody, Rasesh" Cc: "stable@dpdk.org" , Dept-Eng DPDK Dev Message-ID: <20180615143349.hkv2puirrumi3edx@yuanhanliu-NB0.tencent.com> References: <1528419074-18954-1-git-send-email-rasesh.mody@cavium.com> <1528419074-18954-5-git-send-email-rasesh.mody@cavium.com> <20180608144503.l7cwuoqsxzd7ulwg@yuanhanliu-NB0.tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-stable] [PATCH 17.11 5/5] net/qede: fix L2-handles used for RSS hash update X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 14:33:57 -0000 On Fri, Jun 08, 2018 at 11:10:04PM +0000, Mody, Rasesh wrote: > > From: Yuanhan Liu [mailto:yliu@fridaylinux.org] > > Sent: Friday, June 08, 2018 7:45 AM > > > > On Thu, Jun 07, 2018 at 05:51:14PM -0700, Rasesh Mody wrote: > > > [ upstream commit 3a1a1f3f1344c8a3bc0b06cd23e97b3922a91a61 ] > > > > Note that this commit is not from upstream, instead, it's from dpdk-next-net. > > > > Another thing worth noting is the commit hash will likely change after it get > > applied to upstream, for, AFIAK, they do rebase for merging dpdk-next tress. > > That's the reason we don't directly pick commits from dpdk-next trees. > > > > For this one, I will apply it without above commit info. I have also applied the > > others. > > Thanks, we have additional fixes that are part of dpdk-next-net, but they are not part of upstream yet. > Can you pull in these to dpdk-17.11 stable? I suggest to not cross the line. We normally don't do that. > https://dpdk.org/dev/patchwork/patch/40779/ > https://dpdk.org/dev/patchwork/patch/40778/ Thus, above 2 will not be applied. > https://dpdk.org/dev/patchwork/patch/40777/ And since you have mentioned (privately to me), that this one is critical, I have applied it to dpdk-stable/17.11. --yliu > > > Fix fast path array index which is used for passing L2 handles to RSS > > > indirection table, properly distribute rxq handles for indirection table. > > > Currently, it is using the local copy of indirection table. When the > > > RX queue configuration changes the local copy becomes invalid. > > > > > > Fixes: 69d7ba88f1a1 ("net/qede/base: use L2-handles for RSS > > > configuration") > > > > > > Signed-off-by: Rasesh Mody > > > Reviewed-by: Kevin Traynor > > > --- > > > drivers/net/qede/qede_ethdev.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/qede/qede_ethdev.c > > > b/drivers/net/qede/qede_ethdev.c index d266fff..7462f1a 100644 > > > --- a/drivers/net/qede/qede_ethdev.c > > > +++ b/drivers/net/qede/qede_ethdev.c > > > @@ -2084,7 +2084,7 @@ int qede_rss_hash_update(struct rte_eth_dev > > *eth_dev, > > > vport_update_params.vport_id = 0; > > > /* pass the L2 handles instead of qids */ > > > for (i = 0 ; i < ECORE_RSS_IND_TABLE_SIZE ; i++) { > > > - idx = qdev->rss_ind_table[i]; > > > + idx = i % QEDE_RSS_COUNT(qdev); > > > rss_params.rss_ind_table[i] = qdev->fp_array[idx].rxq- > > >handle; > > > } > > > vport_update_params.rss_params = &rss_params; > > > -- > > > 1.7.10.3