From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10072.outbound.protection.outlook.com [40.107.1.72]) by dpdk.org (Postfix) with ESMTP id C37571B44F for ; Wed, 20 Jun 2018 01:30:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b4LqjTenjlVMfhRctXLqHaJarOvbsMHYn6qXtrpMOjQ=; b=j8FqCqQZA9n9jUmhKQVQLMo7Lhu4kYbO6+lCsiPI93Mh62NiV2HPa9ClR2n+HxOTYGAZ8KLAvbCD+glqxXBZ8EsZmatOnqjJ9H5YLNH2L3HKJiUIdgK9CUDJ+3kh28QnbmL0D/ow1wRuGocOMbW35fRUQg3hSTBR5xtGWbS03YY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by DB6PR0501MB2037.eurprd05.prod.outlook.com (2603:10a6:4:6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.14; Tue, 19 Jun 2018 23:30:55 +0000 From: Yongseok Koh To: stable@dpdk.org Cc: Yongseok Koh Date: Tue, 19 Jun 2018 16:30:24 -0700 Message-Id: <20180619233024.13553-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CO1PR15CA0056.namprd15.prod.outlook.com (2603:10b6:101:1f::24) To DB6PR0501MB2037.eurprd05.prod.outlook.com (2603:10a6:4:6::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: de483286-0bf2-452f-5b63-08d5d63cb48c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:DB6PR0501MB2037; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2037; 3:xLpqTz4RawE1EyIHghTfw8y8/w/dAAqSZ/CYK9NsH18m/DRhX/KqUABkHNk/d1FD12CpesqnVUD3EdflgHIGJ1KVhY/csnzyOzFz4tVJynfQw9ftawQz8u22ae5X/+D+za/MEqh219v7sgpxiy5S6GgUvP77kQk6hulI7FSPf8S28F0EQ/mvmRL3bJ8iVYe4IIxHAMTP3LeN1l6Q1WMt0c7j0b7PgHbIg5fUAImLrc5f8NmFc8FZYhJ4kOaXD0QQ; 25:rD+8KZaJHWCRqoYvSX4Zt8WM2f0zpZp9VG+lFznnc+TPZi4Z8fNm5IL0Mzy+Q4dQD5xXuinG7SC2YuoeNzRbLQJGFkdVIO8gw3Z5PaAdUC3ckNKW9r6vbNNaaC7PFnP9dfd0NvF7Z0P2biurdtGHlI1pXAvLmGhtul3w3fnc4SncGEYW3EsPi88+Hnn285C7gQ2/tEDf8xBLYUgshpJbqL+dPbNue9AA3PRt7Rk6rdEOAN0xZNpihWJiqPXqTFhW9BoV9BAJNPz+/ydWip7X3y2DlgrNP+pMKilqq7T0qb4VaqGB5NQR4KasTnfHurGWP1SmmBZGhyIsROFRYcKVmQ==; 31:Gw0fQXmF4y8Tga5DPlm1YRCUgZXNGFZK3P/THUxk5ML4DPZ/7TJJt5QXWwBW6ecLONV5xdiGyzn5roSiibaq0bgZB/8FDDc+LfS0cGYSjiRPcEEC5YI1zuN5+b7YHEXhYuIh2SgfBzMVsl1/Q5KWdpzxXEPPNJtPynwxbfbc4Hw0ET2FtTMoFO4DHAOHVmhg3cgbCphmh/OczFhLcNsyas5PVn1v3NCDjJnUGEMEFgU= X-MS-TrafficTypeDiagnostic: DB6PR0501MB2037: X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2037; 20:BpqU+PD+3gu3jLo9W6HdSzckrirRg9buui9m+Y7qISttp47pt+h307g0W3Du/Z1mSawg+Qbf5UGxSqOzXRgXOj5VRClsgSABIb3zHmqxTuRDyL2GFrDIOlygEs34EEY4q18Ucc3d1rMLNfvY6pQpI17ZKBzXdkW17nBepw0uU7vOiHIcHRny2bcoUHWofpxtOeQ+h66X9TI8b2L8Q4/RBjAbG3OQg7BlqdnAKGsf6fl/J1pWA4NS6Zm2qsx5ActDZs/hH+BFXKCWPyJ/wqEzsJjIeH6tvV4t6EOmVQ/m1+JGcykd4hE6mOydNWbqshFr2Ko8kbyBBNLdG7fRS9k1Mw7M7+Elgeg3dQHqp5XhbzV4Y4wc/8HF0aaO2GvRWae+6qLWp4n1CDibIrk+4RAw4w9gIPS8zwwe4xCqelyVHVyjdk6x2xZnhL4rOxvtB2buW68szNZh5QlWVmPneP3LU9ob5nuJTUdK+5zoJv33Mco3Awr7Ok2v9+GEO/DzWZrP; 4:Pm40EIlg79DcFe7Iq0n9rL8zVo96pjtQ/IfNiO7YthwCfkCJlkVapS88069oz+TLbtz8SOhaqz5X46L8DYIXfTwwy1nJ9B2so0q+v1EiyI0F7SP0wjzuIPF/0NikCRxq31DV+fedtGl7pf5f2N5xQ6JmIDjKx8R4JFBdzmBxyiHEfbX2xqcSX+0rcl/r5jVb290ONVS0fHn3+CkdH8OrSXQcEDdKW+t3AfJrsSMo8jF914K7pzHRAcq7ZiYBZ4xGW+GxC9H+xJq8qQAItLaBQA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:DB6PR0501MB2037; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0501MB2037; X-Forefront-PRVS: 07083FF734 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(366004)(376002)(39860400002)(39380400002)(346002)(189003)(199004)(3846002)(105586002)(106356001)(386003)(1076002)(52116002)(4326008)(107886003)(6116002)(25786009)(69596002)(53936002)(66066001)(50466002)(478600001)(68736007)(47776003)(55016002)(48376002)(7696005)(51416003)(16526019)(36756003)(16586007)(2616005)(956004)(8676002)(2361001)(81156014)(316002)(81166006)(305945005)(6916009)(5660300001)(2351001)(7736002)(6666003)(97736004)(486006)(476003)(2906002)(8936002)(50226002)(186003)(21086003)(575784001)(86362001)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2037; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0501MB2037; 23:xbt17mFtBEX+2PUQrTnyAB47K42UsRFXq2TA7hr?= =?us-ascii?Q?xceplYgO1xYb+ZOMqiIMXEEgoqn12PItSpHUNH+tC/RdaV3faXgVgy1hV929?= =?us-ascii?Q?LEMyA8QIrQcBb8UJ/N1oy+H9+P/xX4X1HK4i1T4pWEwNA3X31Gc9tTtVbpmk?= =?us-ascii?Q?bsN616r+dpmO6O/TiIR/wuXeHtDGqIIPlexudSvN6R0kQlQRcymWk92xo1DY?= =?us-ascii?Q?zjVc3IrOWd2K/ysDBD3zYuzXAhQ4jO2QIj5HAkCN2ExnxNBEw8QF6PC8hOcd?= =?us-ascii?Q?9s4c9UiobZ82Lr27eRBq2ehHiCHbPDs7MhZbuvT66K3yJ+WmC+BbUcI4aoQ9?= =?us-ascii?Q?zyuUjX8yZN1pYPccgcNnyQbXP1Qz7ep4WhKXBC+mP3fR7Rw8JicXsdy3melj?= =?us-ascii?Q?RByF0bYFup9HcBRAALGSQUkTSQniMnJ3NzpFAvpBqyxjwL/xsDlmRCsDQ7La?= =?us-ascii?Q?ubrAyNP7giQJ9Ox6t9niA3XFZQTYGGY82knaoMHtPL9jj+5shBe9Q+tczJ9G?= =?us-ascii?Q?ponLr1gSawGfnrfoP/W0GoJQOeKuuu4NK3CMasSEnBTItXxvg2lCkna6x8ZW?= =?us-ascii?Q?ZjBNNGbv23Mn3XtnAFVIi8x86gX7eUDkl51omd5h7zjQ2K2/50hQmaEMEKNH?= =?us-ascii?Q?lNkRDDH2IezXv5LR2Jf3xrTczZwmwIS8urV0c84Phw0iZU3qINwjMI8es2XZ?= =?us-ascii?Q?xZ3vyepZWD25kktDbiVh8aiYcmMbYqJ1vXsdihQXKIm0EK6Goq1I2HDkrlEo?= =?us-ascii?Q?s4x8HmmJ3ikq7SqZnq1LdzjB0gsr644M3O+qx1CTIHViDMipWxzhHv1Nzd2/?= =?us-ascii?Q?CjpKl+wxasV6lZ1xRN9xeWfvtS2Fjmnzht+TfgMwa+df9z4EjlsvU9derlzK?= =?us-ascii?Q?6eX/OlCd2ZR9L4+zrL5pI+SoEybKy/u/LZK4NmjszO22LXExNwuhV0CXcQeU?= =?us-ascii?Q?v5WWKTuVxdcIsuUC1pLDuV/5dOyQ/M89WNvG0uHSf008HT2ypXHjj5I7mko6?= =?us-ascii?Q?4Kh5HJwzlUxj2Vy+S0PQ8qZCEsAnK+5aMjaxKBXaYiEayX05ASPefqE0kUWw?= =?us-ascii?Q?XNVemNTduOuwHCIBi9Kx+A0EWnLtYWNtkFzgslXsaj5KJZNXD5NQjpJ3Syj4?= =?us-ascii?Q?Ayg045PTOLlDxNfJyT29/i00Yg9ZDmhR6Lxglku4pxy1Tf431MhJWhr70hGW?= =?us-ascii?Q?bV94DVwVoIWzkI4uQfaQV/MHVl1RA2eAYqr86RSHkyP/aV2F4TWjzeq57ZeG?= =?us-ascii?Q?4amd8MsbP/iE+v0KhDt4=3D?= X-Microsoft-Antispam-Message-Info: 7jtw8Vz/6fbIWR6swRIOqpTGjg2zQ1JFqeX9GttllqR0dQD9jSdg55qbD4b2tS/mb7TyLcLbcd2PUjzyP2fSjboGo4d9DhWawMdVBxapCvNLXDlX8TCc7m5h/+8Kt6jkcPw4j46apLZi8z4lJCIaw3z5Gf1xGYCUuIPPRYDJAUp0ASuJCrx9DDICb9hlpT7wS9FuTaedQW1Yxwi1faVi0Yk5dQWaZ2kSQBiadfw8sFYctr36XrlZcpelopDEPbbvzI8Gjd7NvI/achuPX0Y8ubxKjXLDpH3h8mouw5OrOEP9JREKxT0TQCryYqtC3N76 X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2037; 6:EaKT+A+XfhWzK3foLWGl34nVmbve4iEKSSNLSpj5yyqUPXjOS2T64Ohr+rP3mRG70H5UdZL6EtW5oD2t2G4y9GmGbUDEdmxzWswAD/8ESjtdCU08o1TridZnf6DpOlcXtInjFuREw8m8SRtwYMrI+ohQJq9gdjJ5Pai0NNfRmHZdpbbqOZah4lPHpWBaYgPcrxoDmuo5txYRnQ+p5uGS6cvARb9E1SBwE8zos4+mULbu0Yb9hwfdm6RK4hDDhocFFWGm1dQlK0IfQdQVI4TpiX8dxIub6ITvLXromaxZmtxsN2aYTthWLq/vmy0VOUI7iuYAYG0OS3Y7ctl5Ix5DKjlCpHVI9DR0M25TMeRAbw2REJaptsSMGDoqlaUb+7sJTrmfbWnzRJhceWXIbQeaxYRTZSIgZlY0vimUcuM0Dn6gruijbscftZrD/DTKQzOskG4FSF0PNWI52WgvtZRfLA==; 5:GlBECl8K1NhF73h4OHEswBIS/kUIlaxslsMq0pSUAOqb5IMESjdCYEqsh1emAVeQVsyRzEK6YvSS7Hprk5/TZMgRSQppHJuqLoJMp5OJjt2n8ZSxzYMfop0naQ0zTOlPPRB7SE5x0V6BLtlrobKS1mtESYQZwCdaekpUid9ANfE=; 24:DN3rV5U+yZnPnnK7gmEuB8Ziq+746rLZqu2talHT5TIc13CLK83i928GgLaunTq8PR0b/MRVF6REu14QPiJEaAFfO8Jdvc+3h73/3I7/oEE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2037; 7:cjPRgWaR2xO6lgAhbqA+eufYfEeiROqMS86gcMQACCnXNw8iBLg2AeNpkpAM3ROf4QBmYgdZvFRZMEcEELh9SheiCOZGJqXC0Tqn+ZGOtKewiUx1fZc699JyVp/s7wnkcUPdLzcvcY+xAC74pjAXyhsloYoA4K8mnQiott+5mOuEu9Bl1t8G6cvd4s4qds1YdZlcgUp/med3VseXk1PRNcMcrPL/NcqR2lq5hcoIL+G1KJuINczIESgvIAH3QYx0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2018 23:30:55.1777 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: de483286-0bf2-452f-5b63-08d5d63cb48c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2037 Subject: [dpdk-stable] [PATCH 18.05] net/mlx5: fix GRE flow rule X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2018 23:30:58 -0000 Creating a flow having pattern from the middle of a packet is allowed. For example, testpmd> flow create 0 ingress pattern vxlan vni is 20 / end actions ... Device can parse GRE protocol number in outer IP header but specifying from GRE header can't differentiate it from VxLAN tunnel. As a result, the following rule will be interpreted as a wildcard rule, which always matches any packet. testpmd> flow create 0 ingress pattern gre / end actions ... Fixes: 96c6c65a10d2 ("net/mlx5: support GRE tunnel flow") Fixes: 1f106da2bf7b ("net/mlx5: support MPLS-in-GRE and MPLS-in-UDP") Cc: stable@dpdk.org Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 994be05be..adb995f0d 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -331,8 +331,7 @@ static const struct mlx5_flow_items mlx5_flow_items[] = { [RTE_FLOW_ITEM_TYPE_END] = { .items = ITEMS(RTE_FLOW_ITEM_TYPE_ETH, RTE_FLOW_ITEM_TYPE_VXLAN, - RTE_FLOW_ITEM_TYPE_VXLAN_GPE, - RTE_FLOW_ITEM_TYPE_GRE), + RTE_FLOW_ITEM_TYPE_VXLAN_GPE), }, [RTE_FLOW_ITEM_TYPE_ETH] = { .items = ITEMS(RTE_FLOW_ITEM_TYPE_VLAN, -- 2.11.0