From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: Shahaf Shuler <shahafs@mellanox.com>, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix invalid error check
Date: Wed, 27 Jun 2018 13:55:22 +0200 [thread overview]
Message-ID: <20180627115522.dvxqrbjugasfsmbn@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <20180627091909.22689-1-adrien.mazarguil@6wind.com>
On Wed, Jun 27, 2018 at 11:20:52AM +0200, Adrien Mazarguil wrote:
> Since its return type is unsigned, if_nametoindex() returns 0 in case of
> error, never -1.
>
> Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses")
> Cc: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Cc: stable@dpdk.org
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
> drivers/net/mlx5/mlx5_ethdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
> index 90488af33..ebe5cb6e3 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -192,13 +192,13 @@ int
> mlx5_ifindex(const struct rte_eth_dev *dev)
> {
> char ifname[IF_NAMESIZE];
> - int ret;
> + unsigned int ret;
>
> ret = mlx5_get_ifname(dev, &ifname);
> if (ret)
> return ret;
> ret = if_nametoindex(ifname);
> - if (ret == -1) {
> + if (ret == 0) {
> rte_errno = errno;
> return -rte_errno;
> }
> --
> 2.11.0
Thanks,
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2018-06-27 11:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 9:20 Adrien Mazarguil
2018-06-27 11:55 ` Nélio Laranjeiro [this message]
2018-06-28 6:39 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627115522.dvxqrbjugasfsmbn@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).